* [PATCH] arm64: tegra: Enable all cores on Jetson TX1
@ 2016-06-30 8:01 ` Alexandre Courbot
0 siblings, 0 replies; 6+ messages in thread
From: Alexandre Courbot @ 2016-06-30 8:01 UTC (permalink / raw)
To: Stephen Warren, Thierry Reding, Jon Hunter, linux-arm-kernel,
linux-tegra, linux-kernel
Cc: Alexandre Courbot
Enable PSCI firmware and all 4 cores of T210 on Jetson TX1.
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
Not sure why this was not done - in any case this seems to work fine
and performance is obviously improved (especially boot time).
arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts | 23 ++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts b/arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts
index bb319daf6aa5..6e7fe0517e5c 100644
--- a/arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts
@@ -71,4 +71,27 @@
regulator-enable-ramp-delay = <1000>;
};
};
+
+ cpus {
+ cpu@0 {
+ enable-method = "psci";
+ };
+
+ cpu@1 {
+ enable-method = "psci";
+ };
+
+ cpu@2 {
+ enable-method = "psci";
+ };
+
+ cpu@3 {
+ enable-method = "psci";
+ };
+ };
+
+ psci {
+ compatible = "arm,psci-1.0";
+ method = "smc";
+ };
};
--
2.9.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] arm64: tegra: Enable all cores on Jetson TX1
@ 2016-06-30 8:01 ` Alexandre Courbot
0 siblings, 0 replies; 6+ messages in thread
From: Alexandre Courbot @ 2016-06-30 8:01 UTC (permalink / raw)
To: Stephen Warren, Thierry Reding, Jon Hunter, linux-arm-kernel,
linux-tegra, linux-kernel
Cc: Alexandre Courbot
Enable PSCI firmware and all 4 cores of T210 on Jetson TX1.
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
Not sure why this was not done - in any case this seems to work fine
and performance is obviously improved (especially boot time).
arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts | 23 ++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts b/arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts
index bb319daf6aa5..6e7fe0517e5c 100644
--- a/arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts
@@ -71,4 +71,27 @@
regulator-enable-ramp-delay = <1000>;
};
};
+
+ cpus {
+ cpu@0 {
+ enable-method = "psci";
+ };
+
+ cpu@1 {
+ enable-method = "psci";
+ };
+
+ cpu@2 {
+ enable-method = "psci";
+ };
+
+ cpu@3 {
+ enable-method = "psci";
+ };
+ };
+
+ psci {
+ compatible = "arm,psci-1.0";
+ method = "smc";
+ };
};
--
2.9.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] arm64: tegra: Enable all cores on Jetson TX1
@ 2016-06-30 8:01 ` Alexandre Courbot
0 siblings, 0 replies; 6+ messages in thread
From: Alexandre Courbot @ 2016-06-30 8:01 UTC (permalink / raw)
To: linux-arm-kernel
Enable PSCI firmware and all 4 cores of T210 on Jetson TX1.
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
Not sure why this was not done - in any case this seems to work fine
and performance is obviously improved (especially boot time).
arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts | 23 ++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts b/arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts
index bb319daf6aa5..6e7fe0517e5c 100644
--- a/arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts
@@ -71,4 +71,27 @@
regulator-enable-ramp-delay = <1000>;
};
};
+
+ cpus {
+ cpu at 0 {
+ enable-method = "psci";
+ };
+
+ cpu at 1 {
+ enable-method = "psci";
+ };
+
+ cpu at 2 {
+ enable-method = "psci";
+ };
+
+ cpu at 3 {
+ enable-method = "psci";
+ };
+ };
+
+ psci {
+ compatible = "arm,psci-1.0";
+ method = "smc";
+ };
};
--
2.9.0
^ permalink raw reply related [flat|nested] 6+ messages in thread[parent not found: <20160630080119.27090-1-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH] arm64: tegra: Enable all cores on Jetson TX1
2016-06-30 8:01 ` Alexandre Courbot
(?)
@ 2016-06-30 9:22 ` Thierry Reding
-1 siblings, 0 replies; 6+ messages in thread
From: Thierry Reding @ 2016-06-30 9:22 UTC (permalink / raw)
To: Alexandre Courbot
Cc: Stephen Warren, Jon Hunter,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]
On Thu, Jun 30, 2016 at 05:01:19PM +0900, Alexandre Courbot wrote:
> Enable PSCI firmware and all 4 cores of T210 on Jetson TX1.
>
> Signed-off-by: Alexandre Courbot <acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> Not sure why this was not done - in any case this seems to work fine
> and performance is obviously improved (especially boot time).
>
> arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts | 23 ++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
The reason why this wasn't done initially is because the firmware was
supposed to copy this data into the device tree before passing it to the
kernel. The rationale for this decision was that we can't make any
assumptions about the firmware and any potential PSCI implementation.
I suppose the firmware interface could be argued to be part of the
hardware and therefore having it statically in DT would be okay. The one
remaining issue is that it is possible to boot a Tegra X1 without any
secure firmware that might provide PSCI, in which case the DT would now
be lying.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: tegra: Enable all cores on Jetson TX1
@ 2016-06-30 9:22 ` Thierry Reding
0 siblings, 0 replies; 6+ messages in thread
From: Thierry Reding @ 2016-06-30 9:22 UTC (permalink / raw)
To: Alexandre Courbot
Cc: Stephen Warren, Jon Hunter, linux-arm-kernel, linux-tegra,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1057 bytes --]
On Thu, Jun 30, 2016 at 05:01:19PM +0900, Alexandre Courbot wrote:
> Enable PSCI firmware and all 4 cores of T210 on Jetson TX1.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> ---
> Not sure why this was not done - in any case this seems to work fine
> and performance is obviously improved (especially boot time).
>
> arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts | 23 ++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
The reason why this wasn't done initially is because the firmware was
supposed to copy this data into the device tree before passing it to the
kernel. The rationale for this decision was that we can't make any
assumptions about the firmware and any potential PSCI implementation.
I suppose the firmware interface could be argued to be part of the
hardware and therefore having it statically in DT would be okay. The one
remaining issue is that it is possible to boot a Tegra X1 without any
secure firmware that might provide PSCI, in which case the DT would now
be lying.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm64: tegra: Enable all cores on Jetson TX1
@ 2016-06-30 9:22 ` Thierry Reding
0 siblings, 0 replies; 6+ messages in thread
From: Thierry Reding @ 2016-06-30 9:22 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jun 30, 2016 at 05:01:19PM +0900, Alexandre Courbot wrote:
> Enable PSCI firmware and all 4 cores of T210 on Jetson TX1.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> ---
> Not sure why this was not done - in any case this seems to work fine
> and performance is obviously improved (especially boot time).
>
> arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts | 23 ++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
The reason why this wasn't done initially is because the firmware was
supposed to copy this data into the device tree before passing it to the
kernel. The rationale for this decision was that we can't make any
assumptions about the firmware and any potential PSCI implementation.
I suppose the firmware interface could be argued to be part of the
hardware and therefore having it statically in DT would be okay. The one
remaining issue is that it is possible to boot a Tegra X1 without any
secure firmware that might provide PSCI, in which case the DT would now
be lying.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160630/a45956b2/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-06-30 9:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-30 8:01 [PATCH] arm64: tegra: Enable all cores on Jetson TX1 Alexandre Courbot
2016-06-30 8:01 ` Alexandre Courbot
2016-06-30 8:01 ` Alexandre Courbot
[not found] ` <20160630080119.27090-1-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-06-30 9:22 ` Thierry Reding
2016-06-30 9:22 ` Thierry Reding
2016-06-30 9:22 ` Thierry Reding
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.