All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: Extcon build failure in next
Date: Thu, 30 Jun 2016 05:23:59 -0700	[thread overview]
Message-ID: <20160630122359.GP28140@atomide.com> (raw)
In-Reply-To: <124460021.HZdfr0AOY2@wuerfel>

* Arnd Bergmann <arnd@arndb.de> [160630 05:05]:
> On Thursday, June 30, 2016 4:49:12 AM CEST Tony Lindgren wrote:
> > > > Also I'm seeing:
> > > > 
> > > > drivers/extcon/extcon.c: In function 'extcon_register_notifier':
> > > > drivers/extcon/extcon.c:455:6: warning: 'idx' may be used uninitialized in this function [-Wmaybe-uninitialized]
> > > >    if (idx >= 0) {
> > > >          ^
> > > 
> > > I don't see this one. Which compiler version do you use?
> > 
> > Looks like I'm currently using older arm-none-linux-gnueabi-gcc
> > (Sourcery CodeBench Lite 2014.05-29) 4.8.3 20140320 (prerelease).
> > I think the Debian compiler was not working few months ago and
> > I changed to something I had around.
> > 
> > Looks like the warning does not appear with arm-linux-gnueabihf-gcc
> > (Debian 6.1.1-3) 6.1.1 20160511.
> 
> You are certainly not the only one using gcc-4.7 or gcc-4.8, but
> they are known to produce more false postive -Wmaybe-uninitialized
> warnings and 4.9 or higher. I usually send patches for these warnings
> when gcc-6 finds them, and I have recently sent patches for all
> the warnings I got in allmodconfig with 4.9, but have no plans to
> do that for the older compilers.

OK thanks for the information, I'll change back to something newer
here again.

> I wonder whether we should just disable this warning with gcc-4.8
> by adding $(call cc-ifversion, -eq, 0408, -Wno-maybe-uninitialized)
> to the command line. However, gcc-4.7 does not let you turn off
> the warning at all, so the use of that is fairly limited.

That probably disables warnings also for real warnings too then :)

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: Extcon build failure in next
Date: Thu, 30 Jun 2016 05:23:59 -0700	[thread overview]
Message-ID: <20160630122359.GP28140@atomide.com> (raw)
In-Reply-To: <124460021.HZdfr0AOY2@wuerfel>

* Arnd Bergmann <arnd@arndb.de> [160630 05:05]:
> On Thursday, June 30, 2016 4:49:12 AM CEST Tony Lindgren wrote:
> > > > Also I'm seeing:
> > > > 
> > > > drivers/extcon/extcon.c: In function 'extcon_register_notifier':
> > > > drivers/extcon/extcon.c:455:6: warning: 'idx' may be used uninitialized in this function [-Wmaybe-uninitialized]
> > > >    if (idx >= 0) {
> > > >          ^
> > > 
> > > I don't see this one. Which compiler version do you use?
> > 
> > Looks like I'm currently using older arm-none-linux-gnueabi-gcc
> > (Sourcery CodeBench Lite 2014.05-29) 4.8.3 20140320 (prerelease).
> > I think the Debian compiler was not working few months ago and
> > I changed to something I had around.
> > 
> > Looks like the warning does not appear with arm-linux-gnueabihf-gcc
> > (Debian 6.1.1-3) 6.1.1 20160511.
> 
> You are certainly not the only one using gcc-4.7 or gcc-4.8, but
> they are known to produce more false postive -Wmaybe-uninitialized
> warnings and 4.9 or higher. I usually send patches for these warnings
> when gcc-6 finds them, and I have recently sent patches for all
> the warnings I got in allmodconfig with 4.9, but have no plans to
> do that for the older compilers.

OK thanks for the information, I'll change back to something newer
here again.

> I wonder whether we should just disable this warning with gcc-4.8
> by adding $(call cc-ifversion, -eq, 0408, -Wno-maybe-uninitialized)
> to the command line. However, gcc-4.7 does not let you turn off
> the warning at all, so the use of that is fairly limited.

That probably disables warnings also for real warnings too then :)

Tony

  reply	other threads:[~2016-06-30 12:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-30  5:37 Extcon build failure in next Tony Lindgren
2016-06-30  5:37 ` Tony Lindgren
2016-06-30  5:41 ` Tony Lindgren
2016-06-30  5:41   ` Tony Lindgren
2016-06-30 11:37   ` Arnd Bergmann
2016-06-30 11:37     ` Arnd Bergmann
2016-06-30 11:49     ` Tony Lindgren
2016-06-30 11:49       ` Tony Lindgren
2016-06-30 12:05       ` Arnd Bergmann
2016-06-30 12:05         ` Arnd Bergmann
2016-06-30 12:23         ` Tony Lindgren [this message]
2016-06-30 12:23           ` Tony Lindgren
2016-08-03 15:47     ` Geert Uytterhoeven
2016-08-03 15:47       ` Geert Uytterhoeven
2016-08-04  0:45   ` Chanwoo Choi
2016-08-04  0:45     ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160630122359.GP28140@atomide.com \
    --to=tony@atomide.com \
    --cc=arnd@arndb.de \
    --cc=cw00.choi@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.