From: Baoquan He <bhe@redhat.com>
To: lkp@lists.01.org
Subject: Re: [x86/KASLR] ed9f007ee6: -- System halted
Date: Fri, 01 Jul 2016 15:50:32 +0800 [thread overview]
Message-ID: <20160701075032.GC10467@x1.redhat.com> (raw)
In-Reply-To: <57712812.r6MdDSquaCRYkMnh%xiaolong.ye@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]
Hi Xiaolong,
Could you please apply below patch and see if it works for you?
>From 46c2a9ecd11f61d952253e005bbd7dcbffa652fb Mon Sep 17 00:00:00 2001
From: Baoquan He <bhe@redhat.com>
Date: Fri, 1 Jul 2016 15:34:40 +0800
Subject: [PATCH] x86/KASLR: Fix code bug of finding earliest overlap
Signed-off-by: Baoquan He <bhe@redhat.com>
---
arch/x86/boot/compressed/kaslr.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/x86/boot/compressed/kaslr.c b/arch/x86/boot/compressed/kaslr.c
index 304c5c3..8e1fdf7 100644
--- a/arch/x86/boot/compressed/kaslr.c
+++ b/arch/x86/boot/compressed/kaslr.c
@@ -285,6 +285,7 @@ static bool mem_avoid_overlap(struct mem_vector *img,
if (mem_overlaps(img, &mem_avoid[i]) &&
mem_avoid[i].start < earliest) {
*overlap = mem_avoid[i];
+ earliest = overlap->start;
is_overlapping = true;
}
}
@@ -299,6 +300,7 @@ static bool mem_avoid_overlap(struct mem_vector *img,
if (mem_overlaps(img, &avoid) && (avoid.start < earliest)) {
*overlap = avoid;
+ earliest = overlap->start;
is_overlapping = true;
}
--
2.5.5
WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: kernel test robot <xiaolong.ye@intel.com>
Cc: Kees Cook <keescook@chromium.org>,
lkp@01.org, tipbuild@zytor.com, linux-kernel@vger.kernel.org,
Yinghai Lu <yinghai@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
"H.J. Lu" <hjl.tools@gmail.com>, "H. Peter Anvin" <hpa@zytor.com>,
Dmitry Vyukov <dvyukov@google.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
Brian Gerst <brgerst@gmail.com>, Borislav Petkov <bp@alien8.de>,
Andy Lutomirski <luto@kernel.org>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [x86/KASLR] ed9f007ee6: -- System halted
Date: Fri, 1 Jul 2016 15:50:32 +0800 [thread overview]
Message-ID: <20160701075032.GC10467@x1.redhat.com> (raw)
In-Reply-To: <57712812.r6MdDSquaCRYkMnh%xiaolong.ye@intel.com>
Hi Xiaolong,
Could you please apply below patch and see if it works for you?
>From 46c2a9ecd11f61d952253e005bbd7dcbffa652fb Mon Sep 17 00:00:00 2001
From: Baoquan He <bhe@redhat.com>
Date: Fri, 1 Jul 2016 15:34:40 +0800
Subject: [PATCH] x86/KASLR: Fix code bug of finding earliest overlap
Signed-off-by: Baoquan He <bhe@redhat.com>
---
arch/x86/boot/compressed/kaslr.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/x86/boot/compressed/kaslr.c b/arch/x86/boot/compressed/kaslr.c
index 304c5c3..8e1fdf7 100644
--- a/arch/x86/boot/compressed/kaslr.c
+++ b/arch/x86/boot/compressed/kaslr.c
@@ -285,6 +285,7 @@ static bool mem_avoid_overlap(struct mem_vector *img,
if (mem_overlaps(img, &mem_avoid[i]) &&
mem_avoid[i].start < earliest) {
*overlap = mem_avoid[i];
+ earliest = overlap->start;
is_overlapping = true;
}
}
@@ -299,6 +300,7 @@ static bool mem_avoid_overlap(struct mem_vector *img,
if (mem_overlaps(img, &avoid) && (avoid.start < earliest)) {
*overlap = avoid;
+ earliest = overlap->start;
is_overlapping = true;
}
--
2.5.5
next prev parent reply other threads:[~2016-07-01 7:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 13:20 [x86/KASLR] ed9f007ee6: -- System halted kernel test robot
2016-06-27 18:59 ` Yinghai Lu
2016-06-27 18:59 ` Yinghai Lu
2016-06-28 5:43 ` Ye Xiaolong
2016-06-28 19:49 ` Yinghai Lu
2016-06-29 20:08 ` Yinghai Lu
2016-06-29 20:08 ` Yinghai Lu
2016-06-29 20:29 ` Huang, Ying
2016-06-29 20:29 ` [LKP] " Huang, Ying
2016-06-30 4:49 ` Yinghai Lu
2016-06-30 4:49 ` [LKP] " Yinghai Lu
2016-06-30 6:58 ` Ye Xiaolong
2016-06-30 6:58 ` [LKP] " Ye Xiaolong
2016-07-01 0:24 ` Yinghai Lu
2016-07-01 0:24 ` [LKP] " Yinghai Lu
2016-07-01 4:06 ` Baoquan He
2016-07-01 4:06 ` [LKP] " Baoquan He
2016-07-01 4:46 ` Baoquan He
2016-07-01 4:46 ` [LKP] " Baoquan He
2016-07-01 7:50 ` Baoquan He [this message]
2016-07-01 7:50 ` Baoquan He
2016-07-01 12:16 ` Ye Xiaolong
2016-07-01 12:16 ` Ye Xiaolong
2016-07-01 13:14 ` Baoquan He
2016-07-01 13:14 ` Baoquan He
2016-07-01 13:25 ` Baoquan He
2016-07-01 13:25 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160701075032.GC10467@x1.redhat.com \
--to=bhe@redhat.com \
--cc=lkp@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.