* [patch] drm/mediatek/mtk_mipi_tx: checking the wrong variable
@ 2016-07-01 13:59 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-07-01 13:59 UTC (permalink / raw)
To: David Airlie, CK Hu
Cc: Jitao Shi, kernel-janitors, dri-devel, linux-mediatek,
Matthias Brugger
We should be checking "phy_provider" here not "phy".
Fixes: 2e54c14e310f ('drm/mediatek: Add DSI sub driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c b/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
index cf8f38d..1c366f8 100644
--- a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
+++ b/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
@@ -431,7 +431,7 @@ static int mtk_mipi_tx_probe(struct platform_device *pdev)
phy_set_drvdata(phy, mipi_tx);
phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
- if (IS_ERR(phy)) {
+ if (IS_ERR(phy_provider)) {
ret = PTR_ERR(phy_provider);
return ret;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread* [patch] drm/mediatek/mtk_mipi_tx: checking the wrong variable
@ 2016-07-01 13:59 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-07-01 13:59 UTC (permalink / raw)
To: David Airlie, CK Hu
Cc: Jitao Shi, kernel-janitors, dri-devel, linux-mediatek,
Matthias Brugger
We should be checking "phy_provider" here not "phy".
Fixes: 2e54c14e310f ('drm/mediatek: Add DSI sub driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c b/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
index cf8f38d..1c366f8 100644
--- a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
+++ b/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
@@ -431,7 +431,7 @@ static int mtk_mipi_tx_probe(struct platform_device *pdev)
phy_set_drvdata(phy, mipi_tx);
phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
- if (IS_ERR(phy)) {
+ if (IS_ERR(phy_provider)) {
ret = PTR_ERR(phy_provider);
return ret;
}
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [patch] drm/mediatek/mtk_mipi_tx: checking the wrong variable
2016-07-01 13:59 ` Dan Carpenter
@ 2016-07-02 16:44 ` Matthias Brugger
-1 siblings, 0 replies; 6+ messages in thread
From: Matthias Brugger @ 2016-07-02 16:44 UTC (permalink / raw)
To: Dan Carpenter, David Airlie, CK Hu
Cc: Jitao Shi, Philipp Zabel, dri-devel, linux-mediatek,
kernel-janitors
On 07/01/2016 03:59 PM, Dan Carpenter wrote:
> We should be checking "phy_provider" here not "phy".
>
> Fixes: 2e54c14e310f ('drm/mediatek: Add DSI sub driver')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> diff --git a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c b/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
> index cf8f38d..1c366f8 100644
> --- a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
> +++ b/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
> @@ -431,7 +431,7 @@ static int mtk_mipi_tx_probe(struct platform_device *pdev)
> phy_set_drvdata(phy, mipi_tx);
>
> phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
> - if (IS_ERR(phy)) {
> + if (IS_ERR(phy_provider)) {
> ret = PTR_ERR(phy_provider);
> return ret;
> }
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] drm/mediatek/mtk_mipi_tx: checking the wrong variable
@ 2016-07-02 16:44 ` Matthias Brugger
0 siblings, 0 replies; 6+ messages in thread
From: Matthias Brugger @ 2016-07-02 16:44 UTC (permalink / raw)
To: Dan Carpenter, David Airlie, CK Hu
Cc: Jitao Shi, Philipp Zabel, dri-devel, linux-mediatek,
kernel-janitors
On 07/01/2016 03:59 PM, Dan Carpenter wrote:
> We should be checking "phy_provider" here not "phy".
>
> Fixes: 2e54c14e310f ('drm/mediatek: Add DSI sub driver')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> diff --git a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c b/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
> index cf8f38d..1c366f8 100644
> --- a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
> +++ b/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
> @@ -431,7 +431,7 @@ static int mtk_mipi_tx_probe(struct platform_device *pdev)
> phy_set_drvdata(phy, mipi_tx);
>
> phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
> - if (IS_ERR(phy)) {
> + if (IS_ERR(phy_provider)) {
> ret = PTR_ERR(phy_provider);
> return ret;
> }
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] drm/mediatek/mtk_mipi_tx: checking the wrong variable
2016-07-02 16:44 ` Matthias Brugger
@ 2016-07-12 12:47 ` Daniel Vetter
-1 siblings, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2016-07-12 12:47 UTC (permalink / raw)
To: Matthias Brugger
Cc: Dan Carpenter, David Airlie, CK Hu, linux-mediatek,
kernel-janitors, Jitao Shi, dri-devel
On Sat, Jul 02, 2016 at 06:44:13PM +0200, Matthias Brugger wrote:
>
>
> On 07/01/2016 03:59 PM, Dan Carpenter wrote:
> > We should be checking "phy_provider" here not "phy".
> >
> > Fixes: 2e54c14e310f ('drm/mediatek: Add DSI sub driver')
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Applied to drm-misc, thanks.
-Daniel
>
> > diff --git a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c b/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
> > index cf8f38d..1c366f8 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
> > @@ -431,7 +431,7 @@ static int mtk_mipi_tx_probe(struct platform_device *pdev)
> > phy_set_drvdata(phy, mipi_tx);
> >
> > phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
> > - if (IS_ERR(phy)) {
> > + if (IS_ERR(phy_provider)) {
> > ret = PTR_ERR(phy_provider);
> > return ret;
> > }
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] drm/mediatek/mtk_mipi_tx: checking the wrong variable
@ 2016-07-12 12:47 ` Daniel Vetter
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2016-07-12 12:47 UTC (permalink / raw)
To: Matthias Brugger
Cc: Dan Carpenter, David Airlie, CK Hu, linux-mediatek,
kernel-janitors, Jitao Shi, dri-devel
On Sat, Jul 02, 2016 at 06:44:13PM +0200, Matthias Brugger wrote:
>
>
> On 07/01/2016 03:59 PM, Dan Carpenter wrote:
> > We should be checking "phy_provider" here not "phy".
> >
> > Fixes: 2e54c14e310f ('drm/mediatek: Add DSI sub driver')
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Applied to drm-misc, thanks.
-Daniel
>
> > diff --git a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c b/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
> > index cf8f38d..1c366f8 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
> > @@ -431,7 +431,7 @@ static int mtk_mipi_tx_probe(struct platform_device *pdev)
> > phy_set_drvdata(phy, mipi_tx);
> >
> > phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
> > - if (IS_ERR(phy)) {
> > + if (IS_ERR(phy_provider)) {
> > ret = PTR_ERR(phy_provider);
> > return ret;
> > }
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-07-12 12:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-01 13:59 [patch] drm/mediatek/mtk_mipi_tx: checking the wrong variable Dan Carpenter
2016-07-01 13:59 ` Dan Carpenter
2016-07-02 16:44 ` Matthias Brugger
2016-07-02 16:44 ` Matthias Brugger
2016-07-12 12:47 ` Daniel Vetter
2016-07-12 12:47 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.