* [PATCH] soc: qcom: smem: Silence probe defer error
@ 2016-07-01 21:18 ` Stephen Boyd
0 siblings, 0 replies; 7+ messages in thread
From: Stephen Boyd @ 2016-07-01 21:18 UTC (permalink / raw)
To: Andy Gross; +Cc: linux-kernel, linux-arm-msm, linux-arm-kernel, Bjorn Andersson
If we fail to get the hwspinlock due to probe defer, we shouldn't
print an error message. Just be silent in this case.
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
drivers/soc/qcom/smem.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c
index 2e1aa9f130f4..18ec52f2078a 100644
--- a/drivers/soc/qcom/smem.c
+++ b/drivers/soc/qcom/smem.c
@@ -740,7 +740,8 @@ static int qcom_smem_probe(struct platform_device *pdev)
hwlock_id = of_hwspin_lock_get_id(pdev->dev.of_node, 0);
if (hwlock_id < 0) {
- dev_err(&pdev->dev, "failed to retrieve hwlock\n");
+ if (hwlock_id != -EPROBE_DEFER)
+ dev_err(&pdev->dev, "failed to retrieve hwlock\n");
return hwlock_id;
}
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] soc: qcom: smem: Silence probe defer error
@ 2016-07-01 21:18 ` Stephen Boyd
0 siblings, 0 replies; 7+ messages in thread
From: Stephen Boyd @ 2016-07-01 21:18 UTC (permalink / raw)
To: linux-arm-kernel
If we fail to get the hwspinlock due to probe defer, we shouldn't
print an error message. Just be silent in this case.
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
drivers/soc/qcom/smem.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c
index 2e1aa9f130f4..18ec52f2078a 100644
--- a/drivers/soc/qcom/smem.c
+++ b/drivers/soc/qcom/smem.c
@@ -740,7 +740,8 @@ static int qcom_smem_probe(struct platform_device *pdev)
hwlock_id = of_hwspin_lock_get_id(pdev->dev.of_node, 0);
if (hwlock_id < 0) {
- dev_err(&pdev->dev, "failed to retrieve hwlock\n");
+ if (hwlock_id != -EPROBE_DEFER)
+ dev_err(&pdev->dev, "failed to retrieve hwlock\n");
return hwlock_id;
}
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] soc: qcom: smem: Silence probe defer error
2016-07-01 21:18 ` Stephen Boyd
@ 2016-07-01 21:32 ` Andy Gross
-1 siblings, 0 replies; 7+ messages in thread
From: Andy Gross @ 2016-07-01 21:32 UTC (permalink / raw)
To: Stephen Boyd
Cc: linux-kernel, linux-arm-msm, linux-arm-kernel, Bjorn Andersson
On Fri, Jul 01, 2016 at 02:18:59PM -0700, Stephen Boyd wrote:
> If we fail to get the hwspinlock due to probe defer, we shouldn't
> print an error message. Just be silent in this case.
>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Looks good to me. This has needed to be fixed for a while. Thanks!
Andy
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] soc: qcom: smem: Silence probe defer error
@ 2016-07-01 21:32 ` Andy Gross
0 siblings, 0 replies; 7+ messages in thread
From: Andy Gross @ 2016-07-01 21:32 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jul 01, 2016 at 02:18:59PM -0700, Stephen Boyd wrote:
> If we fail to get the hwspinlock due to probe defer, we shouldn't
> print an error message. Just be silent in this case.
>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Looks good to me. This has needed to be fixed for a while. Thanks!
Andy
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] soc: qcom: smem: Silence probe defer error
2016-07-01 21:18 ` Stephen Boyd
(?)
@ 2016-07-01 21:40 ` Bjorn Andersson
-1 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2016-07-01 21:40 UTC (permalink / raw)
To: Stephen Boyd; +Cc: Andy Gross, linux-arm-msm, linux-kernel, linux-arm-kernel
On Fri 01 Jul 14:18 PDT 2016, Stephen Boyd wrote:
> If we fail to get the hwspinlock due to probe defer, we shouldn't
> print an error message. Just be silent in this case.
>
This generally seems to result in a large pile of drivers ending up on
the probe deferr list, so something we should try to avoid.
But the patch itself looks good:
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> drivers/soc/qcom/smem.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c
> index 2e1aa9f130f4..18ec52f2078a 100644
> --- a/drivers/soc/qcom/smem.c
> +++ b/drivers/soc/qcom/smem.c
> @@ -740,7 +740,8 @@ static int qcom_smem_probe(struct platform_device *pdev)
>
> hwlock_id = of_hwspin_lock_get_id(pdev->dev.of_node, 0);
> if (hwlock_id < 0) {
> - dev_err(&pdev->dev, "failed to retrieve hwlock\n");
> + if (hwlock_id != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "failed to retrieve hwlock\n");
> return hwlock_id;
> }
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] soc: qcom: smem: Silence probe defer error
@ 2016-07-01 21:40 ` Bjorn Andersson
0 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2016-07-01 21:40 UTC (permalink / raw)
To: Stephen Boyd; +Cc: Andy Gross, linux-kernel, linux-arm-msm, linux-arm-kernel
On Fri 01 Jul 14:18 PDT 2016, Stephen Boyd wrote:
> If we fail to get the hwspinlock due to probe defer, we shouldn't
> print an error message. Just be silent in this case.
>
This generally seems to result in a large pile of drivers ending up on
the probe deferr list, so something we should try to avoid.
But the patch itself looks good:
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> drivers/soc/qcom/smem.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c
> index 2e1aa9f130f4..18ec52f2078a 100644
> --- a/drivers/soc/qcom/smem.c
> +++ b/drivers/soc/qcom/smem.c
> @@ -740,7 +740,8 @@ static int qcom_smem_probe(struct platform_device *pdev)
>
> hwlock_id = of_hwspin_lock_get_id(pdev->dev.of_node, 0);
> if (hwlock_id < 0) {
> - dev_err(&pdev->dev, "failed to retrieve hwlock\n");
> + if (hwlock_id != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "failed to retrieve hwlock\n");
> return hwlock_id;
> }
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH] soc: qcom: smem: Silence probe defer error
@ 2016-07-01 21:40 ` Bjorn Andersson
0 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2016-07-01 21:40 UTC (permalink / raw)
To: linux-arm-kernel
On Fri 01 Jul 14:18 PDT 2016, Stephen Boyd wrote:
> If we fail to get the hwspinlock due to probe defer, we shouldn't
> print an error message. Just be silent in this case.
>
This generally seems to result in a large pile of drivers ending up on
the probe deferr list, so something we should try to avoid.
But the patch itself looks good:
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> drivers/soc/qcom/smem.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c
> index 2e1aa9f130f4..18ec52f2078a 100644
> --- a/drivers/soc/qcom/smem.c
> +++ b/drivers/soc/qcom/smem.c
> @@ -740,7 +740,8 @@ static int qcom_smem_probe(struct platform_device *pdev)
>
> hwlock_id = of_hwspin_lock_get_id(pdev->dev.of_node, 0);
> if (hwlock_id < 0) {
> - dev_err(&pdev->dev, "failed to retrieve hwlock\n");
> + if (hwlock_id != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "failed to retrieve hwlock\n");
> return hwlock_id;
> }
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-07-01 21:48 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-01 21:18 [PATCH] soc: qcom: smem: Silence probe defer error Stephen Boyd
2016-07-01 21:18 ` Stephen Boyd
2016-07-01 21:32 ` Andy Gross
2016-07-01 21:32 ` Andy Gross
2016-07-01 21:40 ` Bjorn Andersson
2016-07-01 21:40 ` Bjorn Andersson
2016-07-01 21:40 ` Bjorn Andersson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.