* [patch] mwifiex: fix mwifiex_add_virtual_intf()
@ 2016-07-02 7:20 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2016-07-02 7:20 UTC (permalink / raw)
To: Amitkumar Karwar
Cc: Nishant Sarmukadam, Kalle Valo, linux-wireless, kernel-janitors
We accidentally left some if statements out so the
mwifiex_add_virtual_intf() function returns early.
Fixes: 7311ea850079 ('mwifiex: fix AP start problem for newly added interface')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
index 99e8cf1..5de9f63 100644
--- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
+++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
@@ -2865,9 +2865,11 @@ struct wireless_dev *mwifiex_add_virtual_intf(struct wiphy *wiphy,
ret = mwifiex_send_cmd(priv, HostCmd_CMD_SET_BSS_MODE,
HostCmd_ACT_GEN_SET, 0, NULL, true);
+ if (ret)
return ERR_PTR(ret);
ret = mwifiex_sta_init_cmd(priv, false, false);
+ if (ret)
return ERR_PTR(ret);
mwifiex_setup_ht_caps(&wiphy->bands[NL80211_BAND_2GHZ]->ht_cap, priv);
^ permalink raw reply related [flat|nested] 4+ messages in thread* [patch] mwifiex: fix mwifiex_add_virtual_intf()
@ 2016-07-02 7:20 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2016-07-02 7:20 UTC (permalink / raw)
To: Amitkumar Karwar
Cc: Nishant Sarmukadam, Kalle Valo, linux-wireless, kernel-janitors
We accidentally left some if statements out so the
mwifiex_add_virtual_intf() function returns early.
Fixes: 7311ea850079 ('mwifiex: fix AP start problem for newly added interface')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
index 99e8cf1..5de9f63 100644
--- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
+++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
@@ -2865,9 +2865,11 @@ struct wireless_dev *mwifiex_add_virtual_intf(struct wiphy *wiphy,
ret = mwifiex_send_cmd(priv, HostCmd_CMD_SET_BSS_MODE,
HostCmd_ACT_GEN_SET, 0, NULL, true);
+ if (ret)
return ERR_PTR(ret);
ret = mwifiex_sta_init_cmd(priv, false, false);
+ if (ret)
return ERR_PTR(ret);
mwifiex_setup_ht_caps(&wiphy->bands[NL80211_BAND_2GHZ]->ht_cap, priv);
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [patch] mwifiex: fix mwifiex_add_virtual_intf()
2016-07-02 7:20 ` Dan Carpenter
@ 2016-07-02 18:00 ` Arend Van Spriel
-1 siblings, 0 replies; 4+ messages in thread
From: Arend Van Spriel @ 2016-07-02 18:00 UTC (permalink / raw)
To: Dan Carpenter, Amitkumar Karwar
Cc: Nishant Sarmukadam, Kalle Valo, linux-wireless, kernel-janitors
On 2-7-2016 9:20, Dan Carpenter wrote:
> We accidentally left some if statements out so the
> mwifiex_add_virtual_intf() function returns early.
>
> Fixes: 7311ea850079 ('mwifiex: fix AP start problem for newly added interface')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Someone beat you to it [1] ;-)
Regards,
Arend
[1]
http://mid.gmane.org/1467401982-18943-1-git-send-email-javier@osg.samsung.com
> diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> index 99e8cf1..5de9f63 100644
> --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> @@ -2865,9 +2865,11 @@ struct wireless_dev *mwifiex_add_virtual_intf(struct wiphy *wiphy,
>
> ret = mwifiex_send_cmd(priv, HostCmd_CMD_SET_BSS_MODE,
> HostCmd_ACT_GEN_SET, 0, NULL, true);
> + if (ret)
> return ERR_PTR(ret);
>
> ret = mwifiex_sta_init_cmd(priv, false, false);
> + if (ret)
> return ERR_PTR(ret);
>
> mwifiex_setup_ht_caps(&wiphy->bands[NL80211_BAND_2GHZ]->ht_cap, priv);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [patch] mwifiex: fix mwifiex_add_virtual_intf()
@ 2016-07-02 18:00 ` Arend Van Spriel
0 siblings, 0 replies; 4+ messages in thread
From: Arend Van Spriel @ 2016-07-02 18:00 UTC (permalink / raw)
To: Dan Carpenter, Amitkumar Karwar
Cc: Nishant Sarmukadam, Kalle Valo, linux-wireless, kernel-janitors
On 2-7-2016 9:20, Dan Carpenter wrote:
> We accidentally left some if statements out so the
> mwifiex_add_virtual_intf() function returns early.
>
> Fixes: 7311ea850079 ('mwifiex: fix AP start problem for newly added interface')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Someone beat you to it [1] ;-)
Regards,
Arend
[1]
http://mid.gmane.org/1467401982-18943-1-git-send-email-javier@osg.samsung.com
> diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> index 99e8cf1..5de9f63 100644
> --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> @@ -2865,9 +2865,11 @@ struct wireless_dev *mwifiex_add_virtual_intf(struct wiphy *wiphy,
>
> ret = mwifiex_send_cmd(priv, HostCmd_CMD_SET_BSS_MODE,
> HostCmd_ACT_GEN_SET, 0, NULL, true);
> + if (ret)
> return ERR_PTR(ret);
>
> ret = mwifiex_sta_init_cmd(priv, false, false);
> + if (ret)
> return ERR_PTR(ret);
>
> mwifiex_setup_ht_caps(&wiphy->bands[NL80211_BAND_2GHZ]->ht_cap, priv);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-07-02 18:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-02 7:20 [patch] mwifiex: fix mwifiex_add_virtual_intf() Dan Carpenter
2016-07-02 7:20 ` Dan Carpenter
2016-07-02 18:00 ` Arend Van Spriel
2016-07-02 18:00 ` Arend Van Spriel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.