From: Gavin Shan <gwshan@linux.vnet.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Joel Stanley <joel@jms.id.au>,
Gavin Shan <gwshan@linux.vnet.ibm.com>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH 08/10] net/farady: Support NCSI mode
Date: Sun, 3 Jul 2016 15:37:36 +1000 [thread overview]
Message-ID: <20160703053736.GB9530@gwshan> (raw)
In-Reply-To: <1467372416.7422.42.camel@kernel.crashing.org>
On Fri, Jul 01, 2016 at 09:26:56PM +1000, Benjamin Herrenschmidt wrote:
>On Thu, 2016-06-30 at 23:35 +0930, Joel Stanley wrote:
>> We get this message whenever the device is brought up or down. This
>> includes when the host reboots, filling up the bmc's kernel logs.
>>
>> However, when we had the timer race it was the only way to know what
>> was going on. Can we detect when it's the host bringing the device
>> down opposed to an "ifconfig up" failing to bring it up?
>
>What would be nice would be if we could mirror that into the "carrier"
>state of the interface (which normally corresponds to the PHY link
>state).
>
>The problem however is that when the carrier is off, the network stack
>will ditch packets, which doen't work for us since we still need to
>talk NSCI ...
>
>I'm thinking we should create some netdev flags so that the generic
>link monitor stops bringing it down in that case. That way we can
>set the carrier and eixsting stuff that knows how to read and interpret
>it will work.
>
Ben and Joel, thank you very much for your comments. I'm sorry this comment
isn't covered in the revision I sent to community just. I will evaluate it
later and improve it accordingly. Note this is the only comment not covered
in the revision sent to community, all other comments should be covered there
if I didn't miss any of them.
Thanks,
Gavin
>Cheers,
>Ben.
>
next prev parent reply other threads:[~2016-07-03 5:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 10:27 [PATCH 00/10] NCSI Support Gavin Shan
2016-06-30 10:27 ` [PATCH 01/10] net/ncsi: Resource management Gavin Shan
2016-06-30 14:04 ` Joel Stanley
2016-06-30 10:27 ` [PATCH 02/10] net/ncsi: NCSI command packet handler Gavin Shan
2016-06-30 14:05 ` Joel Stanley
2016-06-30 10:27 ` [PATCH 03/10] net/ncsi: NCSI response " Gavin Shan
2016-06-30 14:05 ` Joel Stanley
2016-06-30 10:27 ` [PATCH 04/10] net/ncsi: Package and channel management Gavin Shan
2016-06-30 14:05 ` Joel Stanley
2016-06-30 10:27 ` [PATCH 05/10] net/ncsi: NCSI AEN packet handler Gavin Shan
2016-06-30 14:05 ` Joel Stanley
2016-06-30 10:27 ` [PATCH 06/10] net/farady: Helper functions to create or destroy MDIO interface Gavin Shan
2016-06-30 13:49 ` Joel Stanley
2016-07-01 2:59 ` Benjamin Herrenschmidt
2016-06-30 10:27 ` [PATCH 07/10] net/farady: Read MAC address from chip Gavin Shan
2016-06-30 14:05 ` Joel Stanley
2016-07-01 11:25 ` Benjamin Herrenschmidt
[not found] ` <CACPK8XdAiDW=PADte4ZWNumKYXCkK-8kcw0atOUQATORsRQEGA@mail.gmail.com>
2016-07-01 12:17 ` Joel Stanley
2016-07-01 13:20 ` Benjamin Herrenschmidt
2016-07-03 5:35 ` Gavin Shan
2016-06-30 10:27 ` [PATCH 08/10] net/farady: Support NCSI mode Gavin Shan
2016-06-30 14:05 ` Joel Stanley
2016-07-01 11:26 ` Benjamin Herrenschmidt
2016-07-03 5:37 ` Gavin Shan [this message]
2016-06-30 10:27 ` [PATCH 09/10] net/farady: Match driver according to compatible property Gavin Shan
2016-06-30 14:06 ` Joel Stanley
2016-06-30 10:27 ` [PATCH 10/10] net/farady: Mask PHY interrupt with NCSI mode Gavin Shan
2016-06-30 14:06 ` Joel Stanley
2016-07-03 5:40 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160703053736.GB9530@gwshan \
--to=gwshan@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=joel@jms.id.au \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.