From: Gavin Shan <gwshan@linux.vnet.ibm.com>
To: Joel Stanley <joel@jms.id.au>
Cc: Gavin Shan <gwshan@linux.vnet.ibm.com>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH 10/10] net/farady: Mask PHY interrupt with NCSI mode
Date: Sun, 3 Jul 2016 15:40:15 +1000 [thread overview]
Message-ID: <20160703054015.GC9530@gwshan> (raw)
In-Reply-To: <CACPK8XfGFZ-1NjOvvEgoFx3Aox+W6EiHWoLf50j++vD4q99EHQ@mail.gmail.com>
On Thu, Jun 30, 2016 at 11:36:07PM +0930, Joel Stanley wrote:
>On Thu, Jun 30, 2016 at 7:57 PM, Gavin Shan <gwshan@linux.vnet.ibm.com> wrote:
>> if (pdev->dev.of_node &&
>> (of_get_property(pdev->dev.of_node, "use-nc-si", NULL) ||
>> of_get_property(pdev->dev.of_node, "use-ncsi", NULL))) {
>
>As before, lets pick single a property and stick with it.
>
The reason why I used two strings is the change is still fine on those BMCs
where "ncsi-nc-si" is supported only. Joel, I personal prefer "use-ncsi".
Lets adjust it later in device-tree.
Thanks,
Gavin
prev parent reply other threads:[~2016-07-03 5:40 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 10:27 [PATCH 00/10] NCSI Support Gavin Shan
2016-06-30 10:27 ` [PATCH 01/10] net/ncsi: Resource management Gavin Shan
2016-06-30 14:04 ` Joel Stanley
2016-06-30 10:27 ` [PATCH 02/10] net/ncsi: NCSI command packet handler Gavin Shan
2016-06-30 14:05 ` Joel Stanley
2016-06-30 10:27 ` [PATCH 03/10] net/ncsi: NCSI response " Gavin Shan
2016-06-30 14:05 ` Joel Stanley
2016-06-30 10:27 ` [PATCH 04/10] net/ncsi: Package and channel management Gavin Shan
2016-06-30 14:05 ` Joel Stanley
2016-06-30 10:27 ` [PATCH 05/10] net/ncsi: NCSI AEN packet handler Gavin Shan
2016-06-30 14:05 ` Joel Stanley
2016-06-30 10:27 ` [PATCH 06/10] net/farady: Helper functions to create or destroy MDIO interface Gavin Shan
2016-06-30 13:49 ` Joel Stanley
2016-07-01 2:59 ` Benjamin Herrenschmidt
2016-06-30 10:27 ` [PATCH 07/10] net/farady: Read MAC address from chip Gavin Shan
2016-06-30 14:05 ` Joel Stanley
2016-07-01 11:25 ` Benjamin Herrenschmidt
[not found] ` <CACPK8XdAiDW=PADte4ZWNumKYXCkK-8kcw0atOUQATORsRQEGA@mail.gmail.com>
2016-07-01 12:17 ` Joel Stanley
2016-07-01 13:20 ` Benjamin Herrenschmidt
2016-07-03 5:35 ` Gavin Shan
2016-06-30 10:27 ` [PATCH 08/10] net/farady: Support NCSI mode Gavin Shan
2016-06-30 14:05 ` Joel Stanley
2016-07-01 11:26 ` Benjamin Herrenschmidt
2016-07-03 5:37 ` Gavin Shan
2016-06-30 10:27 ` [PATCH 09/10] net/farady: Match driver according to compatible property Gavin Shan
2016-06-30 14:06 ` Joel Stanley
2016-06-30 10:27 ` [PATCH 10/10] net/farady: Mask PHY interrupt with NCSI mode Gavin Shan
2016-06-30 14:06 ` Joel Stanley
2016-07-03 5:40 ` Gavin Shan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160703054015.GC9530@gwshan \
--to=gwshan@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=joel@jms.id.au \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.