From: Minchan Kim <minchan@kernel.org>
To: Ganesh Mahendran <opensource.ganesh@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, ngupta@vflare.org,
sergey.senozhatsky.work@gmail.com, rostedt@goodmis.org,
mingo@redhat.com
Subject: Re: [PATCH 6/8] mm/zsmalloc: keep comments consistent with code
Date: Mon, 4 Jul 2016 09:05:16 +0900 [thread overview]
Message-ID: <20160704000516.GE19044@bbox> (raw)
In-Reply-To: <1467355266-9735-6-git-send-email-opensource.ganesh@gmail.com>
On Fri, Jul 01, 2016 at 02:41:04PM +0800, Ganesh Mahendran wrote:
> some minor change of comments:
> 1). update zs_malloc(),zs_create_pool() function header
> 2). update "Usage of struct page fields"
>
> Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
> ---
> mm/zsmalloc.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> index 2690914..6fc631a 100644
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -20,6 +20,7 @@
> * page->freelist(index): links together all component pages of a zspage
> * For the huge page, this is always 0, so we use this field
> * to store handle.
> + * page->units: first object index in a subpage of zspage
Hmm, I want to use offset instead of index.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Ganesh Mahendran <opensource.ganesh@gmail.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
<akpm@linux-foundation.org>, <ngupta@vflare.org>,
<sergey.senozhatsky.work@gmail.com>, <rostedt@goodmis.org>,
<mingo@redhat.com>
Subject: Re: [PATCH 6/8] mm/zsmalloc: keep comments consistent with code
Date: Mon, 4 Jul 2016 09:05:16 +0900 [thread overview]
Message-ID: <20160704000516.GE19044@bbox> (raw)
In-Reply-To: <1467355266-9735-6-git-send-email-opensource.ganesh@gmail.com>
On Fri, Jul 01, 2016 at 02:41:04PM +0800, Ganesh Mahendran wrote:
> some minor change of comments:
> 1). update zs_malloc(),zs_create_pool() function header
> 2). update "Usage of struct page fields"
>
> Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
> ---
> mm/zsmalloc.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> index 2690914..6fc631a 100644
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -20,6 +20,7 @@
> * page->freelist(index): links together all component pages of a zspage
> * For the huge page, this is always 0, so we use this field
> * to store handle.
> + * page->units: first object index in a subpage of zspage
Hmm, I want to use offset instead of index.
next prev parent reply other threads:[~2016-07-04 0:04 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-01 6:40 [PATCH 1/8] mm/zsmalloc: modify zs compact trace interface Ganesh Mahendran
2016-07-01 6:40 ` Ganesh Mahendran
2016-07-01 6:41 ` [PATCH 2/8] mm/zsmalloc: add per class compact trace event Ganesh Mahendran
2016-07-01 6:41 ` Ganesh Mahendran
2016-07-03 23:49 ` Minchan Kim
2016-07-03 23:49 ` Minchan Kim
2016-07-04 3:12 ` Ganesh Mahendran
2016-07-04 3:12 ` Ganesh Mahendran
2016-07-01 6:41 ` [PATCH 3/8] mm/zsmalloc: take obj index back from find_alloced_obj Ganesh Mahendran
2016-07-01 6:41 ` Ganesh Mahendran
2016-07-03 23:57 ` Minchan Kim
2016-07-03 23:57 ` Minchan Kim
2016-07-04 3:23 ` Ganesh Mahendran
2016-07-04 3:23 ` Ganesh Mahendran
2016-07-01 6:41 ` [PATCH 4/8] mm/zsmalloc: use class->objs_per_zspage to get num of max objects Ganesh Mahendran
2016-07-01 6:41 ` Ganesh Mahendran
2016-07-03 23:58 ` Minchan Kim
2016-07-03 23:58 ` Minchan Kim
2016-07-01 6:41 ` [PATCH 5/8] mm/zsmalloc: avoid calculate max objects of zspage twice Ganesh Mahendran
2016-07-01 6:41 ` Ganesh Mahendran
2016-07-04 0:03 ` Minchan Kim
2016-07-04 0:03 ` Minchan Kim
2016-07-04 3:26 ` Ganesh Mahendran
2016-07-04 3:26 ` Ganesh Mahendran
2016-07-01 6:41 ` [PATCH 6/8] mm/zsmalloc: keep comments consistent with code Ganesh Mahendran
2016-07-01 6:41 ` Ganesh Mahendran
2016-07-04 0:05 ` Minchan Kim [this message]
2016-07-04 0:05 ` Minchan Kim
2016-07-04 3:32 ` Ganesh Mahendran
2016-07-04 3:32 ` Ganesh Mahendran
2016-07-01 6:41 ` [PATCH 7/8] mm/zsmalloc: add __init,__exit attribute Ganesh Mahendran
2016-07-01 6:41 ` Ganesh Mahendran
2016-07-04 0:09 ` Minchan Kim
2016-07-04 0:09 ` Minchan Kim
2016-07-01 6:41 ` [PATCH 8/8] mm/zsmalloc: use helper to clear page->flags bit Ganesh Mahendran
2016-07-01 6:41 ` Ganesh Mahendran
2016-07-04 0:11 ` Minchan Kim
2016-07-04 0:11 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160704000516.GE19044@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=ngupta@vflare.org \
--cc=opensource.ganesh@gmail.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.