From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Rich Lane <rich.lane@bigswitch.com>
Cc: dev@dpdk.org, Tetsuya Mukawa <mukawa@igel.co.jp>
Subject: Re: [PATCH] vhost: reset queue state in destroy_device
Date: Mon, 4 Jul 2016 10:24:41 +0800 [thread overview]
Message-ID: <20160704022441.GS2831@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1467390672-80701-1-git-send-email-rich.lane@bigswitch.com>
On Fri, Jul 01, 2016 at 09:31:12AM -0700, Rich Lane wrote:
> Fixes a bug where rte_eth_vhost_get_queue_event would not return enabled queues
> after a guest application restart.
>
> Fixes: ee584e9710b9 ("vhost: add driver on top of the library")
> Signed-off-by: Rich Lane <rich.lane@bigswitch.com>
Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Just some minor comments about the title (nothing big deal; it's just
some DPDK preferences):
- a bug fix patch need be titled as "fix ..."
- it's better to hide specific function in the title. If you run
"scripts/check-git-log.sh", you will find a warning.
- the prefix should be "net/vhost".
So, I'd like to reword the title a bit, to something like:
"net/vhost: fix queue state not reset on destroy"
If have no objection, I could fix it while apply.
--yliu
next prev parent reply other threads:[~2016-07-04 2:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-01 16:31 [PATCH] vhost: reset queue state in destroy_device Rich Lane
2016-07-04 2:24 ` Yuanhan Liu [this message]
2016-07-11 2:06 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160704022441.GS2831@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=mukawa@igel.co.jp \
--cc=rich.lane@bigswitch.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.