From: Mel Gorman <mgorman@techsingularity.net>
To: Hillf Danton <hillf.zj@alibaba-inc.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>, linux-mm@kvack.org
Subject: Re: [PATCH 04/31] mm, vmscan: begin reclaiming pages on a per-node basis
Date: Mon, 4 Jul 2016 11:33:25 +0100 [thread overview]
Message-ID: <20160704103325.GD11498@techsingularity.net> (raw)
In-Reply-To: <00a301d1d5dc$02643ca0$072cb5e0$@alibaba-inc.com>
On Mon, Jul 04, 2016 at 06:08:27PM +0800, Hillf Danton wrote:
> > @@ -2561,17 +2580,23 @@ static void shrink_zones(struct zonelist *zonelist, struct scan_control *sc)
> > * highmem pages could be pinning lowmem pages storing buffer_heads
> > */
> > orig_mask = sc->gfp_mask;
> > - if (buffer_heads_over_limit)
> > + if (buffer_heads_over_limit) {
> > sc->gfp_mask |= __GFP_HIGHMEM;
> > + sc->reclaim_idx = classzone_idx = gfp_zone(sc->gfp_mask);
> > + }
> >
> We need to push/pop ->reclaim_idx as ->gfp_mask handled?
>
I saw no harm in having one full reclaim attempt reclaiming from all
zones if buffer_heads_over_limit was triggered. If it fails, the page
allocator will loop again and reset the reclaim_idx.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@techsingularity.net>
To: Hillf Danton <hillf.zj@alibaba-inc.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>, linux-mm@kvack.org
Subject: Re: [PATCH 04/31] mm, vmscan: begin reclaiming pages on a per-node basis
Date: Mon, 4 Jul 2016 11:33:25 +0100 [thread overview]
Message-ID: <20160704103325.GD11498@techsingularity.net> (raw)
In-Reply-To: <00a301d1d5dc$02643ca0$072cb5e0$@alibaba-inc.com>
On Mon, Jul 04, 2016 at 06:08:27PM +0800, Hillf Danton wrote:
> > @@ -2561,17 +2580,23 @@ static void shrink_zones(struct zonelist *zonelist, struct scan_control *sc)
> > * highmem pages could be pinning lowmem pages storing buffer_heads
> > */
> > orig_mask = sc->gfp_mask;
> > - if (buffer_heads_over_limit)
> > + if (buffer_heads_over_limit) {
> > sc->gfp_mask |= __GFP_HIGHMEM;
> > + sc->reclaim_idx = classzone_idx = gfp_zone(sc->gfp_mask);
> > + }
> >
> We need to push/pop ->reclaim_idx as ->gfp_mask handled?
>
I saw no harm in having one full reclaim attempt reclaiming from all
zones if buffer_heads_over_limit was triggered. If it fails, the page
allocator will loop again and reset the reclaim_idx.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2016-07-04 10:33 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <009e01d1d5d8$fcf06440$f6d12cc0$@alibaba-inc.com>
2016-07-04 10:08 ` [PATCH 04/31] mm, vmscan: begin reclaiming pages on a per-node basis Hillf Danton
2016-07-04 10:08 ` Hillf Danton
2016-07-04 10:33 ` Mel Gorman [this message]
2016-07-04 10:33 ` Mel Gorman
2016-07-05 3:17 ` Hillf Danton
2016-07-05 3:17 ` Hillf Danton
2016-07-01 20:01 [PATCH 00/31] Move LRU page reclaim from zones to nodes v8 Mel Gorman
2016-07-01 20:01 ` [PATCH 04/31] mm, vmscan: begin reclaiming pages on a per-node basis Mel Gorman
2016-07-01 20:01 ` Mel Gorman
2016-07-07 1:12 ` Joonsoo Kim
2016-07-07 1:12 ` Joonsoo Kim
2016-07-07 9:48 ` Mel Gorman
2016-07-07 9:48 ` Mel Gorman
2016-07-08 2:28 ` Joonsoo Kim
2016-07-08 2:28 ` Joonsoo Kim
2016-07-08 10:05 ` Mel Gorman
2016-07-08 10:05 ` Mel Gorman
2016-07-14 6:28 ` Joonsoo Kim
2016-07-14 6:28 ` Joonsoo Kim
2016-07-14 7:48 ` Vlastimil Babka
2016-07-14 7:48 ` Vlastimil Babka
2016-07-18 4:52 ` Joonsoo Kim
2016-07-18 4:52 ` Joonsoo Kim
2016-07-18 12:11 ` Mel Gorman
2016-07-18 12:11 ` Mel Gorman
2016-07-18 14:27 ` Mel Gorman
2016-07-18 14:27 ` Mel Gorman
2016-07-19 8:30 ` Joonsoo Kim
2016-07-19 8:30 ` Joonsoo Kim
2016-07-19 14:25 ` Mel Gorman
2016-07-19 14:25 ` Mel Gorman
-- strict thread matches above, loose matches on Subject: below --
2016-07-01 15:37 [PATCH 00/31] Move LRU page reclaim from zones to nodes v8 Mel Gorman
2016-07-01 15:37 ` [PATCH 04/31] mm, vmscan: begin reclaiming pages on a per-node basis Mel Gorman
2016-07-01 15:37 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160704103325.GD11498@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=hillf.zj@alibaba-inc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.