From: Josh Triplett <josh@joshtriplett.org>
To: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
valentinrothberg@gmail.com
Subject: Re: checkkconfigsymbols.py: add --no-color option
Date: Mon, 4 Jul 2016 05:24:17 -0700 [thread overview]
Message-ID: <20160704122415.GA7267@x> (raw)
In-Reply-To: <1467621570-970-1-git-send-email-andrew.donnellan@au1.ibm.com>
On Mon, Jul 04, 2016 at 06:39:30PM +1000, Andrew Donnellan wrote:
> Add a new option, --no-color, to get rid of ANSI colour escape codes in the
> output. Useful if redirecting output to a file or piping to another script.
>
> (It should really be --no-colour, but I'll accept US spelling in the name
> of consistency with existing usage in the code comments...)
>
> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> Acked-by: Valentin Rothberg <valentinrothberg@gmail.com>
Rather than requiring an explicit option, how about detecting
whether stdout is a TTY and automatically suppressing color?
You could check "os.isatty(1)" in main(), and set a global "color =
False". That would automatically handle the cases of redirecting to a
file or piping to another script, without requiring the user to pass
--no-color.
- Josh Triplett
next prev parent reply other threads:[~2016-07-04 12:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 8:39 [PATCH] checkkconfigsymbols.py: add --no-color option Andrew Donnellan
2016-07-04 10:44 ` Valentin Rothberg
2016-07-04 12:24 ` Josh Triplett [this message]
2016-07-05 7:22 ` Andrew Donnellan
2016-07-05 7:47 ` [PATCH v2] checkkconfigsymbols.py: add --no-color option, don't print color to non-TTY Andrew Donnellan
2016-07-05 8:45 ` Valentin Rothberg
2016-08-16 8:25 ` Valentin Rothberg
2016-08-16 10:49 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160704122415.GA7267@x \
--to=josh@joshtriplett.org \
--cc=andrew.donnellan@au1.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valentinrothberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.