From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Valentin Rothberg <valentinrothberg@gmail.com>
Cc: Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
josh@joshtriplett.org
Subject: Re: [PATCH v2] checkkconfigsymbols.py: add --no-color option, don't print color to non-TTY
Date: Tue, 16 Aug 2016 12:49:38 +0200 [thread overview]
Message-ID: <20160816104938.GB28337@kroah.com> (raw)
In-Reply-To: <CAD3Xx4L=Uig24x-bVYduSvgoe50Wr1_nxWV0feTwAheBm_wyqA@mail.gmail.com>
On Tue, Aug 16, 2016 at 10:25:48AM +0200, Valentin Rothberg wrote:
> Hi Greg,
>
> could you pick up this patch?
>
> On Tue, Jul 5, 2016 at 9:47 AM, Andrew Donnellan
> <andrew.donnellan@au1.ibm.com> wrote:
> > Only print the ANSI colour escape codes if stdout is a TTY. Useful if
> > redirecting output to a file or piping to another script.
> >
> > Also add a new option, --no-color, if the user wants to disable colour
> > output for whatever reason.
> >
> > Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
>
> Acked-by: Valentin Rothberg <valentinrothberg@gmail.com>
It's in my very long "to-review" queue, it's not lost, just seems like
it...
thanks,
greg k-h
prev parent reply other threads:[~2016-08-16 10:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 8:39 [PATCH] checkkconfigsymbols.py: add --no-color option Andrew Donnellan
2016-07-04 10:44 ` Valentin Rothberg
2016-07-04 12:24 ` Josh Triplett
2016-07-05 7:22 ` Andrew Donnellan
2016-07-05 7:47 ` [PATCH v2] checkkconfigsymbols.py: add --no-color option, don't print color to non-TTY Andrew Donnellan
2016-07-05 8:45 ` Valentin Rothberg
2016-08-16 8:25 ` Valentin Rothberg
2016-08-16 10:49 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160816104938.GB28337@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andrew.donnellan@au1.ibm.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valentinrothberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.