All of lore.kernel.org
 help / color / mirror / Atom feed
From: boris.brezillon@free-electrons.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: dts: at91: sama5d2: add ETM, ETB and ETMCK node
Date: Mon, 4 Jul 2016 22:51:37 +0200	[thread overview]
Message-ID: <20160704225137.0b7ace06@bbrezillon> (raw)
In-Reply-To: <20160704204742.GM20045@piout.net>

On Mon, 4 Jul 2016 22:47:42 +0200
Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:

> On 04/07/2016 at 22:26:48 +0200, Boris Brezillon wrote :
> > On Mon, 4 Jul 2016 18:02:03 +0200
> > Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
> >   
> > > On 04/07/2016 at 11:08:42 +0200, Olivier Schonken wrote :  
> > > > That is the dilemma I face with the structure.  What is the least
> > > > invasive option to include the coresight functionality, without
> > > > breaking the amba probe for other architectures that rely on it having
> > > > a clock to enable/disable, and not break the processor startup by
> > > > messing with stable clocks for the sake of giving the ETB/ETM a clock
> > > > it doesn't need.
> > > > That is why in the end I decided on a dummy clock driver.  To keep
> > > > with the convention of having a clock specific to the ETM, and leaving
> > > > the rest of the clocks as is.
> > > >     
> > > 
> > > Well, the issue is in the pit driver, see the patch I just sent. With
> > > both of your patches, I got my sama5d2 xplained botting fine.
> > >   
> > 
> > You mean, replacing the reference to the dummy clk by a reference to
> > mck, right?  
> 
> Absolutely!
> 

Okay. Olivier, can you send a new version of this patch and use mck
instead of this dummy etm clk?

Thanks,

Boris

  reply	other threads:[~2016-07-04 20:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-01 14:37 [PATCH 1/2] coresight-etm3x: Add ARM ETM-A5 peripheral ID Olivier Schonken
2016-07-01 14:37 ` [PATCH 2/2] ARM: dts: at91: sama5d2: add ETM, ETB and ETMCK node Olivier Schonken
2016-07-01 18:32   ` Alexandre Belloni
2016-07-01 20:07     ` Olivier Schonken
2016-07-02 18:46       ` Boris Brezillon
2016-07-04  8:49         ` Olivier Schonken
     [not found]         ` <CALdGsk+RO_cxfcTLVyKHP3aVMkSTtzEzQXz2G4ARX7vqxRazSA@mail.gmail.com>
2016-07-04  9:00           ` Boris Brezillon
2016-07-04  9:08             ` Olivier Schonken
2016-07-04 16:02               ` Alexandre Belloni
2016-07-04 20:26                 ` Boris Brezillon
2016-07-04 20:47                   ` Alexandre Belloni
2016-07-04 20:51                     ` Boris Brezillon [this message]
2016-07-04 15:38   ` Mathieu Poirier
2016-07-04 15:33 ` [PATCH 1/2] coresight-etm3x: Add ARM ETM-A5 peripheral ID Mathieu Poirier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160704225137.0b7ace06@bbrezillon \
    --to=boris.brezillon@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.