From: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Dave Young <dyoung@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Baoquan He <bhe@redhat.com>
Cc: x86@kernel.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org,
HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Daniel Walker <dwalker@fifo99.com>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@suse.de>, Ingo Molnar <mingo@kernel.org>,
Vivek Goyal <vgoyal@redhat.com>
Subject: [V3 PATCH 0/2] kexec: crash_kexec_post_notifiers boot option related fixes
Date: Tue, 05 Jul 2016 20:33:23 +0900 [thread overview]
Message-ID: <20160705113323.5864.66834.stgit@softrs> (raw)
This is the update version of the patch which I posted one year ago
(https://lkml.org/lkml/2015/7/23/864). Because I couldn't received
positive opinions against the previous version, I had changed the
approach to another one which utilizes kexec purgatory. Then I'm
back here.
PATCH 1/2 is a bugfix for crash_kexec_post_notifiers boot option
which allows users to call panic notifiers and kmsg dumpers before
kdump. When this option is enabled, smp_send_stop() is used to stop
other CPUs instead of a function provided by kdump. smp_send_stop()
just stops other CPUs and doesn't other things needed for kdump.
So, fix it by replacing smp_send_stop() with new appropriate one,
panic_smp_send_stop(). Since panic_smp_send_stop() is architecture
specific and I can't simply copy from kdump routines, only
x86-specific version is provided.
PATCH 2/2 makes crash_kexec_post_notifiers boot option modifiable
after boot. We don't need to limit it to being modifiable at boot
time.
Changes in V3:
- Revise comments, description, and symbol names (the logic doesn't
change)
- Make crash_kexec_post_notifiers boot option modifiable after boot
Changes in V2: https://lkml.org/lkml/2015/7/23/864
- Replace smp_send_stop() call with crash_kexec version which
saves cpu states and does cleanups instead of changing execution
flow
- Drop a fix for Problem 1
- Drop other patches because they aren't needed anymore
V1: https://lkml.org/lkml/2015/7/10/316
---
Hidehiro Kawai (2):
x86/panic: Replace smp_send_stop() with kdump friendly version
kexec: Use core_param for crash_kexec_post_notifiers boot option
arch/x86/kernel/crash.c | 14 ++++++++----
kernel/panic.c | 56 ++++++++++++++++++++++++++++++-----------------
2 files changed, 46 insertions(+), 24 deletions(-)
--
Hidehiro Kawai
Hitachi, Ltd. Research & Development Group
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Dave Young <dyoung@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Baoquan He <bhe@redhat.com>
Cc: x86@kernel.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org,
HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Daniel Walker <dwalker@fifo99.com>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@suse.de>, Ingo Molnar <mingo@kernel.org>,
Vivek Goyal <vgoyal@redhat.com>
Subject: [V3 PATCH 0/2] kexec: crash_kexec_post_notifiers boot option related fixes
Date: Tue, 05 Jul 2016 20:33:23 +0900 [thread overview]
Message-ID: <20160705113323.5864.66834.stgit@softrs> (raw)
This is the update version of the patch which I posted one year ago
(https://lkml.org/lkml/2015/7/23/864). Because I couldn't received
positive opinions against the previous version, I had changed the
approach to another one which utilizes kexec purgatory. Then I'm
back here.
PATCH 1/2 is a bugfix for crash_kexec_post_notifiers boot option
which allows users to call panic notifiers and kmsg dumpers before
kdump. When this option is enabled, smp_send_stop() is used to stop
other CPUs instead of a function provided by kdump. smp_send_stop()
just stops other CPUs and doesn't other things needed for kdump.
So, fix it by replacing smp_send_stop() with new appropriate one,
panic_smp_send_stop(). Since panic_smp_send_stop() is architecture
specific and I can't simply copy from kdump routines, only
x86-specific version is provided.
PATCH 2/2 makes crash_kexec_post_notifiers boot option modifiable
after boot. We don't need to limit it to being modifiable at boot
time.
Changes in V3:
- Revise comments, description, and symbol names (the logic doesn't
change)
- Make crash_kexec_post_notifiers boot option modifiable after boot
Changes in V2: https://lkml.org/lkml/2015/7/23/864
- Replace smp_send_stop() call with crash_kexec version which
saves cpu states and does cleanups instead of changing execution
flow
- Drop a fix for Problem 1
- Drop other patches because they aren't needed anymore
V1: https://lkml.org/lkml/2015/7/10/316
---
Hidehiro Kawai (2):
x86/panic: Replace smp_send_stop() with kdump friendly version
kexec: Use core_param for crash_kexec_post_notifiers boot option
arch/x86/kernel/crash.c | 14 ++++++++----
kernel/panic.c | 56 ++++++++++++++++++++++++++++++-----------------
2 files changed, 46 insertions(+), 24 deletions(-)
--
Hidehiro Kawai
Hitachi, Ltd. Research & Development Group
next reply other threads:[~2016-07-05 11:37 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 11:33 Hidehiro Kawai [this message]
2016-07-05 11:33 ` [V3 PATCH 0/2] kexec: crash_kexec_post_notifiers boot option related fixes Hidehiro Kawai
2016-07-05 11:33 ` [V3 PATCH 1/2] x86/panic: Replace smp_send_stop() with kdump friendly version Hidehiro Kawai
2016-07-05 11:33 ` Hidehiro Kawai
2016-07-11 8:34 ` Dave Young
2016-07-11 8:34 ` Dave Young
2016-07-12 2:49 ` 河合英宏 / KAWAI,HIDEHIRO
2016-07-12 2:49 ` 河合英宏 / KAWAI,HIDEHIRO
2016-07-13 2:03 ` 'Dave Young'
2016-07-15 11:50 ` 河合英宏 / KAWAI,HIDEHIRO
2016-07-15 11:50 ` 河合英宏 / KAWAI,HIDEHIRO
2016-07-18 9:02 ` 'Dave Young'
2016-07-18 9:02 ` 'Dave Young'
2016-07-19 5:51 ` 河合英宏 / KAWAI,HIDEHIRO
2016-07-19 5:51 ` 河合英宏 / KAWAI,HIDEHIRO
2016-07-19 6:52 ` 'Dave Young'
2016-07-19 6:52 ` 'Dave Young'
2016-07-19 11:23 ` 河合英宏 / KAWAI,HIDEHIRO
2016-07-19 11:23 ` 河合英宏 / KAWAI,HIDEHIRO
2016-07-12 3:11 ` Xunlei Pang
2016-07-12 3:11 ` Xunlei Pang
2016-07-12 3:56 ` 河合英宏 / KAWAI,HIDEHIRO
2016-07-12 3:56 ` 河合英宏 / KAWAI,HIDEHIRO
2016-07-12 6:57 ` Xunlei Pang
2016-07-12 6:57 ` Xunlei Pang
2016-07-12 7:12 ` 河合英宏 / KAWAI,HIDEHIRO
2016-07-12 7:12 ` 河合英宏 / KAWAI,HIDEHIRO
2016-07-12 7:26 ` Xunlei Pang
2016-07-12 7:26 ` Xunlei Pang
2016-07-05 11:33 ` [V3 PATCH 2/2] kexec: Use core_param for crash_kexec_post_notifiers boot option Hidehiro Kawai
2016-07-05 11:33 ` Hidehiro Kawai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160705113323.5864.66834.stgit@softrs \
--to=hidehiro.kawai.ez@hitachi.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=bp@suse.de \
--cc=d.hatayama@jp.fujitsu.com \
--cc=dwalker@fifo99.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.