From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Hillf Danton <hillf.zj@alibaba-inc.com>
Cc: 'linux-kernel' <linux-kernel@vger.kernel.org>, linux-mm@kvack.org
Subject: Re: [PATCH 2/2] s390/mm: use ipte range to invalidate multiple page table entries
Date: Wed, 6 Jul 2016 12:51:12 +0200 [thread overview]
Message-ID: <20160706125112.6cdf8262@mschwide> (raw)
In-Reply-To: <015d01d1d768$6db5d9e0$49218da0$@alibaba-inc.com>
On Wed, 06 Jul 2016 17:26:08 +0800
"Hillf Danton" <hillf.zj@alibaba-inc.com> wrote:
> >
> > You are still a bit cryptic,
> >
> Sorry, Sir, simply because I'm not native English speaker.
>
> > are you trying to tell me that your hint is
> > about trying to avoid the preempt_enable() call?
> >
> Yes, since we are already in the context with page table lock held.
Ok, got it. An option would be to drop the preempt_disable/preempt_enable,
add "BUG_ON(preemptible())" and use raw_smp_processor_id. But I wonder if
it is worth the effort.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: "Hillf Danton" <hillf.zj@alibaba-inc.com>
Cc: "'linux-kernel'" <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>
Subject: Re: [PATCH 2/2] s390/mm: use ipte range to invalidate multiple page table entries
Date: Wed, 6 Jul 2016 12:51:12 +0200 [thread overview]
Message-ID: <20160706125112.6cdf8262@mschwide> (raw)
In-Reply-To: <015d01d1d768$6db5d9e0$49218da0$@alibaba-inc.com>
On Wed, 06 Jul 2016 17:26:08 +0800
"Hillf Danton" <hillf.zj@alibaba-inc.com> wrote:
> >
> > You are still a bit cryptic,
> >
> Sorry, Sir, simply because I'm not native English speaker.
>
> > are you trying to tell me that your hint is
> > about trying to avoid the preempt_enable() call?
> >
> Yes, since we are already in the context with page table lock held.
Ok, got it. An option would be to drop the preempt_disable/preempt_enable,
add "BUG_ON(preemptible())" and use raw_smp_processor_id. But I wonder if
it is worth the effort.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
next prev parent reply other threads:[~2016-07-06 10:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <014201d1d738$744c8f90$5ce5aeb0$@alibaba-inc.com>
2016-07-06 4:03 ` [PATCH 2/2] s390/mm: use ipte range to invalidate multiple page table entries Hillf Danton
2016-07-06 4:03 ` Hillf Danton
2016-07-06 6:23 ` Martin Schwidefsky
2016-07-06 6:23 ` Martin Schwidefsky
2016-07-06 6:42 ` Hillf Danton
2016-07-06 6:42 ` Hillf Danton
2016-07-06 8:47 ` Martin Schwidefsky
2016-07-06 8:47 ` Martin Schwidefsky
2016-07-06 9:26 ` Hillf Danton
2016-07-06 9:26 ` Hillf Danton
2016-07-06 10:51 ` Martin Schwidefsky [this message]
2016-07-06 10:51 ` Martin Schwidefsky
2016-07-05 12:00 [PATCH 0/2][RFC] mm callback for batched pte updates Martin Schwidefsky
2016-07-05 12:00 ` [PATCH 2/2] s390/mm: use ipte range to invalidate multiple page table entries Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160706125112.6cdf8262@mschwide \
--to=schwidefsky@de.ibm.com \
--cc=hillf.zj@alibaba-inc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.