All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Franck Bui" <fbui@suse.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Ingo Molnar" <mingo@kernel.org>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH -v3.1 2/2] printk: Add kernel parameter to control writes to /dev/kmsg
Date: Wed, 6 Jul 2016 20:32:45 +0200	[thread overview]
Message-ID: <20160706183245.GJ7300@pd.tnic> (raw)
In-Reply-To: <20160706135211.3e4f968e@gandalf.local.home>

On Wed, Jul 06, 2016 at 01:52:11PM -0400, Steven Rostedt wrote:
> Hmm, this does nothing to stop user space from doing the following:
> 
> while :; do echo '5,0,0,-;hello' > /dev/kmsg; done

I wouldn't worry too much if /dev/kmsg has root:root perms elsewhere
too, like it is the case in my guest here:

crw-r--r-- 1 root root 1, 11 Jul  6 22:28 /dev/kmsg

root can shoot herself in the foot in countless ways anyway.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

      reply	other threads:[~2016-07-06 18:33 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-04 14:24 [PATCH -v3 0/2] printk.devkmsg: Ratelimit it by default Borislav Petkov
2016-07-04 14:24 ` [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages on release Borislav Petkov
2016-07-05 18:26   ` Steven Rostedt
2016-07-05 18:45     ` Borislav Petkov
2016-07-05 18:57       ` Steven Rostedt
2016-07-05 19:42         ` Borislav Petkov
2016-07-05 19:49           ` Steven Rostedt
2016-07-05 20:08             ` Joe Perches
2016-07-05 20:53               ` Christian Borntraeger
2016-07-05 21:14                 ` Paolo Bonzini
2016-07-05 21:23                   ` Christian Borntraeger
2016-07-05 21:31                 ` Borislav Petkov
2016-07-06 13:28   ` [PATCH -v3.1 " Borislav Petkov
2016-07-06 13:40     ` Steven Rostedt
2016-07-06 14:59       ` [PATCH -v3.2 " Borislav Petkov
2016-07-07  1:17         ` Steven Rostedt
2016-07-07  5:36           ` Borislav Petkov
2016-07-06 14:50     ` [PATCH -v3.1 " Joe Perches
2016-07-04 14:24 ` [PATCH -v3 2/2] printk: Add kernel parameter to control writes to /dev/kmsg Borislav Petkov
2016-07-05 21:47   ` Steven Rostedt
2016-07-05 22:02     ` Borislav Petkov
2016-07-05 22:08       ` Steven Rostedt
2016-07-06 13:29   ` [PATCH -v3.1 " Borislav Petkov
2016-07-06 17:52     ` Steven Rostedt
2016-07-06 18:32       ` Borislav Petkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160706183245.GJ7300@pd.tnic \
    --to=bp@alien8.de \
    --cc=akpm@linux-foundation.org \
    --cc=fbui@suse.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=torvalds@linux-foundation.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.