From: Christian Borntraeger <borntraeger@de.ibm.com>
To: "Paolo Bonzini" <pbonzini@redhat.com>,
"Joe Perches" <joe@perches.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Borislav Petkov" <bp@alien8.de>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Cornelia Huck" <cornelia.huck@de.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Franck Bui" <fbui@suse.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Ingo Molnar" <mingo@kernel.org>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Janosch Frank" <frankja@linux.vnet.ibm.com>
Subject: Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages on release
Date: Tue, 5 Jul 2016 23:23:14 +0200 [thread overview]
Message-ID: <577C2542.9010008@de.ibm.com> (raw)
In-Reply-To: <46183d11-5800-bb69-2da8-58fadc699cb8@redhat.com>
On 07/05/2016 11:14 PM, Paolo Bonzini wrote:
>
>
> On 05/07/2016 22:53, Christian Borntraeger wrote:
>> Yes, this is new in next. As far as I can see, the new message would only
>> appear if we would call ratelimit_state_exit. Correct? We do not call this -
>> I assume this is ok?
>>
>> We really only want to reuse the rate limit base code (to avoid writing the same
>> code twice) and being in lib indicated that this can indeed be used outside
>> printk.
>> Now: your patch 1 would allow me to get rid of the messages completely
>> by setting the flag and by not calling ratelimit_state_exit. Which is probably
>> what we should do in our code.
>
> Can we delay fixing this after the code is merged in Linus's tree?
Absolutely. We already have 2 smaller conflicts in next and I certainly do not want to add
another one.
The current ratelimit print does not hurt - it is just not necessary for us.
so my statement was just a "statement of direction" to write some IBM speak ;-)
next prev parent reply other threads:[~2016-07-05 21:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 14:24 [PATCH -v3 0/2] printk.devkmsg: Ratelimit it by default Borislav Petkov
2016-07-04 14:24 ` [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages on release Borislav Petkov
2016-07-05 18:26 ` Steven Rostedt
2016-07-05 18:45 ` Borislav Petkov
2016-07-05 18:57 ` Steven Rostedt
2016-07-05 19:42 ` Borislav Petkov
2016-07-05 19:49 ` Steven Rostedt
2016-07-05 20:08 ` Joe Perches
2016-07-05 20:53 ` Christian Borntraeger
2016-07-05 21:14 ` Paolo Bonzini
2016-07-05 21:23 ` Christian Borntraeger [this message]
2016-07-05 21:31 ` Borislav Petkov
2016-07-06 13:28 ` [PATCH -v3.1 " Borislav Petkov
2016-07-06 13:40 ` Steven Rostedt
2016-07-06 14:59 ` [PATCH -v3.2 " Borislav Petkov
2016-07-07 1:17 ` Steven Rostedt
2016-07-07 5:36 ` Borislav Petkov
2016-07-06 14:50 ` [PATCH -v3.1 " Joe Perches
2016-07-04 14:24 ` [PATCH -v3 2/2] printk: Add kernel parameter to control writes to /dev/kmsg Borislav Petkov
2016-07-05 21:47 ` Steven Rostedt
2016-07-05 22:02 ` Borislav Petkov
2016-07-05 22:08 ` Steven Rostedt
2016-07-06 13:29 ` [PATCH -v3.1 " Borislav Petkov
2016-07-06 17:52 ` Steven Rostedt
2016-07-06 18:32 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577C2542.9010008@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=cornelia.huck@de.ibm.com \
--cc=fbui@suse.com \
--cc=frankja@linux.vnet.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rkrcmar@redhat.com \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.