From: Fam Zheng <famz@redhat.com>
To: Cao jin <caoj.fnst@cn.fujitsu.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] main-loop: check return value before using
Date: Thu, 7 Jul 2016 13:00:28 +0800 [thread overview]
Message-ID: <20160707050028.GA12042@ad.usersys.redhat.com> (raw)
In-Reply-To: <577DCA1C.2020809@cn.fujitsu.com>
On Thu, 07/07 11:18, Cao jin wrote:
>
>
> On 07/07/2016 08:31 AM, Fam Zheng wrote:
> > On Wed, 07/06 15:46, Cao jin wrote:
> > >
> >
> > Yes, but in this patch I think the blank line changes are 1) more of personal
> > taste, 2) completely unrelated (neither lines nor semantics) to the functional
> > change.
> >
> > Fam
>
> Indeed, my personal taste. Generally speaking, well separated code block is
> easier for newbies to read. This is what I has been trained before, and I
> like it, so I just can't help to add these lines when the code in my hand:P
> BTW, I am curious about maintainer`s opinion about this thing:)
It of course doesn't hurt git blame, as far as I can tell. Please Cc
qemu-trivial in the separate patch.
Fam
prev parent reply other threads:[~2016-07-07 5:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 3:03 [Qemu-devel] [PATCH] main-loop: check return value before using Cao jin
2016-07-06 5:28 ` Cao jin
2016-07-06 6:46 ` Fam Zheng
2016-07-06 7:46 ` Cao jin
2016-07-07 0:31 ` Fam Zheng
2016-07-07 3:18 ` Cao jin
2016-07-07 5:00 ` Fam Zheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160707050028.GA12042@ad.usersys.redhat.com \
--to=famz@redhat.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.