All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH] main-loop: check return value before using
Date: Wed, 6 Jul 2016 15:46:14 +0800	[thread overview]
Message-ID: <577CB746.10300@cn.fujitsu.com> (raw)
In-Reply-To: <20160706064650.GB16605@ad.usersys.redhat.com>


On 07/06/2016 02:46 PM, Fam Zheng wrote:
> On Wed, 07/06 11:03, Cao jin wrote:
>> pointer 'qemu_aio_context' should be checked first before it is used.
>> qemu_bh_new() will use it.
>>
>> Also add extra newlines to make code well separated and easier to read.
>
> This "also" is not good, please only do one thing in a patch.
>
> Fam
>

Thanks Fam.

See what I was told before when come to here:
http://lists.nongnu.org/archive/html/qemu-trivial/2015-10/msg00116.html
http://lists.nongnu.org/archive/html/qemu-trivial/2015-10/msg00123.html

So since then, I always prefer to squeeze stylistics patch into a 
productive one.

Ok, I will split it.

Yours Sincerely,

Cao jin

  reply	other threads:[~2016-07-06  9:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-06  3:03 [Qemu-devel] [PATCH] main-loop: check return value before using Cao jin
2016-07-06  5:28 ` Cao jin
2016-07-06  6:46 ` Fam Zheng
2016-07-06  7:46   ` Cao jin [this message]
2016-07-07  0:31     ` Fam Zheng
2016-07-07  3:18       ` Cao jin
2016-07-07  5:00         ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=577CB746.10300@cn.fujitsu.com \
    --to=caoj.fnst@cn.fujitsu.com \
    --cc=famz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.