From: Dave Chinner <david@fromorbit.com>
To: Benjamin Coddington <bcodding@redhat.com>
Cc: xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org,
linux-nfs@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@lst.de>,
bfields@fieldses.org
Subject: Re: [PATCH 2/2] xfs: abstract block export operations from nfsd layouts
Date: Fri, 8 Jul 2016 08:38:09 +1000 [thread overview]
Message-ID: <20160707223809.GH12670@dastard> (raw)
In-Reply-To: <073be10a55e5e952adbfd320abcce075fb3958ae.1467889001.git.bcodding@redhat.com>
On Thu, Jul 07, 2016 at 07:02:32AM -0400, Benjamin Coddington wrote:
> Instead of creeping pnfs layout configuration into filesystems, move the
> definition of block-based export operations under a more abstract
> configuration.
>
> Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
> ---
> fs/Kconfig | 3 +++
> fs/nfsd/Kconfig | 2 ++
> fs/xfs/Makefile | 3 +--
> fs/xfs/xfs_export.c | 2 +-
> fs/xfs/xfs_pnfs.h | 4 ++--
> 5 files changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/fs/Kconfig b/fs/Kconfig
> index 6725f59c18e6..6e57b4237d72 100644
> --- a/fs/Kconfig
> +++ b/fs/Kconfig
> @@ -66,6 +66,9 @@ config FS_POSIX_ACL
> config EXPORTFS
> tristate
>
> +config BLOCK_EXPORT_OPS
> + bool
> +
default n, help text?
Also, BLOCK_* prefix config options are for block layer
functionality, hence I suspect this will confuse people because it's
a filesystem config option. EXPORTFS_BLOCK_OPS seems more obvious
and correct to me, as the block mapping ops are part of the exportfs
operations interface....
> xfs-$(CONFIG_SYSCTL) += xfs_sysctl.o
> xfs-$(CONFIG_COMPAT) += xfs_ioctl32.o
> -xfs-$(CONFIG_NFSD_BLOCKLAYOUT) += xfs_pnfs.o
> -xfs-$(CONFIG_NFSD_SCSILAYOUT) += xfs_pnfs.o
> +xfs-$(CONFIG_BLOCK_EXPORT_OPS) += xfs_pnfs.o
Why do we need the first patch to XFS anymore? Just convert it
straight to using CONFIG_EXPORTFS_BLOCK_OPS....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Benjamin Coddington <bcodding@redhat.com>
Cc: linux-nfs@vger.kernel.org, xfs@oss.sgi.com, bfields@fieldses.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 2/2] xfs: abstract block export operations from nfsd layouts
Date: Fri, 8 Jul 2016 08:38:09 +1000 [thread overview]
Message-ID: <20160707223809.GH12670@dastard> (raw)
In-Reply-To: <073be10a55e5e952adbfd320abcce075fb3958ae.1467889001.git.bcodding@redhat.com>
On Thu, Jul 07, 2016 at 07:02:32AM -0400, Benjamin Coddington wrote:
> Instead of creeping pnfs layout configuration into filesystems, move the
> definition of block-based export operations under a more abstract
> configuration.
>
> Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
> ---
> fs/Kconfig | 3 +++
> fs/nfsd/Kconfig | 2 ++
> fs/xfs/Makefile | 3 +--
> fs/xfs/xfs_export.c | 2 +-
> fs/xfs/xfs_pnfs.h | 4 ++--
> 5 files changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/fs/Kconfig b/fs/Kconfig
> index 6725f59c18e6..6e57b4237d72 100644
> --- a/fs/Kconfig
> +++ b/fs/Kconfig
> @@ -66,6 +66,9 @@ config FS_POSIX_ACL
> config EXPORTFS
> tristate
>
> +config BLOCK_EXPORT_OPS
> + bool
> +
default n, help text?
Also, BLOCK_* prefix config options are for block layer
functionality, hence I suspect this will confuse people because it's
a filesystem config option. EXPORTFS_BLOCK_OPS seems more obvious
and correct to me, as the block mapping ops are part of the exportfs
operations interface....
> xfs-$(CONFIG_SYSCTL) += xfs_sysctl.o
> xfs-$(CONFIG_COMPAT) += xfs_ioctl32.o
> -xfs-$(CONFIG_NFSD_BLOCKLAYOUT) += xfs_pnfs.o
> -xfs-$(CONFIG_NFSD_SCSILAYOUT) += xfs_pnfs.o
> +xfs-$(CONFIG_BLOCK_EXPORT_OPS) += xfs_pnfs.o
Why do we need the first patch to XFS anymore? Just convert it
straight to using CONFIG_EXPORTFS_BLOCK_OPS....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-07-07 22:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 11:02 [PATCH 1/2] nfsd: allow SCSI layout support without block layout Benjamin Coddington
2016-07-07 11:02 ` Benjamin Coddington
2016-07-07 11:02 ` [PATCH 2/2] xfs: abstract block export operations from nfsd layouts Benjamin Coddington
2016-07-07 11:02 ` Benjamin Coddington
2016-07-07 15:43 ` J. Bruce Fields
2016-07-07 15:43 ` J. Bruce Fields
2016-07-07 22:38 ` Dave Chinner [this message]
2016-07-07 22:38 ` Dave Chinner
2016-07-08 13:24 ` [PATCH 2/2] " Benjamin Coddington
2016-07-08 13:24 ` Benjamin Coddington
2016-07-08 23:30 ` Dave Chinner
2016-07-08 23:30 ` Dave Chinner
2016-07-08 23:30 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160707223809.GH12670@dastard \
--to=david@fromorbit.com \
--cc=bcodding@redhat.com \
--cc=bfields@fieldses.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.