All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: fenghua.yu@intel.com, x86@kernel.org, kexec@lists.infradead.org,
	linux-kernel@vger.kernel.org, mingo@redhat.com, hpa@zytor.com,
	tglx@linutronix.de, Wei Jiangang <weijg.fnst@cn.fujitsu.com>
Subject: Re: [PATCH v2] kexec: Fix kdump failure with notsc
Date: Fri, 8 Jul 2016 09:38:28 +0200	[thread overview]
Message-ID: <20160708073828.GA3216@gmail.com> (raw)
In-Reply-To: <87r3b5z626.fsf@x220.int.ebiederm.org>


* Eric W. Biederman <ebiederm@xmission.com> wrote:

> Sigh.  Can we please just do the work to rip out the apic shutdown code from the 
> kexec on panic code path?
> 
> I forgetting details but the only reason we have do any apic shutdown is bugs in 
> older kernels that could not initialize a system properly if we did not shut 
> down the apics.
> 
> I certainly don't see an issue with goofy cases like notsc not working on a 
> crash capture kernel if we are not initializing the hardware properly.
> 
> The strategy really needs to be to only do the absolutely essential hardware 
> shutdown in the crashing kernel, every adintional line of code we execute in the 
> crashing kernel increases our chances of hitting a bug.

Fully agreed.

> Under that policy things like requring we don't pass boot options that inhibit 
> the dump catpure kernel from initializing the hardware from a random state are 
> reasonable requirements.  AKA I don't see any justification in this as to why we 
> would even want to support notsc on the dump capture kernel.  Especially when 
> things clearly work when that option is not specified.

So at least on the surface it appears 'surprising' that the 'notsc' option (which, 
supposedly, disables TSC handling) interferes with being able to fully boot. Even 
if 'notsc' is specified we are still using the local APIC, right?

So it might be a good idea to find the root cause of this bootup fragility even if 
'notsc' is specified. And I fully agree that it should be fixed in the bootup path 
of the dump kernel, not the crash kernel reboot path.

Thanks,

	Ingo

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Wei Jiangang <weijg.fnst@cn.fujitsu.com>,
	linux-kernel@vger.kernel.org, x86@kernel.org,
	kexec@lists.infradead.org, tglx@linutronix.de, mingo@redhat.com,
	hpa@zytor.com, fenghua.yu@intel.com
Subject: Re: [PATCH v2] kexec: Fix kdump failure with notsc
Date: Fri, 8 Jul 2016 09:38:28 +0200	[thread overview]
Message-ID: <20160708073828.GA3216@gmail.com> (raw)
In-Reply-To: <87r3b5z626.fsf@x220.int.ebiederm.org>


* Eric W. Biederman <ebiederm@xmission.com> wrote:

> Sigh.  Can we please just do the work to rip out the apic shutdown code from the 
> kexec on panic code path?
> 
> I forgetting details but the only reason we have do any apic shutdown is bugs in 
> older kernels that could not initialize a system properly if we did not shut 
> down the apics.
> 
> I certainly don't see an issue with goofy cases like notsc not working on a 
> crash capture kernel if we are not initializing the hardware properly.
> 
> The strategy really needs to be to only do the absolutely essential hardware 
> shutdown in the crashing kernel, every adintional line of code we execute in the 
> crashing kernel increases our chances of hitting a bug.

Fully agreed.

> Under that policy things like requring we don't pass boot options that inhibit 
> the dump catpure kernel from initializing the hardware from a random state are 
> reasonable requirements.  AKA I don't see any justification in this as to why we 
> would even want to support notsc on the dump capture kernel.  Especially when 
> things clearly work when that option is not specified.

So at least on the surface it appears 'surprising' that the 'notsc' option (which, 
supposedly, disables TSC handling) interferes with being able to fully boot. Even 
if 'notsc' is specified we are still using the local APIC, right?

So it might be a good idea to find the root cause of this bootup fragility even if 
'notsc' is specified. And I fully agree that it should be fixed in the bootup path 
of the dump kernel, not the crash kernel reboot path.

Thanks,

	Ingo

  parent reply	other threads:[~2016-07-08  7:38 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-07 10:17 [PATCH v2] kexec: Fix kdump failure with notsc Wei Jiangang
2016-07-07 10:17 ` Wei Jiangang
2016-07-07 17:55 ` Eric W. Biederman
2016-07-07 17:55   ` Eric W. Biederman
2016-07-08  4:48   ` Wei, Jiangang
2016-07-08  4:48     ` Wei, Jiangang
2016-07-08  7:38   ` Ingo Molnar [this message]
2016-07-08  7:38     ` Ingo Molnar
2016-07-11 10:30     ` Wei, Jiangang
2016-07-11 10:30       ` Wei, Jiangang
2016-07-13  7:46       ` Wei, Jiangang
2016-07-13  7:46         ` Wei, Jiangang
2016-07-13  9:05         ` Baoquan He
2016-07-13  9:05           ` Baoquan He
2016-07-08  8:21 ` Nikolay Borisov
2016-07-08  8:21   ` Nikolay Borisov
2016-07-12  6:52 ` Xunlei Pang
2016-07-12  6:52   ` Xunlei Pang
2016-07-12  8:21   ` Baoquan He
2016-07-12  8:21     ` Baoquan He
2016-07-12  9:10     ` Wei, Jiangang
2016-07-12  9:10       ` Wei, Jiangang
2016-07-12  9:09   ` Wei, Jiangang
2016-07-12  9:09     ` Wei, Jiangang
2016-07-12  9:29     ` Baoquan He
2016-07-12  9:29       ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160708073828.GA3216@gmail.com \
    --to=mingo@kernel.org \
    --cc=ebiederm@xmission.com \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@zytor.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=weijg.fnst@cn.fujitsu.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.