From: Peter Chen <hzpeterchen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Stephen Boyd <stephen.boyd-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Felipe Balbi <balbi-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Neil Armstrong
<narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Bjorn Andersson
<bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Peter Chen <peter.chen-3arQi8VN3Tc@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Andy Gross <andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v2 08/22] usb: chipidea: Remove locking in ci_udc_start()
Date: Fri, 8 Jul 2016 17:45:28 +0800 [thread overview]
Message-ID: <20160708094528.GF20485@shlinux2> (raw)
In-Reply-To: <20160707222114.1673-9-stephen.boyd-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
On Thu, Jul 07, 2016 at 03:20:59PM -0700, Stephen Boyd wrote:
> We don't call hw_device_reset() with the ci->lock held, so it
> doesn't seem like this lock here is protecting anything. Let's
> just remove it. This allows us to call sleeping functions like
> phy_init() from within the CI_HDRC_CONTROLLER_RESET_EVENT hook.
>
> Cc: Peter Chen <peter.chen-3arQi8VN3Tc@public.gmane.org>
> Cc: Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
> Signed-off-by: Stephen Boyd <stephen.boyd-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
> drivers/usb/chipidea/udc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
> index 065f5d97aa67..f16be4710cdb 100644
> --- a/drivers/usb/chipidea/udc.c
> +++ b/drivers/usb/chipidea/udc.c
> @@ -1719,7 +1719,6 @@ static int ci_udc_start(struct usb_gadget *gadget,
> struct usb_gadget_driver *driver)
> {
> struct ci_hdrc *ci = container_of(gadget, struct ci_hdrc, gadget);
> - unsigned long flags;
> int retval = -ENOMEM;
>
> if (driver->disconnect == NULL)
> @@ -1746,7 +1745,6 @@ static int ci_udc_start(struct usb_gadget *gadget,
>
> pm_runtime_get_sync(&ci->gadget.dev);
> if (ci->vbus_active) {
> - spin_lock_irqsave(&ci->lock, flags);
> hw_device_reset(ci);
> } else {
> usb_udc_vbus_handler(&ci->gadget, false);
> @@ -1755,7 +1753,6 @@ static int ci_udc_start(struct usb_gadget *gadget,
> }
>
> retval = hw_device_state(ci, ci->ep0out->qh.dma);
> - spin_unlock_irqrestore(&ci->lock, flags);
> if (retval)
> pm_runtime_put_sync(&ci->gadget.dev);
>
The main purpose for this is disabling interrupt when reset controller,
in case the unexpected interrupts occur.
You can move this between hw_device_state.
--
Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: hzpeterchen@gmail.com (Peter Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 08/22] usb: chipidea: Remove locking in ci_udc_start()
Date: Fri, 8 Jul 2016 17:45:28 +0800 [thread overview]
Message-ID: <20160708094528.GF20485@shlinux2> (raw)
In-Reply-To: <20160707222114.1673-9-stephen.boyd@linaro.org>
On Thu, Jul 07, 2016 at 03:20:59PM -0700, Stephen Boyd wrote:
> We don't call hw_device_reset() with the ci->lock held, so it
> doesn't seem like this lock here is protecting anything. Let's
> just remove it. This allows us to call sleeping functions like
> phy_init() from within the CI_HDRC_CONTROLLER_RESET_EVENT hook.
>
> Cc: Peter Chen <peter.chen@nxp.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
> ---
> drivers/usb/chipidea/udc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
> index 065f5d97aa67..f16be4710cdb 100644
> --- a/drivers/usb/chipidea/udc.c
> +++ b/drivers/usb/chipidea/udc.c
> @@ -1719,7 +1719,6 @@ static int ci_udc_start(struct usb_gadget *gadget,
> struct usb_gadget_driver *driver)
> {
> struct ci_hdrc *ci = container_of(gadget, struct ci_hdrc, gadget);
> - unsigned long flags;
> int retval = -ENOMEM;
>
> if (driver->disconnect == NULL)
> @@ -1746,7 +1745,6 @@ static int ci_udc_start(struct usb_gadget *gadget,
>
> pm_runtime_get_sync(&ci->gadget.dev);
> if (ci->vbus_active) {
> - spin_lock_irqsave(&ci->lock, flags);
> hw_device_reset(ci);
> } else {
> usb_udc_vbus_handler(&ci->gadget, false);
> @@ -1755,7 +1753,6 @@ static int ci_udc_start(struct usb_gadget *gadget,
> }
>
> retval = hw_device_state(ci, ci->ep0out->qh.dma);
> - spin_unlock_irqrestore(&ci->lock, flags);
> if (retval)
> pm_runtime_put_sync(&ci->gadget.dev);
>
The main purpose for this is disabling interrupt when reset controller,
in case the unexpected interrupts occur.
You can move this between hw_device_state.
--
Best Regards,
Peter Chen
WARNING: multiple messages have this Message-ID (diff)
From: Peter Chen <hzpeterchen@gmail.com>
To: Stephen Boyd <stephen.boyd@linaro.org>
Cc: linux-usb@vger.kernel.org, Felipe Balbi <balbi@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Neil Armstrong <narmstrong@baylibre.com>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Peter Chen <peter.chen@nxp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Gross <andy.gross@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 08/22] usb: chipidea: Remove locking in ci_udc_start()
Date: Fri, 8 Jul 2016 17:45:28 +0800 [thread overview]
Message-ID: <20160708094528.GF20485@shlinux2> (raw)
In-Reply-To: <20160707222114.1673-9-stephen.boyd@linaro.org>
On Thu, Jul 07, 2016 at 03:20:59PM -0700, Stephen Boyd wrote:
> We don't call hw_device_reset() with the ci->lock held, so it
> doesn't seem like this lock here is protecting anything. Let's
> just remove it. This allows us to call sleeping functions like
> phy_init() from within the CI_HDRC_CONTROLLER_RESET_EVENT hook.
>
> Cc: Peter Chen <peter.chen@nxp.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
> ---
> drivers/usb/chipidea/udc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
> index 065f5d97aa67..f16be4710cdb 100644
> --- a/drivers/usb/chipidea/udc.c
> +++ b/drivers/usb/chipidea/udc.c
> @@ -1719,7 +1719,6 @@ static int ci_udc_start(struct usb_gadget *gadget,
> struct usb_gadget_driver *driver)
> {
> struct ci_hdrc *ci = container_of(gadget, struct ci_hdrc, gadget);
> - unsigned long flags;
> int retval = -ENOMEM;
>
> if (driver->disconnect == NULL)
> @@ -1746,7 +1745,6 @@ static int ci_udc_start(struct usb_gadget *gadget,
>
> pm_runtime_get_sync(&ci->gadget.dev);
> if (ci->vbus_active) {
> - spin_lock_irqsave(&ci->lock, flags);
> hw_device_reset(ci);
> } else {
> usb_udc_vbus_handler(&ci->gadget, false);
> @@ -1755,7 +1753,6 @@ static int ci_udc_start(struct usb_gadget *gadget,
> }
>
> retval = hw_device_state(ci, ci->ep0out->qh.dma);
> - spin_unlock_irqrestore(&ci->lock, flags);
> if (retval)
> pm_runtime_put_sync(&ci->gadget.dev);
>
The main purpose for this is disabling interrupt when reset controller,
in case the unexpected interrupts occur.
You can move this between hw_device_state.
--
Best Regards,
Peter Chen
next prev parent reply other threads:[~2016-07-08 9:45 UTC|newest]
Thread overview: 165+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 22:20 [PATCH v2 00/22] Support qcom's HSIC USB and rewrite USB2 HS phy support Stephen Boyd
2016-07-07 22:20 ` Stephen Boyd
2016-07-07 22:20 ` [PATCH v2 02/22] of: device: Export of_device_{get_modalias,uvent_modalias} to modules Stephen Boyd
2016-07-07 22:20 ` [PATCH v2 02/22] of: device: Export of_device_{get_modalias, uvent_modalias} " Stephen Boyd
[not found] ` <20160707222114.1673-1-stephen.boyd-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-07-07 22:20 ` [PATCH v2 01/22] of: device: Support loading a module with OF based modalias Stephen Boyd
2016-07-07 22:20 ` Stephen Boyd
2016-07-07 22:20 ` Stephen Boyd
2016-07-07 22:20 ` [PATCH v2 03/22] usb: ulpi: Support device discovery via device properties Stephen Boyd
2016-07-07 22:20 ` Stephen Boyd
2016-07-07 22:20 ` Stephen Boyd
2016-07-08 9:04 ` Peter Chen
2016-07-08 9:04 ` Peter Chen
2016-08-05 21:27 ` Stephen Boyd
2016-08-05 21:27 ` Stephen Boyd
2016-08-23 19:58 ` Stephen Boyd
2016-08-23 19:58 ` Stephen Boyd
2016-08-23 19:58 ` Stephen Boyd
2016-08-24 7:31 ` Heikki Krogerus
2016-08-24 7:31 ` Heikki Krogerus
2016-08-24 7:31 ` Heikki Krogerus
2016-08-26 18:54 ` Stephen Boyd
2016-08-26 18:54 ` Stephen Boyd
[not found] ` <20160707222114.1673-4-stephen.boyd-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-07-18 2:23 ` Rob Herring
2016-07-18 2:23 ` Rob Herring
2016-07-18 2:23 ` Rob Herring
2016-08-05 21:40 ` Stephen Boyd
2016-08-05 21:40 ` Stephen Boyd
2016-08-23 20:00 ` Stephen Boyd
2016-08-23 20:00 ` Stephen Boyd
2016-08-23 20:00 ` Stephen Boyd
[not found] ` <CAJOFmgwTPDwdL_cc7f5N09enZNhKwSkWAxdpF39vOBQLfEdVSg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-23 23:06 ` Rob Herring
2016-08-23 23:06 ` Rob Herring
2016-08-23 23:06 ` Rob Herring
2016-08-24 1:06 ` Stephen Boyd
2016-08-24 1:06 ` Stephen Boyd
2016-07-07 22:21 ` [PATCH v2 10/22] usb: chipidea: Add support for ULPI PHY bus Stephen Boyd
2016-07-07 22:21 ` Stephen Boyd
2016-07-07 22:21 ` Stephen Boyd
2016-07-11 3:10 ` Peter Chen
2016-07-11 3:10 ` Peter Chen
2016-07-11 22:02 ` Stephen Boyd
2016-07-11 22:02 ` Stephen Boyd
2016-07-07 22:21 ` [PATCH v2 12/22] usb: chipidea: msm: Rely on core to override AHBBURST Stephen Boyd
2016-07-07 22:21 ` Stephen Boyd
2016-07-07 22:21 ` Stephen Boyd
2016-07-11 3:24 ` Peter Chen
2016-07-11 3:24 ` Peter Chen
2016-07-07 22:21 ` [PATCH v2 13/22] usb: chipidea: msm: Use hw_write_id_reg() instead of writel Stephen Boyd
2016-07-07 22:21 ` Stephen Boyd
2016-07-07 22:21 ` Stephen Boyd
2016-07-07 22:21 ` [PATCH v2 14/22] usb: chipidea: msm: Add proper clk and reset support Stephen Boyd
2016-07-07 22:21 ` Stephen Boyd
2016-07-07 22:21 ` Stephen Boyd
2016-07-11 4:32 ` Peter Chen
2016-07-11 4:32 ` Peter Chen
2016-07-07 22:21 ` [PATCH v2 15/22] usb: chipidea: msm: Mux over secondary phy at the right time Stephen Boyd
2016-07-07 22:21 ` Stephen Boyd
2016-07-07 22:21 ` Stephen Boyd
[not found] ` <20160707222114.1673-16-stephen.boyd-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-07-11 4:43 ` Peter Chen
2016-07-11 4:43 ` Peter Chen
2016-07-11 4:43 ` Peter Chen
2016-07-11 22:03 ` Stephen Boyd
2016-07-11 22:03 ` Stephen Boyd
2016-07-11 22:03 ` Stephen Boyd
2016-07-12 1:07 ` Peter Chen
2016-07-12 1:07 ` Peter Chen
2016-07-07 22:21 ` [PATCH v2 16/22] usb: chipidea: msm: Restore wrapper settings after reset Stephen Boyd
2016-07-07 22:21 ` Stephen Boyd
2016-07-07 22:21 ` Stephen Boyd
2016-07-11 5:24 ` Peter Chen
2016-07-11 5:24 ` Peter Chen
2016-07-07 22:21 ` [PATCH v2 17/22] usb: chipidea: msm: Make platform data driver local instead of global Stephen Boyd
2016-07-07 22:21 ` Stephen Boyd
2016-07-07 22:21 ` Stephen Boyd
2016-07-11 5:26 ` Peter Chen
2016-07-11 5:26 ` Peter Chen
2016-07-07 22:21 ` [PATCH v2 19/22] usb: chipidea: msm: Handle phy power states Stephen Boyd
2016-07-07 22:21 ` Stephen Boyd
2016-07-07 22:21 ` Stephen Boyd
2016-07-11 5:38 ` Peter Chen
2016-07-11 5:38 ` Peter Chen
2016-07-07 22:21 ` [PATCH v2 21/22] phy: Add support for Qualcomm's USB HSIC phy Stephen Boyd
2016-07-07 22:21 ` Stephen Boyd
2016-07-07 22:21 ` Stephen Boyd
2016-07-18 2:27 ` Rob Herring
2016-07-18 2:27 ` Rob Herring
2016-07-07 22:21 ` [PATCH v2 22/22] phy: Add support for Qualcomm's USB HS phy Stephen Boyd
2016-07-07 22:21 ` Stephen Boyd
2016-07-07 22:21 ` Stephen Boyd
[not found] ` <20160707222114.1673-23-stephen.boyd-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-07-18 2:28 ` Rob Herring
2016-07-18 2:28 ` Rob Herring
2016-07-18 2:28 ` Rob Herring
2016-07-07 22:20 ` [PATCH v2 04/22] usb: chipidea: Only read/write OTGSC from one place Stephen Boyd
2016-07-07 22:20 ` Stephen Boyd
2016-07-07 22:20 ` Stephen Boyd
2016-07-08 9:14 ` Peter Chen
2016-07-08 9:14 ` Peter Chen
2016-08-05 21:41 ` Stephen Boyd
2016-08-05 21:41 ` Stephen Boyd
2016-08-06 7:42 ` Peter Chen
2016-08-06 7:42 ` Peter Chen
2016-08-06 7:42 ` Peter Chen
2016-07-07 22:20 ` [PATCH v2 05/22] usb: chipidea: Handle extcon events properly Stephen Boyd
2016-07-07 22:20 ` Stephen Boyd
2016-07-07 22:20 ` Stephen Boyd
2016-07-07 22:20 ` [PATCH v2 06/22] usb: chipidea: Add platform flag for wrapper phy management Stephen Boyd
2016-07-07 22:20 ` Stephen Boyd
2016-07-07 22:20 ` Stephen Boyd
2016-07-08 9:25 ` Peter Chen
2016-07-08 9:25 ` Peter Chen
2016-08-05 21:46 ` Stephen Boyd
2016-08-05 21:46 ` Stephen Boyd
2016-08-06 7:59 ` Peter Chen
2016-08-06 7:59 ` Peter Chen
2016-08-06 7:59 ` Peter Chen
2016-08-08 23:46 ` Stephen Boyd
2016-08-08 23:46 ` Stephen Boyd
2016-08-09 0:36 ` Peter Chen
2016-08-09 0:36 ` Peter Chen
2016-08-09 0:36 ` Peter Chen
2016-07-07 22:20 ` [PATCH v2 07/22] usb: chipidea: Notify events when switching host mode Stephen Boyd
2016-07-07 22:20 ` Stephen Boyd
2016-07-07 22:20 ` Stephen Boyd
2016-07-08 9:29 ` Peter Chen
2016-07-08 9:29 ` Peter Chen
2016-07-08 9:29 ` Peter Chen
2016-07-07 22:20 ` [PATCH v2 08/22] usb: chipidea: Remove locking in ci_udc_start() Stephen Boyd
2016-07-07 22:20 ` Stephen Boyd
2016-07-07 22:20 ` Stephen Boyd
[not found] ` <20160707222114.1673-9-stephen.boyd-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-07-08 9:45 ` Peter Chen [this message]
2016-07-08 9:45 ` Peter Chen
2016-07-08 9:45 ` Peter Chen
2016-08-05 21:53 ` Stephen Boyd
2016-08-05 21:53 ` Stephen Boyd
2016-08-06 7:54 ` Peter Chen
2016-08-06 7:54 ` Peter Chen
2016-08-06 7:54 ` Peter Chen
2016-08-08 23:47 ` Stephen Boyd
2016-08-08 23:47 ` Stephen Boyd
2016-08-09 0:42 ` Peter Chen
2016-08-09 0:42 ` Peter Chen
2016-08-09 0:42 ` Peter Chen
2016-07-07 22:21 ` [PATCH v2 09/22] usb: chipidea: Kick OTG state machine for AVVIS with vbus extcon Stephen Boyd
2016-07-07 22:21 ` Stephen Boyd
2016-07-07 22:21 ` Stephen Boyd
[not found] ` <20160707222114.1673-10-stephen.boyd-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-07-11 2:25 ` Peter Chen
2016-07-11 2:25 ` Peter Chen
2016-07-11 2:25 ` Peter Chen
2016-07-07 22:21 ` [PATCH v2 11/22] usb: chipidea: msm: Mark device as runtime pm active Stephen Boyd
2016-07-07 22:21 ` Stephen Boyd
2016-07-11 3:19 ` Peter Chen
2016-07-11 3:19 ` Peter Chen
2016-07-07 22:21 ` [PATCH v2 18/22] usb: chipidea: msm: Add reset controller for PHY POR bit Stephen Boyd
2016-07-07 22:21 ` Stephen Boyd
[not found] ` <20160707222114.1673-19-stephen.boyd-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-07-11 5:32 ` Peter Chen
2016-07-11 5:32 ` Peter Chen
2016-07-11 5:32 ` Peter Chen
2016-07-11 22:07 ` Stephen Boyd
2016-07-11 22:07 ` Stephen Boyd
2016-07-12 1:09 ` Peter Chen
2016-07-12 1:09 ` Peter Chen
2016-07-07 22:21 ` [PATCH v2 20/22] usb: chipidea: msm: Be silent on probe defer errors Stephen Boyd
2016-07-07 22:21 ` Stephen Boyd
2016-07-11 5:39 ` Peter Chen
2016-07-11 5:39 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160708094528.GF20485@shlinux2 \
--to=hzpeterchen-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=balbi-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=peter.chen-3arQi8VN3Tc@public.gmane.org \
--cc=stephen.boyd-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.