From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: armada388-clearfog: number LAN ports properly
Date: Fri, 8 Jul 2016 17:26:16 +0200 [thread overview]
Message-ID: <20160708152616.GF8426@lunn.ch> (raw)
In-Reply-To: <E1bLWIh-0001ZK-Ai@rmk-PC.armlinux.org.uk>
On Fri, Jul 08, 2016 at 02:58:39PM +0100, Russell King wrote:
> Currently, the ports as seen from the rear number as:
>
> eth0 sfp lan5 lan4 lan3 lan2 lan1 lan6
>
> which is illogical - this came about because the rev 2.0 boards have the
> LEDs on the front for the DSA switch (lan5-1) reversed. Rev 2.1 boards
> fixed the LED issue, and the Clearfog case numbers the lan ports
> increasing from left to right.
>
> Maintaining this illogical numbering causes confusion, with reports that
> "my link isn't coming up" and "my connection negotiates 10base-Half"
> both of which are due to people thinking that the port next to the SFP
> is lan1.
>
> Fix this by renumbering the ports to match people's expectations.
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Russell King <rmk+kernel-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>
Cc: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Gregory Clement
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Sebastian Hesselbarth
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] ARM: dts: armada388-clearfog: number LAN ports properly
Date: Fri, 8 Jul 2016 17:26:16 +0200 [thread overview]
Message-ID: <20160708152616.GF8426@lunn.ch> (raw)
In-Reply-To: <E1bLWIh-0001ZK-Ai-eh5Bv4kxaXIk46pC+1QYvQNdhmdF6hFW@public.gmane.org>
On Fri, Jul 08, 2016 at 02:58:39PM +0100, Russell King wrote:
> Currently, the ports as seen from the rear number as:
>
> eth0 sfp lan5 lan4 lan3 lan2 lan1 lan6
>
> which is illogical - this came about because the rev 2.0 boards have the
> LEDs on the front for the DSA switch (lan5-1) reversed. Rev 2.1 boards
> fixed the LED issue, and the Clearfog case numbers the lan ports
> increasing from left to right.
>
> Maintaining this illogical numbering causes confusion, with reports that
> "my link isn't coming up" and "my connection negotiates 10base-Half"
> both of which are due to people thinking that the port next to the SFP
> is lan1.
>
> Fix this by renumbering the ports to match people's expectations.
>
> Signed-off-by: Russell King <rmk+kernel-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>
Reviewed-by: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-07-08 15:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 13:58 [PATCH] ARM: dts: armada388-clearfog: number LAN ports properly Russell King
2016-07-08 13:58 ` Russell King
2016-07-08 15:26 ` Andrew Lunn [this message]
2016-07-08 15:26 ` Andrew Lunn
2016-07-27 10:19 ` Gregory CLEMENT
2016-07-27 10:19 ` Gregory CLEMENT
2016-07-27 10:21 ` Russell King - ARM Linux
2016-07-27 10:21 ` Russell King - ARM Linux
2016-07-27 10:26 ` Gregory CLEMENT
2016-07-27 10:26 ` Gregory CLEMENT
2016-07-27 10:42 ` Russell King - ARM Linux
2016-07-27 10:42 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160708152616.GF8426@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.