From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: weiyj_lk@163.com
Cc: emilio@elopez.com.ar, mturquette@baylibre.com,
sboyd@codeaurora.org, wens@csie.org,
Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next] clk: sunxi: pll2: Fix return value check in sun4i_pll2_setup()
Date: Sat, 9 Jul 2016 10:25:32 +0200 [thread overview]
Message-ID: <20160709082532.GG4522@lukather> (raw)
In-Reply-To: <1467807514-31723-1-git-send-email-weiyj_lk@163.com>
[-- Attachment #1: Type: text/plain, Size: 533 bytes --]
On Wed, Jul 06, 2016 at 12:18:34PM +0000, weiyj_lk@163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the functions clk_register_composite() and
> clk_register_divider() returns ERR_PTR() and never returns NULL.
> The NULL test in the return value check should be replaced with
> IS_ERR().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Applied, thanks
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH -next] clk: sunxi: pll2: Fix return value check in sun4i_pll2_setup()
Date: Sat, 9 Jul 2016 10:25:32 +0200 [thread overview]
Message-ID: <20160709082532.GG4522@lukather> (raw)
In-Reply-To: <1467807514-31723-1-git-send-email-weiyj_lk@163.com>
On Wed, Jul 06, 2016 at 12:18:34PM +0000, weiyj_lk at 163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the functions clk_register_composite() and
> clk_register_divider() returns ERR_PTR() and never returns NULL.
> The NULL test in the return value check should be replaced with
> IS_ERR().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Applied, thanks
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160709/9d6fff52/attachment.sig>
next prev parent reply other threads:[~2016-07-09 8:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 12:18 [PATCH -next] clk: sunxi: pll2: Fix return value check in sun4i_pll2_setup() weiyj_lk
2016-07-06 12:18 ` weiyj_lk at 163.com
2016-07-09 8:25 ` Maxime Ripard [this message]
2016-07-09 8:25 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160709082532.GG4522@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=emilio@elopez.com.ar \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=weiyj_lk@163.com \
--cc=wens@csie.org \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.