All of lore.kernel.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 13/15] ARM: dts: sun8i: Add dt node for rtl8703as wifi chip on ga10h
Date: Mon, 11 Jul 2016 08:39:09 +0200	[thread overview]
Message-ID: <20160711063909.GA4589@lukather> (raw)
In-Reply-To: <1467993956-19535-14-git-send-email-hdegoede@redhat.com>

Hi,

On Fri, Jul 08, 2016 at 06:05:54PM +0200, Hans de Goede wrote:
> The ga10h tablet has a rtl8703as wifi chip, add a dt node describing it.
> 
> This enables usage of wifi on this tablet (together with the out of
> tree rtl8732bs driver).
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  arch/arm/boot/dts/sun8i-a33-ga10h-v1.1.dts | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-a33-ga10h-v1.1.dts b/arch/arm/boot/dts/sun8i-a33-ga10h-v1.1.dts
> index 6566032..de6269d 100644
> --- a/arch/arm/boot/dts/sun8i-a33-ga10h-v1.1.dts
> +++ b/arch/arm/boot/dts/sun8i-a33-ga10h-v1.1.dts
> @@ -47,6 +47,11 @@
>  / {
>  	model = "Allwinner GA10H Quad Core Tablet (v1.1)";
>  	compatible = "allwinner,ga10h-v1.1", "allwinner,sun8i-a33";
> +
> +	aliases {
> +		/* Make u-boot set mac-address for rtl8703as (no eeprom) */
> +		ethernet0 = &rtl8703as;
> +	};
>  };
>  
>  &ehci0 {
> @@ -62,6 +67,19 @@
>  	};
>  };
>  
> +&mmc1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&mmc1_pins_a>;
> +	vmmc-supply = <&reg_dldo1>;
> +	bus-width = <4>;
> +	non-removable;
> +	status = "okay";
> +
> +	rtl8703as: sdio_wifi at 1 {

Shouldn't that need a compatible ?

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160711/fd1e428f/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 13/15] ARM: dts: sun8i: Add dt node for rtl8703as wifi chip on ga10h
Date: Mon, 11 Jul 2016 08:39:09 +0200	[thread overview]
Message-ID: <20160711063909.GA4589@lukather> (raw)
In-Reply-To: <1467993956-19535-14-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1389 bytes --]

Hi,

On Fri, Jul 08, 2016 at 06:05:54PM +0200, Hans de Goede wrote:
> The ga10h tablet has a rtl8703as wifi chip, add a dt node describing it.
> 
> This enables usage of wifi on this tablet (together with the out of
> tree rtl8732bs driver).
> 
> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
>  arch/arm/boot/dts/sun8i-a33-ga10h-v1.1.dts | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-a33-ga10h-v1.1.dts b/arch/arm/boot/dts/sun8i-a33-ga10h-v1.1.dts
> index 6566032..de6269d 100644
> --- a/arch/arm/boot/dts/sun8i-a33-ga10h-v1.1.dts
> +++ b/arch/arm/boot/dts/sun8i-a33-ga10h-v1.1.dts
> @@ -47,6 +47,11 @@
>  / {
>  	model = "Allwinner GA10H Quad Core Tablet (v1.1)";
>  	compatible = "allwinner,ga10h-v1.1", "allwinner,sun8i-a33";
> +
> +	aliases {
> +		/* Make u-boot set mac-address for rtl8703as (no eeprom) */
> +		ethernet0 = &rtl8703as;
> +	};
>  };
>  
>  &ehci0 {
> @@ -62,6 +67,19 @@
>  	};
>  };
>  
> +&mmc1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&mmc1_pins_a>;
> +	vmmc-supply = <&reg_dldo1>;
> +	bus-width = <4>;
> +	non-removable;
> +	status = "okay";
> +
> +	rtl8703as: sdio_wifi@1 {

Shouldn't that need a compatible ?

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-07-11  6:39 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-08 16:05 [PATCH 00/15] ARM: dts: sunxi: Add reference-design-tablet.dtsi files + 2 new tablets Hans de Goede
2016-07-08 16:05 ` Hans de Goede
2016-07-08 16:05 ` [PATCH 01/15] ARM: dts: sunxi: Rename sunxi-q8-common.dtsi sunxi-reference-design-tablet.dtsi Hans de Goede
2016-07-08 16:05   ` Hans de Goede
2016-07-08 16:05 ` [PATCH 02/15] ARM: dts: sun5i: Move q8 display bits to sun5i-a13-q8-tablet.dts Hans de Goede
2016-07-08 16:05   ` Hans de Goede
2016-07-08 16:05 ` [PATCH 03/15] ARM: dts: sun5i: Rename sun5i-q8-common.dtsi sun5i-reference-design-tablet.dtsi Hans de Goede
2016-07-08 16:05   ` Hans de Goede
2016-07-08 16:05 ` [PATCH 04/15] ARM: dts: sun5i: reference-design-tablet: Set lradc vref to avcc Hans de Goede
2016-07-08 16:05   ` Hans de Goede
2016-07-08 16:05 ` [PATCH 05/15] ARM: dts: sun5i: reference-design-tablet: Remove mention of q8 Hans de Goede
2016-07-08 16:05   ` Hans de Goede
2016-07-09  3:53   ` Chen-Yu Tsai
2016-07-09  3:53     ` Chen-Yu Tsai
2016-07-09  9:28     ` Hans de Goede
2016-07-09  9:28       ` Hans de Goede
2016-07-08 16:05 ` [PATCH 06/15] ARM: dts: sun5i: Use sun5i-reference-design-tablet.dtsi for dit4350 dts Hans de Goede
2016-07-08 16:05   ` Hans de Goede
2016-07-08 16:05 ` [PATCH 07/15] ARM: dts: sun5i: Use sun5i-reference-design-tablet.dtsi for utoo p66 dts Hans de Goede
2016-07-08 16:05   ` Hans de Goede
2016-07-08 16:05 ` [PATCH 08/15] ARM: dts: Copy sun8i-q8-common.dtsi sun8i-reference-design-tablet.dtsi Hans de Goede
2016-07-08 16:05   ` Hans de Goede
2016-07-08 16:05 ` [PATCH 09/15] ARM: dts: sun8i: reference-design-tablet: Add drivevbus-supply Hans de Goede
2016-07-08 16:05   ` Hans de Goede
2016-07-08 16:05 ` [PATCH 10/15] ARM: dts: sun8i: Use sun8i-reference-design-tablet for polaroid mid2809pxe04 Hans de Goede
2016-07-08 16:05   ` Hans de Goede
2016-07-08 16:05 ` [PATCH 11/15] ARM: dts: sun8i: Use sun8i-reference-design-tablet for gt90h dts Hans de Goede
2016-07-08 16:05   ` Hans de Goede
2016-07-08 16:05 ` [PATCH 12/15] ARM: dts: sun8i: Use sun8i-reference-design-tablet for ga10h dts Hans de Goede
2016-07-08 16:05   ` Hans de Goede
2016-07-08 16:05 ` [PATCH 13/15] ARM: dts: sun8i: Add dt node for rtl8703as wifi chip on ga10h Hans de Goede
2016-07-08 16:05   ` Hans de Goede
2016-07-11  6:39   ` Maxime Ripard [this message]
2016-07-11  6:39     ` Maxime Ripard
2016-07-11 12:36     ` Hans de Goede
2016-07-11 12:36       ` Hans de Goede
2016-07-13  7:18       ` Maxime Ripard
2016-07-13  7:18         ` Maxime Ripard
2016-07-08 16:05 ` [PATCH 14/15] ARM: dts: sun8i: Add dts file for Polaroid MID2407PXE03 tablet Hans de Goede
2016-07-08 16:05   ` Hans de Goede
2016-07-08 16:05 ` [PATCH 15/15] ARM: dts: sun8i: Add dts file for inet86dz board Hans de Goede
2016-07-08 16:05   ` Hans de Goede
2016-07-11  6:39 ` [PATCH 00/15] ARM: dts: sunxi: Add reference-design-tablet.dtsi files + 2 new tablets Maxime Ripard
2016-07-11  6:39   ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160711063909.GA4589@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.