* [PATCH] ARM: s3c64xx: smartq: Avoid sparse warnings
@ 2016-07-11 8:48 ` Thierry Reding
0 siblings, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2016-07-11 8:48 UTC (permalink / raw)
To: Kukjin Kim, Krzysztof Kozlowski; +Cc: linux-arm-kernel, linux-samsung-soc
From: Thierry Reding <treding@nvidia.com>
The smartq_map_io() and smartq_machine_init() functions are used by both
SmartQ 5 and SmartQ 7 machines and exported via the mach-smartq.h header
file. However that header file is not included by the mach-smartq.c file
that implements them, causing sparse warnings.
Include mach-smartq.h from mach-smartq.c to fix these warnings.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
arch/arm/mach-s3c64xx/mach-smartq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-s3c64xx/mach-smartq.c b/arch/arm/mach-s3c64xx/mach-smartq.c
index 936a63fc68d5..e0e1a729ef98 100644
--- a/arch/arm/mach-s3c64xx/mach-smartq.c
+++ b/arch/arm/mach-s3c64xx/mach-smartq.c
@@ -43,6 +43,7 @@
#include <plat/samsung-time.h>
#include "common.h"
+#include "mach-smartq.h"
#include "regs-modem.h"
#define UCON S3C2410_UCON_DEFAULT
--
2.8.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: s3c64xx: smartq: Avoid sparse warnings
@ 2016-07-11 8:48 ` Thierry Reding
0 siblings, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2016-07-11 8:48 UTC (permalink / raw)
To: linux-arm-kernel
From: Thierry Reding <treding@nvidia.com>
The smartq_map_io() and smartq_machine_init() functions are used by both
SmartQ 5 and SmartQ 7 machines and exported via the mach-smartq.h header
file. However that header file is not included by the mach-smartq.c file
that implements them, causing sparse warnings.
Include mach-smartq.h from mach-smartq.c to fix these warnings.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
arch/arm/mach-s3c64xx/mach-smartq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-s3c64xx/mach-smartq.c b/arch/arm/mach-s3c64xx/mach-smartq.c
index 936a63fc68d5..e0e1a729ef98 100644
--- a/arch/arm/mach-s3c64xx/mach-smartq.c
+++ b/arch/arm/mach-s3c64xx/mach-smartq.c
@@ -43,6 +43,7 @@
#include <plat/samsung-time.h>
#include "common.h"
+#include "mach-smartq.h"
#include "regs-modem.h"
#define UCON S3C2410_UCON_DEFAULT
--
2.8.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: s3c64xx: smartq: Avoid sparse warnings
2016-07-11 8:48 ` Thierry Reding
@ 2016-07-11 15:47 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2016-07-11 15:47 UTC (permalink / raw)
To: Thierry Reding
Cc: Kukjin Kim, Krzysztof Kozlowski, linux-arm-kernel,
linux-samsung-soc
On Mon, Jul 11, 2016 at 10:48:36AM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> The smartq_map_io() and smartq_machine_init() functions are used by both
> SmartQ 5 and SmartQ 7 machines and exported via the mach-smartq.h header
> file. However that header file is not included by the mach-smartq.c file
> that implements them, causing sparse warnings.
>
> Include mach-smartq.h from mach-smartq.c to fix these warnings.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> arch/arm/mach-s3c64xx/mach-smartq.c | 1 +
> 1 file changed, 1 insertion(+)
>
Thanks, applied.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: s3c64xx: smartq: Avoid sparse warnings
@ 2016-07-11 15:47 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2016-07-11 15:47 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jul 11, 2016 at 10:48:36AM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> The smartq_map_io() and smartq_machine_init() functions are used by both
> SmartQ 5 and SmartQ 7 machines and exported via the mach-smartq.h header
> file. However that header file is not included by the mach-smartq.c file
> that implements them, causing sparse warnings.
>
> Include mach-smartq.h from mach-smartq.c to fix these warnings.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> arch/arm/mach-s3c64xx/mach-smartq.c | 1 +
> 1 file changed, 1 insertion(+)
>
Thanks, applied.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-07-11 15:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-11 8:48 [PATCH] ARM: s3c64xx: smartq: Avoid sparse warnings Thierry Reding
2016-07-11 8:48 ` Thierry Reding
2016-07-11 15:47 ` Krzysztof Kozlowski
2016-07-11 15:47 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.