From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dmaengine: pxa_dma: implement device_synchronize
Date: Tue, 12 Jul 2016 10:05:16 +0530 [thread overview]
Message-ID: <20160712043516.GP9681@localhost> (raw)
In-Reply-To: <1468187449-19466-1-git-send-email-robert.jarzmik@free.fr>
On Sun, Jul 10, 2016 at 11:50:49PM +0200, Robert Jarzmik wrote:
> Implement the function which wait until a dma channel is stopped to have
> a synchronization point.
>
> This also protects the pxad_remove() from races, such as spurious
> interrupts while removing the driver, because :
> - as long as there is one dma channel requested, ie. dma_chan_get() but
> no dma_chan_put(), the try_module_get() of dma_chan_get() prevents
> the remove() routine from running
> - when the last channel is released, ie. the last dma_chan_put() is
> called, if there is a running DMA, pxad_synchronize() is called
> - pxad_synchronize() waits for the channel to stop, which in turn
> ensures on pxa architecture that the interrupt cannot be fired anymore
Applied, thanks
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: pxa_dma: implement device_synchronize
Date: Tue, 12 Jul 2016 10:05:16 +0530 [thread overview]
Message-ID: <20160712043516.GP9681@localhost> (raw)
In-Reply-To: <1468187449-19466-1-git-send-email-robert.jarzmik@free.fr>
On Sun, Jul 10, 2016 at 11:50:49PM +0200, Robert Jarzmik wrote:
> Implement the function which wait until a dma channel is stopped to have
> a synchronization point.
>
> This also protects the pxad_remove() from races, such as spurious
> interrupts while removing the driver, because :
> - as long as there is one dma channel requested, ie. dma_chan_get() but
> no dma_chan_put(), the try_module_get() of dma_chan_get() prevents
> the remove() routine from running
> - when the last channel is released, ie. the last dma_chan_put() is
> called, if there is a running DMA, pxad_synchronize() is called
> - pxad_synchronize() waits for the channel to stop, which in turn
> ensures on pxa architecture that the interrupt cannot be fired anymore
Applied, thanks
--
~Vinod
next prev parent reply other threads:[~2016-07-12 4:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-10 21:50 [PATCH] dmaengine: pxa_dma: implement device_synchronize Robert Jarzmik
2016-07-10 21:50 ` Robert Jarzmik
2016-07-12 4:35 ` Vinod Koul [this message]
2016-07-12 4:35 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160712043516.GP9681@localhost \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.