All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: huawei.xie@intel.com, dev@dpdk.org,
	Jianfeng Tan <jianfeng.tan@intel.com>
Subject: Re: [PATCH] net/virtio-user: Fix missing brackets in if condition
Date: Tue, 12 Jul 2016 20:11:14 +0800	[thread overview]
Message-ID: <20160712121114.GF26521@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1468315825-24089-1-git-send-email-maxime.coquelin@redhat.com>

On Tue, Jul 12, 2016 at 11:30:25AM +0200, Maxime Coquelin wrote:
> The error is reported using test build script:
> 
> $ scripts/test-build.sh x86_64-native-linuxapp-gcc
> ...
> drivers/net/virtio/virtio_user_ethdev.c: In function ‘virtio_user_pmd_devinit’:
> drivers/net/virtio/virtio_user_ethdev.c:345:2: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation]
>   if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_PATH) == 1)
>     ^~
> 
> Fixes: 404bd6bfe360 ("net/virtio-user: fix return value not checked")
> 
> Cc: Jianfeng Tan <jianfeng.tan@intel.com>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>

Thanks for the fix.

	--yliu

  parent reply	other threads:[~2016-07-12 12:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-12  9:30 [PATCH] net/virtio-user: Fix missing brackets in if condition Maxime Coquelin
2016-07-12  9:35 ` Thomas Monjalon
2016-07-12  9:36   ` Maxime Coquelin
2016-07-12 12:11 ` Yuanhan Liu [this message]
2016-07-15 20:18   ` Thomas Monjalon
2016-07-14 16:31 ` viktorin
2016-07-15  1:29   ` Yuanhan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160712121114.GF26521@yliu-dev.sh.intel.com \
    --to=yuanhan.liu@linux.intel.com \
    --cc=dev@dpdk.org \
    --cc=huawei.xie@intel.com \
    --cc=jianfeng.tan@intel.com \
    --cc=maxime.coquelin@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.