From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: viktorin@rehivetech.com
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
huawei.xie@intel.com, dev@dpdk.org,
Jianfeng Tan <jianfeng.tan@intel.com>
Subject: Re: net/virtio-user: Fix missing brackets in if condition
Date: Fri, 15 Jul 2016 09:29:12 +0800 [thread overview]
Message-ID: <20160715012912.GC5146@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <20160714183111.4d44e564@jvn>
On Thu, Jul 14, 2016 at 06:31:11PM +0200, viktorin@rehivetech.com wrote:
> On Tue, 12 Jul 2016 11:30:25 +0200
> Maxime Coquelin <maxime.coquelin@redhat.com> wrote:
>
> > The error is reported using test build script:
>
> I recommend to note that the error is reported only by GCC 6+.
Agreed!
--yliu
>
> >
> > $ scripts/test-build.sh x86_64-native-linuxapp-gcc
> > ...
> > drivers/net/virtio/virtio_user_ethdev.c: In function ‘virtio_user_pmd_devinit’:
> > drivers/net/virtio/virtio_user_ethdev.c:345:2: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation]
> > if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_PATH) == 1)
> > ^~
> >
> > Fixes: 404bd6bfe360 ("net/virtio-user: fix return value not checked")
> >
> > Cc: Jianfeng Tan <jianfeng.tan@intel.com>
> > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> > Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> >
> Reviewed-by: Jan Viktorin <viktorin@rehivetech.com>
prev parent reply other threads:[~2016-07-15 1:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 9:30 [PATCH] net/virtio-user: Fix missing brackets in if condition Maxime Coquelin
2016-07-12 9:35 ` Thomas Monjalon
2016-07-12 9:36 ` Maxime Coquelin
2016-07-12 12:11 ` Yuanhan Liu
2016-07-15 20:18 ` Thomas Monjalon
2016-07-14 16:31 ` viktorin
2016-07-15 1:29 ` Yuanhan Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160715012912.GC5146@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=jianfeng.tan@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.