All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mel Gorman <mgorman@suse.de>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm: fix calculation accounting dirtyable highmem
Date: Wed, 13 Jul 2016 10:17:11 +0100	[thread overview]
Message-ID: <20160713091711.GI11400@suse.de> (raw)
In-Reply-To: <1468376593-26444-1-git-send-email-minchan@kernel.org>

On Wed, Jul 13, 2016 at 11:23:13AM +0900, Minchan Kim wrote:
> When I tested vmscale in mmtest in 32bit, I found the benchmark
> was slow down 0.5 times.
> 
>                 base        node
>                    1    global-1
> User           12.98       16.04
> System        147.61      166.42
> Elapsed        26.48       38.08
> 
> With vmstat, I found IO wait avg is much increased compared to
> base.
> 
> The reason was highmem_dirtyable_memory accumulates free pages
> and highmem_file_pages from HIGHMEM to MOVABLE zones which was
> wrong. With that, dirth_thresh in throtlle_vm_write is always
> 0 so that it calls congestion_wait frequently if writeback
> starts.
> 
> With this patch, it is much recovered.
> 
>                 base        node          fi
>                    1    global-1         fix
> User           12.98       16.04       13.78
> System        147.61      166.42      143.92
> Elapsed        26.48       38.08       29.64
> 
> Signed-off-by: Minchan Kim <minchan@kernel.org>

Thanks. I'll pick this up and send a follow-on series to Andrew with
this included.

-- 
Mel Gorman
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm: fix calculation accounting dirtyable highmem
Date: Wed, 13 Jul 2016 10:17:11 +0100	[thread overview]
Message-ID: <20160713091711.GI11400@suse.de> (raw)
In-Reply-To: <1468376593-26444-1-git-send-email-minchan@kernel.org>

On Wed, Jul 13, 2016 at 11:23:13AM +0900, Minchan Kim wrote:
> When I tested vmscale in mmtest in 32bit, I found the benchmark
> was slow down 0.5 times.
> 
>                 base        node
>                    1    global-1
> User           12.98       16.04
> System        147.61      166.42
> Elapsed        26.48       38.08
> 
> With vmstat, I found IO wait avg is much increased compared to
> base.
> 
> The reason was highmem_dirtyable_memory accumulates free pages
> and highmem_file_pages from HIGHMEM to MOVABLE zones which was
> wrong. With that, dirth_thresh in throtlle_vm_write is always
> 0 so that it calls congestion_wait frequently if writeback
> starts.
> 
> With this patch, it is much recovered.
> 
>                 base        node          fi
>                    1    global-1         fix
> User           12.98       16.04       13.78
> System        147.61      166.42      143.92
> Elapsed        26.48       38.08       29.64
> 
> Signed-off-by: Minchan Kim <minchan@kernel.org>

Thanks. I'll pick this up and send a follow-on series to Andrew with
this included.

-- 
Mel Gorman
SUSE Labs

  reply	other threads:[~2016-07-13  9:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-13  2:23 [PATCH] mm: fix calculation accounting dirtyable highmem Minchan Kim
2016-07-13  2:23 ` Minchan Kim
2016-07-13  9:17 ` Mel Gorman [this message]
2016-07-13  9:17   ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160713091711.GI11400@suse.de \
    --to=mgorman@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.