From: Dan Carpenter <dan.carpenter@oracle.com>
To: blogic@openwrt.org
Cc: linux-mips@linux-mips.org
Subject: [bug report] MIPS: lantiq: implement support for FALCON soc
Date: Wed, 13 Jul 2016 18:51:14 +0300 [thread overview]
Message-ID: <20160713155114.GA31747@mwanda> (raw)
Hello John Crispin,
The patch d41ced01f21d: "MIPS: lantiq: implement support for FALCON
soc" from Apr 19, 2012, leads to the following static checker warning:
arch/mips/lantiq/falcon/sysctrl.c:152 falcon_gpe_enable()
warn: mask and shift to zero
arch/mips/lantiq/falcon/sysctrl.c
140 /* enable the ONU core */
141 static void falcon_gpe_enable(void)
142 {
143 unsigned int freq;
144 unsigned int status;
145
146 /* if if the clock is already enabled */
147 status = sysctl_r32(SYSCTL_SYS1, SYS1_INFRAC);
148 if (status & (1 << (GPPC_OFFSET + 1)))
149 return;
150
151 freq = (status_r32(STATUS_CONFIG) &
152 GPEFREQ_MASK) >>
153 GPEFREQ_OFFSET;
This is 0xC0 >> 10 which is always zero.
154 if (freq == 0)
155 freq = 1; /* use 625MHz on unfused chip */
156
157 /* apply new frequency */
158 sysctl_w32_mask(SYSCTL_SYS1, 7 << (GPPC_OFFSET + 1),
159 freq << (GPPC_OFFSET + 2) , SYS1_INFRAC);
160 udelay(1);
161
162 /* enable new frequency */
163 sysctl_w32_mask(SYSCTL_SYS1, 0, 1 << (GPPC_OFFSET + 1), SYS1_INFRAC);
164 udelay(1);
165 }
regards,
dan carpenter
next reply other threads:[~2016-07-13 15:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 15:51 Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-12-07 20:04 [bug report] MIPS: lantiq: implement support for FALCON soc Dan Carpenter
2016-12-07 20:35 ` John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160713155114.GA31747@mwanda \
--to=dan.carpenter@oracle.com \
--cc=blogic@openwrt.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.