From: Brian Norris <computersforpeace@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
Teresa Remmet <t.remmet@phytec.de>,
Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [patch] mtd: nand: omap2: Cleanup a curly brace issue
Date: Thu, 14 Jul 2016 21:31:34 +0000 [thread overview]
Message-ID: <20160714213134.GA108554@google.com> (raw)
In-Reply-To: <20160714212608.GA10856@mwanda>
On Fri, Jul 15, 2016 at 12:26:08AM +0300, Dan Carpenter wrote:
> It doesn't affect runtime, but curly braces were obviously intended.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, but you're just a tad late ;)
http://patchwork.ozlabs.org/patch/648283/
Nice to point out that technically, the behavior doesn't really change
though.
Brian
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index a36ad3d..ab7c340 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -1655,10 +1655,11 @@ static int omap_get_dt_info(struct device *dev, struct omap_nand_info *info)
>
> /* detect availability of ELM module. Won't be present pre-OMAP4 */
> info->elm_of_node = of_parse_phandle(child, "ti,elm-id", 0);
> - if (!info->elm_of_node)
> + if (!info->elm_of_node) {
> info->elm_of_node = of_parse_phandle(child, "elm_id", 0);
> if (!info->elm_of_node)
> dev_dbg(dev, "ti,elm-id not in DT\n");
> + }
>
> /* select ecc-scheme for NAND */
> if (of_property_read_string(child, "ti,nand-ecc-opt", &s)) {
WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <computersforpeace@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
Teresa Remmet <t.remmet@phytec.de>,
Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [patch] mtd: nand: omap2: Cleanup a curly brace issue
Date: Thu, 14 Jul 2016 14:31:34 -0700 [thread overview]
Message-ID: <20160714213134.GA108554@google.com> (raw)
In-Reply-To: <20160714212608.GA10856@mwanda>
On Fri, Jul 15, 2016 at 12:26:08AM +0300, Dan Carpenter wrote:
> It doesn't affect runtime, but curly braces were obviously intended.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, but you're just a tad late ;)
http://patchwork.ozlabs.org/patch/648283/
Nice to point out that technically, the behavior doesn't really change
though.
Brian
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index a36ad3d..ab7c340 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -1655,10 +1655,11 @@ static int omap_get_dt_info(struct device *dev, struct omap_nand_info *info)
>
> /* detect availability of ELM module. Won't be present pre-OMAP4 */
> info->elm_of_node = of_parse_phandle(child, "ti,elm-id", 0);
> - if (!info->elm_of_node)
> + if (!info->elm_of_node) {
> info->elm_of_node = of_parse_phandle(child, "elm_id", 0);
> if (!info->elm_of_node)
> dev_dbg(dev, "ti,elm-id not in DT\n");
> + }
>
> /* select ecc-scheme for NAND */
> if (of_property_read_string(child, "ti,nand-ecc-opt", &s)) {
next prev parent reply other threads:[~2016-07-14 21:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 21:26 [patch] mtd: nand: omap2: Cleanup a curly brace issue Dan Carpenter
2016-07-14 21:26 ` Dan Carpenter
2016-07-14 21:31 ` Brian Norris [this message]
2016-07-14 21:31 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160714213134.GA108554@google.com \
--to=computersforpeace@gmail.com \
--cc=arnd@arndb.de \
--cc=boris.brezillon@free-electrons.com \
--cc=dan.carpenter@oracle.com \
--cc=dwmw2@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=t.remmet@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.