* [patch] ibmvfc: prevent a potential deadlock
@ 2016-07-15 11:18 ` Dan Carpenter
0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2016-07-15 11:18 UTC (permalink / raw)
To: Tyrel Datwyler
Cc: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
James E.J. Bottomley, Martin K. Petersen, linux-scsi,
linuxppc-dev, kernel-janitors
My static checker complains that we need to unlock on this path. Seems
true.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
index fc523c3..ab67ec4 100644
--- a/drivers/scsi/ibmvscsi/ibmvfc.c
+++ b/drivers/scsi/ibmvscsi/ibmvfc.c
@@ -4722,6 +4722,8 @@ static void ibmvfc_rport_add_thread(struct work_struct *work)
tgt_dbg(tgt, "Setting rport roles\n");
fc_remote_port_rolechg(rport, tgt->ids.roles);
put_device(&rport->dev);
+ } else {
+ spin_unlock_irqrestore(vhost->host->host_lock, flags);
}
kref_put(&tgt->kref, ibmvfc_release_tgt);
^ permalink raw reply related [flat|nested] 7+ messages in thread* [patch] ibmvfc: prevent a potential deadlock
@ 2016-07-15 11:18 ` Dan Carpenter
0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2016-07-15 11:18 UTC (permalink / raw)
To: Tyrel Datwyler
Cc: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
James E.J. Bottomley, Martin K. Petersen, linux-scsi,
linuxppc-dev, kernel-janitors
My static checker complains that we need to unlock on this path. Seems
true.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
index fc523c3..ab67ec4 100644
--- a/drivers/scsi/ibmvscsi/ibmvfc.c
+++ b/drivers/scsi/ibmvscsi/ibmvfc.c
@@ -4722,6 +4722,8 @@ static void ibmvfc_rport_add_thread(struct work_struct *work)
tgt_dbg(tgt, "Setting rport roles\n");
fc_remote_port_rolechg(rport, tgt->ids.roles);
put_device(&rport->dev);
+ } else {
+ spin_unlock_irqrestore(vhost->host->host_lock, flags);
}
kref_put(&tgt->kref, ibmvfc_release_tgt);
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [patch] ibmvfc: prevent a potential deadlock
2016-07-15 11:18 ` Dan Carpenter
@ 2016-07-15 13:38 ` Brian King
-1 siblings, 0 replies; 7+ messages in thread
From: Brian King @ 2016-07-15 13:38 UTC (permalink / raw)
To: Dan Carpenter, Tyrel Datwyler
Cc: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
James E.J. Bottomley, Martin K. Petersen, linux-scsi,
linuxppc-dev, kernel-janitors
Reviewed-by: Brian King <brking@linux.vnet.ibm.com>
--
Brian King
Power Linux I/O
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch] ibmvfc: prevent a potential deadlock
2016-07-15 11:18 ` Dan Carpenter
(?)
(?)
@ 2016-07-15 15:06 ` Ewan D. Milne
-1 siblings, 0 replies; 7+ messages in thread
From: Ewan D. Milne @ 2016-07-15 15:06 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-scsi
On Fri, 2016-07-15 at 14:18 +0300, Dan Carpenter wrote:
> My static checker complains that we need to unlock on this path. Seems
> true.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
> index fc523c3..ab67ec4 100644
> --- a/drivers/scsi/ibmvscsi/ibmvfc.c
> +++ b/drivers/scsi/ibmvscsi/ibmvfc.c
> @@ -4722,6 +4722,8 @@ static void ibmvfc_rport_add_thread(struct work_struct *work)
> tgt_dbg(tgt, "Setting rport roles\n");
> fc_remote_port_rolechg(rport, tgt->ids.roles);
> put_device(&rport->dev);
> + } else {
> + spin_unlock_irqrestore(vhost->host->host_lock, flags);
> }
>
> kref_put(&tgt->kref, ibmvfc_release_tgt);
> --
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [patch] ibmvfc: prevent a potential deadlock
2016-07-15 11:18 ` Dan Carpenter
@ 2016-07-15 19:14 ` Martin K. Petersen
-1 siblings, 0 replies; 7+ messages in thread
From: Martin K. Petersen @ 2016-07-15 19:14 UTC (permalink / raw)
To: Dan Carpenter
Cc: Tyrel Datwyler, Benjamin Herrenschmidt, Paul Mackerras,
Michael Ellerman, James E.J. Bottomley, Martin K. Petersen,
linux-scsi, linuxppc-dev, kernel-janitors
>>>>> "Dan" = Dan Carpenter <dan.carpenter@oracle.com> writes:
Dan> My static checker complains that we need to unlock on this path.
Dan> Seems true.
Applied to 4.8/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch] ibmvfc: prevent a potential deadlock
@ 2016-07-15 19:14 ` Martin K. Petersen
0 siblings, 0 replies; 7+ messages in thread
From: Martin K. Petersen @ 2016-07-15 19:14 UTC (permalink / raw)
To: Dan Carpenter
Cc: Tyrel Datwyler, Benjamin Herrenschmidt, Paul Mackerras,
Michael Ellerman, James E.J. Bottomley, Martin K. Petersen,
linux-scsi, linuxppc-dev, kernel-janitors
>>>>> "Dan" == Dan Carpenter <dan.carpenter@oracle.com> writes:
Dan> My static checker complains that we need to unlock on this path.
Dan> Seems true.
Applied to 4.8/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-07-15 19:14 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-15 11:18 [patch] ibmvfc: prevent a potential deadlock Dan Carpenter
2016-07-15 11:18 ` Dan Carpenter
2016-07-15 13:38 ` Brian King
2016-07-15 13:38 ` Brian King
2016-07-15 15:06 ` Ewan D. Milne
2016-07-15 19:14 ` Martin K. Petersen
2016-07-15 19:14 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.