From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch 1/2] perf jit: add missing curly braces
Date: Fri, 15 Jul 2016 22:25:56 +0000 [thread overview]
Message-ID: <20160715222556.GE8740@kernel.org> (raw)
In-Reply-To: <20160715210712.GA19522@mwanda>
Em Sat, Jul 16, 2016 at 12:07:12AM +0300, Dan Carpenter escreveu:
> It doesn't change the runtime behavior, but my static checker complains
> that curly braces were intended.
Agreed, applying, thanks!
- Arnaldo
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/tools/perf/jvmti/jvmti_agent.c b/tools/perf/jvmti/jvmti_agent.c
> index 3573f31..91bf333 100644
> --- a/tools/perf/jvmti/jvmti_agent.c
> +++ b/tools/perf/jvmti/jvmti_agent.c
> @@ -491,10 +491,11 @@ jvmti_write_debug_info(void *agent, uint64_t code, const char *file,
> if (sret != 1)
> goto error;
> }
> - if (padding_count)
> + if (padding_count) {
> sret = fwrite_unlocked(pad_bytes, padding_count, 1, fp);
> if (sret != 1)
> goto error;
> + }
>
> funlockfile(fp);
> return 0;
WARNING: multiple messages have this Message-ID (diff)
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch 1/2] perf jit: add missing curly braces
Date: Fri, 15 Jul 2016 19:25:56 -0300 [thread overview]
Message-ID: <20160715222556.GE8740@kernel.org> (raw)
In-Reply-To: <20160715210712.GA19522@mwanda>
Em Sat, Jul 16, 2016 at 12:07:12AM +0300, Dan Carpenter escreveu:
> It doesn't change the runtime behavior, but my static checker complains
> that curly braces were intended.
Agreed, applying, thanks!
- Arnaldo
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/tools/perf/jvmti/jvmti_agent.c b/tools/perf/jvmti/jvmti_agent.c
> index 3573f31..91bf333 100644
> --- a/tools/perf/jvmti/jvmti_agent.c
> +++ b/tools/perf/jvmti/jvmti_agent.c
> @@ -491,10 +491,11 @@ jvmti_write_debug_info(void *agent, uint64_t code, const char *file,
> if (sret != 1)
> goto error;
> }
> - if (padding_count)
> + if (padding_count) {
> sret = fwrite_unlocked(pad_bytes, padding_count, 1, fp);
> if (sret != 1)
> goto error;
> + }
>
> funlockfile(fp);
> return 0;
next prev parent reply other threads:[~2016-07-15 22:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 21:07 [patch 1/2] perf jit: add missing curly braces Dan Carpenter
2016-07-15 21:07 ` Dan Carpenter
2016-07-15 22:25 ` Arnaldo Carvalho de Melo [this message]
2016-07-15 22:25 ` Arnaldo Carvalho de Melo
2016-07-15 22:27 ` Arnaldo Carvalho de Melo
2016-07-15 22:27 ` Arnaldo Carvalho de Melo
2016-07-16 16:30 ` Stephane Eranian
2016-07-16 16:30 ` Stephane Eranian
2016-07-19 6:49 ` [tip:perf/core] perf jit: Add " tip-bot for Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160715222556.GE8740@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=dan.carpenter@oracle.com \
--cc=eranian@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.