[tip:x86/headers 6/9] arch/x86/platform/ts5500/ts5500.c:349:16: error: expected declaration specifiers or '...' before string constant

[tip:x86/headers 6/9] arch/x86/platform/ts5500/ts5500.c:349:16: error: expected declaration specifiers or '...' before string constant

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 2311 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/headers
head:   eb008eb6f8b689853d6e9f4ae3ff56ea734e4319
commit: cc3ae7b0af27118994c1e491382b253be3b762bf [6/9] x86/platform: Audit and remove any unnecessary uses of module.h
config: i386-randconfig-c0-07160258 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
        git checkout cc3ae7b0af27118994c1e491382b253be3b762bf
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

>> arch/x86/platform/ts5500/ts5500.c:349:16: error: expected declaration specifiers or '...' before string constant
    MODULE_LICENSE("GPL");
                   ^~~~~
   arch/x86/platform/ts5500/ts5500.c:350:15: error: expected declaration specifiers or '...' before string constant
    MODULE_AUTHOR("Savoir-faire Linux Inc. <kernel@savoirfairelinux.com>");
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/x86/platform/ts5500/ts5500.c:351:20: error: expected declaration specifiers or '...' before string constant
    MODULE_DESCRIPTION("Technologic Systems TS-5500 platform driver");
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +349 arch/x86/platform/ts5500/ts5500.c

7d029125 Vivien Didelot 2013-01-04  343  error:
7d029125 Vivien Didelot 2013-01-04  344  	platform_device_unregister(pdev);
7d029125 Vivien Didelot 2013-01-04  345  	return err;
7d029125 Vivien Didelot 2013-01-04  346  }
7d029125 Vivien Didelot 2013-01-04  347  device_initcall(ts5500_init);
7d029125 Vivien Didelot 2013-01-04  348  
7d029125 Vivien Didelot 2013-01-04 @349  MODULE_LICENSE("GPL");
7d029125 Vivien Didelot 2013-01-04  350  MODULE_AUTHOR("Savoir-faire Linux Inc. <kernel@savoirfairelinux.com>");
7d029125 Vivien Didelot 2013-01-04  351  MODULE_DESCRIPTION("Technologic Systems TS-5500 platform driver");

:::::: The code at line 349 was first introduced by commit
:::::: 7d0291256ca99cbb6124f63228003329e7a64b21 x86: Add TS-5500 platform support

:::::: TO: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
:::::: CC: Ingo Molnar <mingo@kernel.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 26700 bytes --]

Re: [tip:x86/headers 6/9] arch/x86/platform/ts5500/ts5500.c:349:16: error: expected declaration specifiers or '...' before string constant

[Paul Gortmaker]

[[tip:x86/headers 6/9] arch/x86/platform/ts5500/ts5500.c:349:16: error: expected declaration specifiers or '...' before string constant] On 16/07/2016 (Sat 03:53) kbuild test robot wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/headers
> head:   eb008eb6f8b689853d6e9f4ae3ff56ea734e4319
> commit: cc3ae7b0af27118994c1e491382b253be3b762bf [6/9] x86/platform: Audit and remove any unnecessary uses of module.h
> config: i386-randconfig-c0-07160258 (attached as .config)
> compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
> reproduce:
>         git checkout cc3ae7b0af27118994c1e491382b253be3b762bf
>         # save the attached .config to linux build tree
>         make ARCH=i386 
> 
> All errors (new ones prefixed by >>):
> 
> >> arch/x86/platform/ts5500/ts5500.c:349:16: error: expected declaration specifiers or '...' before string constant
>     MODULE_LICENSE("GPL");
>                    ^~~~~
>    arch/x86/platform/ts5500/ts5500.c:350:15: error: expected declaration specifiers or '...' before string constant
>     MODULE_AUTHOR("Savoir-faire Linux Inc. <kernel@savoirfairelinux.com>");
>                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    arch/x86/platform/ts5500/ts5500.c:351:20: error: expected declaration specifiers or '...' before string constant
>     MODULE_DESCRIPTION("Technologic Systems TS-5500 platform driver");
>                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The driver has a modular GPIO portion but the platform part is not at
all modular - however it doesn't get build coverage in all/yes/no/mod
so it was the robot that found it in randconfig testing.

Suggested fix follows:

 From d100dd662a6e58956295638ec7880e0507fa2797 Mon Sep 17 00:00:00 2001
From: Paul Gortmaker <paul.gortmaker@windriver.com>
Date: Fri, 15 Jul 2016 19:03:44 -0400
Subject: [PATCH] x86: platform: delete extraneous MODULE_* tags fromm ts5500

This file doesn't do anything modular and hence while the tristate
Kconfig used for the gpio portion is fine, it recently got swept up in
an audit of files using the module.h header but not using any modular
registration functions.

However it is not compiled in any of the normal build coverage, and
so some remaining extraneous MODULE macro use were not found until a
randconfig from the kbuild robot came across it.

Here we remove the remaining no-op MODULE macros from the built in
portion of code relating to this Kconfig option.

Fixes: cc3ae7b0af27 ("x86/platform: Audit and remove any unnecessary uses of module.h")
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Cc: "Savoir-faire Linux Inc." <kernel@savoirfairelinux.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 arch/x86/platform/ts5500/ts5500.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/x86/platform/ts5500/ts5500.c b/arch/x86/platform/ts5500/ts5500.c
index 952191bea75c..fd39301f25ac 100644
--- a/arch/x86/platform/ts5500/ts5500.c
+++ b/arch/x86/platform/ts5500/ts5500.c
@@ -345,7 +345,3 @@ error:
 	return err;
 }
 device_initcall(ts5500_init);
-
-MODULE_LICENSE("GPL");
-MODULE_AUTHOR("Savoir-faire Linux Inc. <kernel@savoirfairelinux.com>");
-MODULE_DESCRIPTION("Technologic Systems TS-5500 platform driver");
-- 
2.8.4

[tip:x86/headers] x86/platform: Delete extraneous MODULE_* tags fromm ts5500

[tip-bot for Paul Gortmaker]

Commit-ID:  00677f826bd0c1befb87b8cfa10f30bde1cc2f32
Gitweb:     http://git.kernel.org/tip/00677f826bd0c1befb87b8cfa10f30bde1cc2f32
Author:     Paul Gortmaker <paul.gortmaker@windriver.com>
AuthorDate: Fri, 15 Jul 2016 19:53:18 -0400
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Sat, 16 Jul 2016 22:41:00 +0200

x86/platform: Delete extraneous MODULE_* tags fromm ts5500

This file doesn't do anything modular and hence while the tristate
Kconfig used for the gpio portion is fine, it recently got swept up in
an audit of files using the module.h header but not using any modular
registration functions.

However it is not compiled in any of the normal build coverage, and
so some remaining extraneous MODULE macro use were not found until a
randconfig from the kbuild robot came across it.

Here we remove the remaining no-op MODULE macros from the built in
portion of code relating to this Kconfig option.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Savoir-faire Linux Inc. <kernel@savoirfairelinux.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: kbuild-all@01.org
Cc: linux-kernel@vger.kernel.org
Fixes: cc3ae7b0af27 ("x86/platform: Audit and remove any unnecessary uses of module.h")
Link: http://lkml.kernel.org/r/20160715235318.GD10758@windriver.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/platform/ts5500/ts5500.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/x86/platform/ts5500/ts5500.c b/arch/x86/platform/ts5500/ts5500.c
index 952191b..fd39301 100644
--- a/arch/x86/platform/ts5500/ts5500.c
+++ b/arch/x86/platform/ts5500/ts5500.c
@@ -345,7 +345,3 @@ error:
 	return err;
 }
 device_initcall(ts5500_init);
-
-MODULE_LICENSE("GPL");
-MODULE_AUTHOR("Savoir-faire Linux Inc. <kernel@savoirfairelinux.com>");
-MODULE_DESCRIPTION("Technologic Systems TS-5500 platform driver");