From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: Ralf Ramsauer
<ralf-ex4EvEgDZR1o7HI0AxOeTKwczVv4G7md@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Alexandre Courbot
<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [RESEND PATCH] ARM: tegra: fix erroneous address in dts
Date: Mon, 18 Jul 2016 11:58:02 +0200 [thread overview]
Message-ID: <20160718095802.GA422@ulmo.ba.sec> (raw)
In-Reply-To: <1468835208-13426-1-git-send-email-ralf-ex4EvEgDZR1o7HI0AxOeTKwczVv4G7md@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1970 bytes --]
On Mon, Jul 18, 2016 at 11:46:48AM +0200, Ralf Ramsauer wrote:
> c90bb7b enabled the high speed UARTs of the Jetson TK1. Due to a merge
> quirk, wrong addresses were introduced. Fix it and use the correct
> addresses.
>
> Thierry let me know, that there is another patch (b5896f67ab3c in
> linux-next) in preparation which removes all the '0,' prefixes of unit
> addresses on Tegra124 and is planned to go upstream in 4.8, so
> this patch will get reverted then.
>
> But for the moment, this patch is necessary to fix current misbehaviour.
>
> Fixes: c90bb7b9b9 ("ARM: tegra: Add high speed UARTs to Jetson TK1 device tree")
> Signed-off-by: Ralf Ramsauer <ralf-ex4EvEgDZR1o7HI0AxOeTKwczVv4G7md@public.gmane.org>
> Acked-by: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> ---
> arch/arm/boot/dts/tegra124-jetson-tk1.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
ARM-SoC maintainers,
Just to clarify, this is targetted at v4.7 because the offending patch
was merged in v4.7-rc1. If at all possible it'd be great to get this in,
even if this is terribly last minute.
Thanks,
Thierry
>
> diff --git a/arch/arm/boot/dts/tegra124-jetson-tk1.dts b/arch/arm/boot/dts/tegra124-jetson-tk1.dts
> index 941f362..f4d8125 100644
> --- a/arch/arm/boot/dts/tegra124-jetson-tk1.dts
> +++ b/arch/arm/boot/dts/tegra124-jetson-tk1.dts
> @@ -1386,7 +1386,7 @@
> * Pin 41: BR_UART1_TXD
> * Pin 44: BR_UART1_RXD
> */
> - serial@70006000 {
> + serial@0,70006000 {
> compatible = "nvidia,tegra124-hsuart", "nvidia,tegra30-hsuart";
> status = "okay";
> };
> @@ -1398,7 +1398,7 @@
> * Pin 71: UART2_CTS_L
> * Pin 74: UART2_RTS_L
> */
> - serial@70006040 {
> + serial@0,70006040 {
> compatible = "nvidia,tegra124-hsuart", "nvidia,tegra30-hsuart";
> status = "okay";
> };
> --
> 2.7.3
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: arm@kernel.org
Cc: Ralf Ramsauer <ralf@ramses-pyramidenbau.de>,
Stephen Warren <swarren@wwwdotorg.org>,
Alexandre Courbot <gnurou@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [RESEND PATCH] ARM: tegra: fix erroneous address in dts
Date: Mon, 18 Jul 2016 11:58:02 +0200 [thread overview]
Message-ID: <20160718095802.GA422@ulmo.ba.sec> (raw)
In-Reply-To: <1468835208-13426-1-git-send-email-ralf@ramses-pyramidenbau.de>
[-- Attachment #1: Type: text/plain, Size: 1889 bytes --]
On Mon, Jul 18, 2016 at 11:46:48AM +0200, Ralf Ramsauer wrote:
> c90bb7b enabled the high speed UARTs of the Jetson TK1. Due to a merge
> quirk, wrong addresses were introduced. Fix it and use the correct
> addresses.
>
> Thierry let me know, that there is another patch (b5896f67ab3c in
> linux-next) in preparation which removes all the '0,' prefixes of unit
> addresses on Tegra124 and is planned to go upstream in 4.8, so
> this patch will get reverted then.
>
> But for the moment, this patch is necessary to fix current misbehaviour.
>
> Fixes: c90bb7b9b9 ("ARM: tegra: Add high speed UARTs to Jetson TK1 device tree")
> Signed-off-by: Ralf Ramsauer <ralf@ramses-pyramidenbau.de>
> Acked-by: Thierry Reding <thierry.reding@gmail.com>
> Cc: linux-tegra@vger.kernel.org
> ---
> arch/arm/boot/dts/tegra124-jetson-tk1.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
ARM-SoC maintainers,
Just to clarify, this is targetted at v4.7 because the offending patch
was merged in v4.7-rc1. If at all possible it'd be great to get this in,
even if this is terribly last minute.
Thanks,
Thierry
>
> diff --git a/arch/arm/boot/dts/tegra124-jetson-tk1.dts b/arch/arm/boot/dts/tegra124-jetson-tk1.dts
> index 941f362..f4d8125 100644
> --- a/arch/arm/boot/dts/tegra124-jetson-tk1.dts
> +++ b/arch/arm/boot/dts/tegra124-jetson-tk1.dts
> @@ -1386,7 +1386,7 @@
> * Pin 41: BR_UART1_TXD
> * Pin 44: BR_UART1_RXD
> */
> - serial@70006000 {
> + serial@0,70006000 {
> compatible = "nvidia,tegra124-hsuart", "nvidia,tegra30-hsuart";
> status = "okay";
> };
> @@ -1398,7 +1398,7 @@
> * Pin 71: UART2_CTS_L
> * Pin 74: UART2_RTS_L
> */
> - serial@70006040 {
> + serial@0,70006040 {
> compatible = "nvidia,tegra124-hsuart", "nvidia,tegra30-hsuart";
> status = "okay";
> };
> --
> 2.7.3
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-07-18 9:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 9:46 [RESEND PATCH] ARM: tegra: fix erroneous address in dts Ralf Ramsauer
2016-07-18 9:46 ` Ralf Ramsauer
[not found] ` <1468835208-13426-1-git-send-email-ralf-ex4EvEgDZR1o7HI0AxOeTKwczVv4G7md@public.gmane.org>
2016-07-18 9:58 ` Thierry Reding [this message]
2016-07-18 9:58 ` Thierry Reding
2016-07-21 12:28 ` Arnd Bergmann
2016-07-21 12:37 ` Ralf Ramsauer
2016-07-24 20:38 ` Ralf Ramsauer
2016-07-24 20:38 ` Ralf Ramsauer
[not found] ` <c44f8315-d9dd-cf0b-775b-231af99ba7d3-ex4EvEgDZR1o7HI0AxOeTKwczVv4G7md@public.gmane.org>
2016-07-25 14:18 ` Thierry Reding
2016-07-25 14:18 ` Thierry Reding
2016-08-10 20:46 ` Arnd Bergmann
2016-08-12 17:26 ` Ralf Ramsauer
2016-08-12 17:26 ` Ralf Ramsauer
[not found] ` <d2469177-0eae-cd11-aa43-74baa374cc6c-ex4EvEgDZR1o7HI0AxOeTKwczVv4G7md@public.gmane.org>
2016-08-29 13:53 ` Ralf Ramsauer
2016-08-29 13:53 ` Ralf Ramsauer
2016-09-07 13:50 ` Ralf Ramsauer
2016-09-07 13:50 ` Ralf Ramsauer
[not found] ` <78670ccc-83ad-c7be-0377-dea1d794c078-ex4EvEgDZR1o7HI0AxOeTKwczVv4G7md@public.gmane.org>
2016-09-08 4:18 ` Olof Johansson
2016-09-08 4:18 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160718095802.GA422@ulmo.ba.sec \
--to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ralf-ex4EvEgDZR1o7HI0AxOeTKwczVv4G7md@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.