* [PATCH resend] intel_rapl: downgrade message if no RAPL domains found in a VM
@ 2016-07-19 11:49 Paolo Bonzini
2016-07-19 12:27 ` Jacob Pan
2016-07-21 13:19 ` Rafael J. Wysocki
0 siblings, 2 replies; 6+ messages in thread
From: Paolo Bonzini @ 2016-07-19 11:49 UTC (permalink / raw)
To: linux-kernel
Cc: Thomas Renninger, Peter Zijlstra, rjw, linux-pm, Jacob Pan,
Andy Lutomirski
People complain about the driver saying there's no valid RAPL domains
in a VM, and doing so at KERN_ERR severity. Downgrade this to KERN_INFO
if running on a hypervisor, since it is basically stating the obvious.
Suggested-by: Peter Zijlstra <peterz@infradead.org>
Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: Andy Lutomirski <luto@amacapital.net>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
First sent out about a year ago. :)
drivers/powercap/intel_rapl.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
index b2766b867b0e..0a0b09910116 100644
--- a/drivers/powercap/intel_rapl.c
+++ b/drivers/powercap/intel_rapl.c
@@ -1392,7 +1392,9 @@ static int rapl_detect_domains(struct rapl_package *rp, int cpu)
}
rp->nr_domains = bitmap_weight(&rp->domain_map, RAPL_DOMAIN_MAX);
if (!rp->nr_domains) {
- pr_err("no valid rapl domains found in package %d\n", rp->id);
+ printk("%sNo valid RAPL domains found in package %d\n",
+ boot_cpu_has(X86_FEATURE_HYPERVISOR) ? KERN_INFO : KERN_ERR,
+ rp->id);
ret = -ENODEV;
goto done;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH resend] intel_rapl: downgrade message if no RAPL domains found in a VM
2016-07-19 11:49 [PATCH resend] intel_rapl: downgrade message if no RAPL domains found in a VM Paolo Bonzini
@ 2016-07-19 12:27 ` Jacob Pan
2016-07-21 13:19 ` Rafael J. Wysocki
1 sibling, 0 replies; 6+ messages in thread
From: Jacob Pan @ 2016-07-19 12:27 UTC (permalink / raw)
To: Paolo Bonzini
Cc: linux-kernel, Thomas Renninger, Peter Zijlstra, rjw, linux-pm,
Andy Lutomirski, jacob.jun.pan
On Tue, 19 Jul 2016 13:49:57 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:
> People complain about the driver saying there's no valid RAPL domains
> in a VM, and doing so at KERN_ERR severity. Downgrade this to
> KERN_INFO if running on a hypervisor, since it is basically stating
> the obvious.
>
Acked-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> Suggested-by: Peter Zijlstra <peterz@infradead.org>
> Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
> Cc: Andy Lutomirski <luto@amacapital.net>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> First sent out about a year ago. :)
>
> drivers/powercap/intel_rapl.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/powercap/intel_rapl.c
> b/drivers/powercap/intel_rapl.c index b2766b867b0e..0a0b09910116
> 100644 --- a/drivers/powercap/intel_rapl.c
> +++ b/drivers/powercap/intel_rapl.c
> @@ -1392,7 +1392,9 @@ static int rapl_detect_domains(struct
> rapl_package *rp, int cpu) }
> rp->nr_domains = bitmap_weight(&rp->domain_map,
> RAPL_DOMAIN_MAX); if (!rp->nr_domains) {
> - pr_err("no valid rapl domains found in package
> %d\n", rp->id);
> + printk("%sNo valid RAPL domains found in package
> %d\n",
> + boot_cpu_has(X86_FEATURE_HYPERVISOR) ?
> KERN_INFO : KERN_ERR,
> + rp->id);
> ret = -ENODEV;
> goto done;
> }
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH resend] intel_rapl: downgrade message if no RAPL domains found in a VM
2016-07-19 11:49 [PATCH resend] intel_rapl: downgrade message if no RAPL domains found in a VM Paolo Bonzini
2016-07-19 12:27 ` Jacob Pan
@ 2016-07-21 13:19 ` Rafael J. Wysocki
2016-07-21 14:58 ` Paolo Bonzini
1 sibling, 1 reply; 6+ messages in thread
From: Rafael J. Wysocki @ 2016-07-21 13:19 UTC (permalink / raw)
To: Paolo Bonzini
Cc: linux-kernel, Thomas Renninger, Peter Zijlstra, linux-pm,
Jacob Pan, Andy Lutomirski
On Tuesday, July 19, 2016 01:49:57 PM Paolo Bonzini wrote:
> People complain about the driver saying there's no valid RAPL domains
> in a VM, and doing so at KERN_ERR severity. Downgrade this to KERN_INFO
> if running on a hypervisor, since it is basically stating the obvious.
>
> Suggested-by: Peter Zijlstra <peterz@infradead.org>
> Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
> Cc: Andy Lutomirski <luto@amacapital.net>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> First sent out about a year ago. :)
>
> drivers/powercap/intel_rapl.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
> index b2766b867b0e..0a0b09910116 100644
> --- a/drivers/powercap/intel_rapl.c
> +++ b/drivers/powercap/intel_rapl.c
> @@ -1392,7 +1392,9 @@ static int rapl_detect_domains(struct rapl_package *rp, int cpu)
> }
> rp->nr_domains = bitmap_weight(&rp->domain_map, RAPL_DOMAIN_MAX);
> if (!rp->nr_domains) {
> - pr_err("no valid rapl domains found in package %d\n", rp->id);
> + printk("%sNo valid RAPL domains found in package %d\n",
> + boot_cpu_has(X86_FEATURE_HYPERVISOR) ? KERN_INFO : KERN_ERR,
> + rp->id);
But we print that message with pr_debug() now (as in linux-next).
Do you still want to do anything about that?
> ret = -ENODEV;
> goto done;
> }
>
Thanks,
Rafael
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH resend] intel_rapl: downgrade message if no RAPL domains found in a VM
2016-07-21 13:19 ` Rafael J. Wysocki
@ 2016-07-21 14:58 ` Paolo Bonzini
0 siblings, 0 replies; 6+ messages in thread
From: Paolo Bonzini @ 2016-07-21 14:58 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: linux-kernel, Thomas Renninger, Peter Zijlstra, linux-pm,
Jacob Pan, Andy Lutomirski
----- Original Message -----
> From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> To: "Paolo Bonzini" <pbonzini@redhat.com>
> Cc: linux-kernel@vger.kernel.org, "Thomas Renninger" <trenn@suse.de>, "Peter Zijlstra" <peterz@infradead.org>,
> linux-pm@vger.kernel.org, "Jacob Pan" <jacob.jun.pan@linux.intel.com>, "Andy Lutomirski" <luto@amacapital.net>
> Sent: Thursday, July 21, 2016 3:19:28 PM
> Subject: Re: [PATCH resend] intel_rapl: downgrade message if no RAPL domains found in a VM
>
> On Tuesday, July 19, 2016 01:49:57 PM Paolo Bonzini wrote:
> > People complain about the driver saying there's no valid RAPL domains
> > in a VM, and doing so at KERN_ERR severity. Downgrade this to KERN_INFO
> > if running on a hypervisor, since it is basically stating the obvious.
> >
> > Suggested-by: Peter Zijlstra <peterz@infradead.org>
> > Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
> > Cc: Andy Lutomirski <luto@amacapital.net>
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
> > First sent out about a year ago. :)
> >
> > drivers/powercap/intel_rapl.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
> > index b2766b867b0e..0a0b09910116 100644
> > --- a/drivers/powercap/intel_rapl.c
> > +++ b/drivers/powercap/intel_rapl.c
> > @@ -1392,7 +1392,9 @@ static int rapl_detect_domains(struct rapl_package
> > *rp, int cpu)
> > }
> > rp->nr_domains = bitmap_weight(&rp->domain_map, RAPL_DOMAIN_MAX);
> > if (!rp->nr_domains) {
> > - pr_err("no valid rapl domains found in package %d\n", rp->id);
> > + printk("%sNo valid RAPL domains found in package %d\n",
> > + boot_cpu_has(X86_FEATURE_HYPERVISOR) ? KERN_INFO : KERN_ERR,
> > + rp->id);
>
> But we print that message with pr_debug() now (as in linux-next).
>
> Do you still want to do anything about that?
Oops, then I guess what is in linux-next is okay.
Thanks,
Paolo
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH resend] intel_rapl: downgrade message if no RAPL domains found in a VM
@ 2016-07-19 10:50 Paolo Bonzini
2016-07-19 11:48 ` Jacob Pan
0 siblings, 1 reply; 6+ messages in thread
From: Paolo Bonzini @ 2016-07-19 10:50 UTC (permalink / raw)
To: linux-kernel; +Cc: Thomas Renninger, Peter Zijlstra, Jacob Pan, Andy Lutomirski
People complain about the driver saying there's no valid RAPL domains
in a VM, and doing so at KERN_ERR severity. Downgrade this to KERN_INFO
if running on a hypervisor, since it is basically stating the obvious.
Suggested-by: Peter Zijlstra <peterz@infradead.org>
Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: Andy Lutomirski <luto@amacapital.net>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
First sent out about a year ago. :)
drivers/powercap/intel_rapl.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
index b2766b867b0e..0a0b09910116 100644
--- a/drivers/powercap/intel_rapl.c
+++ b/drivers/powercap/intel_rapl.c
@@ -1392,7 +1392,9 @@ static int rapl_detect_domains(struct rapl_package *rp, int cpu)
}
rp->nr_domains = bitmap_weight(&rp->domain_map, RAPL_DOMAIN_MAX);
if (!rp->nr_domains) {
- pr_err("no valid rapl domains found in package %d\n", rp->id);
+ printk("%sNo valid RAPL domains found in package %d\n",
+ boot_cpu_has(X86_FEATURE_HYPERVISOR) ? KERN_INFO : KERN_ERR,
+ rp->id);
ret = -ENODEV;
goto done;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH resend] intel_rapl: downgrade message if no RAPL domains found in a VM
2016-07-19 10:50 Paolo Bonzini
@ 2016-07-19 11:48 ` Jacob Pan
0 siblings, 0 replies; 6+ messages in thread
From: Jacob Pan @ 2016-07-19 11:48 UTC (permalink / raw)
To: Paolo Bonzini
Cc: linux-kernel, Thomas Renninger, Peter Zijlstra, Andy Lutomirski,
jacob.jun.pan
On Tue, 19 Jul 2016 12:50:19 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:
> People complain about the driver saying there's no valid RAPL domains
> in a VM, and doing so at KERN_ERR severity. Downgrade this to
> KERN_INFO if running on a hypervisor, since it is basically stating
> the obvious.
>
> Suggested-by: Peter Zijlstra <peterz@infradead.org>
> Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
> Cc: Andy Lutomirski <luto@amacapital.net>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> First sent out about a year ago. :)
>
> drivers/powercap/intel_rapl.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/powercap/intel_rapl.c
> b/drivers/powercap/intel_rapl.c index b2766b867b0e..0a0b09910116
> 100644 --- a/drivers/powercap/intel_rapl.c
> +++ b/drivers/powercap/intel_rapl.c
> @@ -1392,7 +1392,9 @@ static int rapl_detect_domains(struct
> rapl_package *rp, int cpu) }
> rp->nr_domains = bitmap_weight(&rp->domain_map,
> RAPL_DOMAIN_MAX); if (!rp->nr_domains) {
> - pr_err("no valid rapl domains found in package
> %d\n", rp->id);
> + printk("%sNo valid RAPL domains found in package
> %d\n",
> + boot_cpu_has(X86_FEATURE_HYPERVISOR) ?
> KERN_INFO : KERN_ERR,
> + rp->id);
> ret = -ENODEV;
> goto done;
> }
Looks good to me. Please send to Rafael and linux-pm list as well.
Thanks,
Jacob
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-07-21 14:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-19 11:49 [PATCH resend] intel_rapl: downgrade message if no RAPL domains found in a VM Paolo Bonzini
2016-07-19 12:27 ` Jacob Pan
2016-07-21 13:19 ` Rafael J. Wysocki
2016-07-21 14:58 ` Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2016-07-19 10:50 Paolo Bonzini
2016-07-19 11:48 ` Jacob Pan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.