From: Michal Hocko <mhocko@kernel.org>
To: Janani Ravichandran <janani.rvchndrn@gmail.com>
Cc: Rik van Riel <riel@surriel.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, hannes@cmpxchg.org,
vdavydov@virtuozzo.com, vbabka@suse.cz,
mgorman@techsingularity.net, kirill.shutemov@linux.intel.com,
bywxiaobai@163.com
Subject: Re: [PATCH 1/3] Add a new field to struct shrinker
Date: Wed, 20 Jul 2016 16:54:05 +0200 [thread overview]
Message-ID: <20160720145405.GP11249@dhcp22.suse.cz> (raw)
In-Reply-To: <F072D3E2-0514-4A25-868E-2104610EC14A@gmail.com>
On Wed 20-07-16 20:11:09, Janani Ravichandran wrote:
>
> > On Jul 11, 2016, at 8:03 PM, Michal Hocko <mhocko@kernel.org> wrote:
> >
> > On Mon 11-07-16 10:12:51, Rik van Riel wrote:
> >>
> >> What mechanism do you have in mind for obtaining the name,
> >> Michal?
> >
> > Not sure whether tracing infrastructure allows printk like %ps. If not
> > then it doesn't sound too hard to add.
>
> It does allow %ps. Currently what is being printed is the function symbol
> of the callback using %pF. Ia??d like to know why %pF is used instead of
> %ps in this case.
>From a quick look into the code %pF should be doing the same thing as
%ps in the end. Some architectures just need some magic to get a proper
address of the function.
> Michal, just to make sure I understand you correctly, do you mean that we
> could infer the names of the shrinkers by looking at the names of their callbacks?
Yes, %ps can then be used for the name of the shrinker structure
(assuming it is available).
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org>
To: Janani Ravichandran <janani.rvchndrn@gmail.com>
Cc: Rik van Riel <riel@surriel.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, hannes@cmpxchg.org,
vdavydov@virtuozzo.com, vbabka@suse.cz,
mgorman@techsingularity.net, kirill.shutemov@linux.intel.com,
bywxiaobai@163.com
Subject: Re: [PATCH 1/3] Add a new field to struct shrinker
Date: Wed, 20 Jul 2016 16:54:05 +0200 [thread overview]
Message-ID: <20160720145405.GP11249@dhcp22.suse.cz> (raw)
In-Reply-To: <F072D3E2-0514-4A25-868E-2104610EC14A@gmail.com>
On Wed 20-07-16 20:11:09, Janani Ravichandran wrote:
>
> > On Jul 11, 2016, at 8:03 PM, Michal Hocko <mhocko@kernel.org> wrote:
> >
> > On Mon 11-07-16 10:12:51, Rik van Riel wrote:
> >>
> >> What mechanism do you have in mind for obtaining the name,
> >> Michal?
> >
> > Not sure whether tracing infrastructure allows printk like %ps. If not
> > then it doesn't sound too hard to add.
>
> It does allow %ps. Currently what is being printed is the function symbol
> of the callback using %pF. I’d like to know why %pF is used instead of
> %ps in this case.
>From a quick look into the code %pF should be doing the same thing as
%ps in the end. Some architectures just need some magic to get a proper
address of the function.
> Michal, just to make sure I understand you correctly, do you mean that we
> could infer the names of the shrinkers by looking at the names of their callbacks?
Yes, %ps can then be used for the name of the shrinker structure
(assuming it is available).
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2016-07-20 14:54 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-09 8:33 [PATCH 0/3] Add names of shrinkers and have tracepoints display them Janani Ravichandran
2016-07-09 8:33 ` Janani Ravichandran
2016-07-09 8:43 ` [PATCH 1/3] Add a new field to struct shrinker Janani Ravichandran
2016-07-09 8:43 ` Janani Ravichandran
2016-07-11 6:37 ` Michal Hocko
2016-07-11 6:37 ` Michal Hocko
2016-07-11 14:12 ` Rik van Riel
2016-07-11 14:33 ` Michal Hocko
2016-07-11 14:33 ` Michal Hocko
2016-07-20 14:41 ` Janani Ravichandran
2016-07-20 14:41 ` Janani Ravichandran
2016-07-20 14:54 ` Michal Hocko [this message]
2016-07-20 14:54 ` Michal Hocko
2016-07-23 1:27 ` Tony Jones
2016-07-23 1:27 ` Tony Jones
2016-07-23 4:05 ` Tony Jones
2016-07-23 4:05 ` Tony Jones
2016-07-23 19:43 ` Rik van Riel
2016-07-23 23:21 ` Tony Jones
2016-07-23 23:21 ` Tony Jones
2016-07-26 16:40 ` Tony Jones
2016-07-26 16:40 ` Tony Jones
2016-07-28 5:49 ` Dave Chinner
2016-07-28 5:49 ` Dave Chinner
2016-07-28 10:25 ` Mel Gorman
2016-07-28 10:25 ` Mel Gorman
2016-07-29 0:13 ` Dave Chinner
2016-07-29 0:13 ` Dave Chinner
2016-07-29 13:00 ` Mel Gorman
2016-07-29 13:00 ` Mel Gorman
2016-08-12 3:09 ` Tony Jones
2016-08-12 3:09 ` Tony Jones
2016-07-09 8:52 ` [PATCH 2/3] Update name field for all shrinker instances Janani Ravichandran
2016-07-09 8:52 ` Janani Ravichandran
2016-07-13 0:43 ` Tony Jones
2016-07-13 0:43 ` Tony Jones
2016-07-09 9:05 ` [PATCH 3/3] Add name fields in shrinker tracepoint definitions Janani Ravichandran
2016-07-09 9:05 ` Janani Ravichandran
2016-07-09 9:45 ` kbuild test robot
2016-07-09 16:18 ` Janani Ravichandran
2016-07-11 14:18 ` Vlastimil Babka
2016-07-11 14:18 ` Vlastimil Babka
2016-07-13 0:35 ` Tony Jones
2016-07-13 0:35 ` Tony Jones
2016-07-13 6:16 ` Janani Ravichandran
2016-07-13 6:16 ` Janani Ravichandran
2016-07-13 19:12 ` Tony Jones
2016-07-13 19:12 ` Tony Jones
2016-07-13 19:48 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160720145405.GP11249@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bywxiaobai@163.com \
--cc=hannes@cmpxchg.org \
--cc=janani.rvchndrn@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=riel@surriel.com \
--cc=vbabka@suse.cz \
--cc=vdavydov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.