From: Mel Gorman <mgorman@techsingularity.net>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>, Vlastimil Babka <vbabka@suse.cz>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5] mm: consider per-zone inactive ratio to deactivate
Date: Thu, 21 Jul 2016 09:08:24 +0100 [thread overview]
Message-ID: <20160721080824.GE10438@techsingularity.net> (raw)
In-Reply-To: <20160721053017.GB31865@bbox>
On Thu, Jul 21, 2016 at 02:30:17PM +0900, Minchan Kim wrote:
> > The problem is due to the active deactivation logic in inactive_list_is_low.
> >
> > Node 0 active_anon:404412kB inactive_anon:409040kB
> >
> > IOW, (inactive_anon of node * inactive_ratio > active_anon of node) due to
> > highmem anonymous stat so VM never deactivates normal zone's anonymous pages.
> >
> > This patch is a modified version of Minchan's original solution but based
> > upon it. The problem with Minchan's patch is that it didn't take memcg
> > into account and any low zone with an imbalanced list could force a rotation.
>
> Could you explan why we should consider memcg here?
>
It already was and there is no good reason to ignore it if it's memcg
reclaim.
> > In this page, a zone-constrained global reclaim will rotate the list if
>
> patch,
>
I'll fix it.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@techsingularity.net>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>, Vlastimil Babka <vbabka@suse.cz>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5] mm: consider per-zone inactive ratio to deactivate
Date: Thu, 21 Jul 2016 09:08:24 +0100 [thread overview]
Message-ID: <20160721080824.GE10438@techsingularity.net> (raw)
In-Reply-To: <20160721053017.GB31865@bbox>
On Thu, Jul 21, 2016 at 02:30:17PM +0900, Minchan Kim wrote:
> > The problem is due to the active deactivation logic in inactive_list_is_low.
> >
> > Node 0 active_anon:404412kB inactive_anon:409040kB
> >
> > IOW, (inactive_anon of node * inactive_ratio > active_anon of node) due to
> > highmem anonymous stat so VM never deactivates normal zone's anonymous pages.
> >
> > This patch is a modified version of Minchan's original solution but based
> > upon it. The problem with Minchan's patch is that it didn't take memcg
> > into account and any low zone with an imbalanced list could force a rotation.
>
> Could you explan why we should consider memcg here?
>
It already was and there is no good reason to ignore it if it's memcg
reclaim.
> > In this page, a zone-constrained global reclaim will rotate the list if
>
> patch,
>
I'll fix it.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2016-07-21 8:08 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 15:21 [PATCH 0/5] Candidate fixes for premature OOM kills with node-lru v1 Mel Gorman
2016-07-20 15:21 ` Mel Gorman
2016-07-20 15:21 ` [PATCH 1/5] mm, vmscan: Do not account skipped pages as scanned Mel Gorman
2016-07-20 15:21 ` Mel Gorman
2016-07-21 5:16 ` Minchan Kim
2016-07-21 5:16 ` Minchan Kim
2016-07-21 8:15 ` Mel Gorman
2016-07-21 8:15 ` Mel Gorman
2016-07-21 8:31 ` Minchan Kim
2016-07-21 8:31 ` Minchan Kim
2016-07-25 8:04 ` Minchan Kim
2016-07-25 8:04 ` Minchan Kim
2016-07-25 9:20 ` Mel Gorman
2016-07-25 9:20 ` Mel Gorman
2016-07-28 1:38 ` Minchan Kim
2016-07-28 1:38 ` Minchan Kim
2016-07-20 15:21 ` [PATCH 2/5] mm: add per-zone lru list stat Mel Gorman
2016-07-20 15:21 ` Mel Gorman
2016-07-21 7:10 ` Joonsoo Kim
2016-07-21 7:10 ` Joonsoo Kim
2016-07-23 0:45 ` Fengguang Wu
2016-07-23 0:45 ` Fengguang Wu
2016-07-23 1:25 ` Minchan Kim
2016-07-23 1:25 ` Minchan Kim
2016-07-20 15:21 ` [PATCH 3/5] mm, vmscan: Remove highmem_file_pages Mel Gorman
2016-07-20 15:21 ` Mel Gorman
2016-07-20 15:21 ` [PATCH 4/5] mm: Remove reclaim and compaction retry approximations Mel Gorman
2016-07-20 15:21 ` Mel Gorman
2016-07-20 15:21 ` [PATCH 5/5] mm: consider per-zone inactive ratio to deactivate Mel Gorman
2016-07-20 15:21 ` Mel Gorman
2016-07-21 5:30 ` Minchan Kim
2016-07-21 5:30 ` Minchan Kim
2016-07-21 8:08 ` Mel Gorman [this message]
2016-07-21 8:08 ` Mel Gorman
2016-07-21 7:10 ` Joonsoo Kim
2016-07-21 7:10 ` Joonsoo Kim
2016-07-21 8:16 ` Mel Gorman
2016-07-21 8:16 ` Mel Gorman
2016-07-21 7:07 ` [PATCH 0/5] Candidate fixes for premature OOM kills with node-lru v1 Minchan Kim
2016-07-21 7:07 ` Minchan Kim
2016-07-21 9:15 ` Mel Gorman
2016-07-21 9:15 ` Mel Gorman
2016-07-21 7:31 ` Joonsoo Kim
2016-07-21 7:31 ` Joonsoo Kim
2016-07-21 8:39 ` Minchan Kim
2016-07-21 8:39 ` Minchan Kim
2016-07-21 9:16 ` Mel Gorman
2016-07-21 9:16 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160721080824.GE10438@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=minchan@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.