All of lore.kernel.org
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [4.7] arm64: Honor nosmp kernel command line option
Date: Thu, 21 Jul 2016 11:36:44 +0100	[thread overview]
Message-ID: <20160721103643.GD20559@leverpostej> (raw)
In-Reply-To: <1469096127-1136-1-git-send-email-suzuki.poulose@arm.com>

On Thu, Jul 21, 2016 at 11:15:27AM +0100, Suzuki K Poulose wrote:
> Passing "nosmp" should boot the kernel with a single processor, without
> provision to enable secondary CPUs even if they are present. "nosmp" is
> implemented by setting maxcpus=0. At the moment we still mark the secondary
> CPUs present even with nosmp, which allows the userspace to bring them
> up. This patch corrects the smp_prepare_cpus() to honor the maxcpus == 0.
> 
> Commit 44dbcc93ab67145 ("arm64: Fix behavior of maxcpus=N") fixed the
> behavior for maxcpus >= 1, but broke maxcpus = 0.
> 
> Fixes: commit 44dbcc93ab67145 ("arm64: Fix behavior of maxcpus=N")
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: James Morse <james.morse@arm.com>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> ---
>  arch/arm64/kernel/smp.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
> index d242e81..ec08b7a 100644
> --- a/arch/arm64/kernel/smp.c
> +++ b/arch/arm64/kernel/smp.c
> @@ -694,6 +694,13 @@ void __init smp_prepare_cpus(unsigned int max_cpus)
>  	smp_store_cpu_info(smp_processor_id());
>  
>  	/*
> +	 * If UP is mandated by "nosmp"(implies maxcpus=0), don't bother about

Nit: missing space between the quote abnd opening bracket. It would also
be nicer to have s/implies/which implies/

Otherwise:

Acked-by: Mark Rutland <mark.rutland@arm.com>

Mark.

> +	 * secondary CPUs.
> +	 */
> +	if (max_cpus == 0)
> +		return;
> +
> +	/*
>  	 * Initialise the present map (which describes the set of CPUs
>  	 * actually populated at the present time) and release the
>  	 * secondaries from the bootloader.
> -- 
> 2.7.4
> 

WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: catalin.marinas@arm.com, will.deacon@arm.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, James Morse <james.morse@arm.com>
Subject: Re: [PATCH] [4.7] arm64: Honor nosmp kernel command line option
Date: Thu, 21 Jul 2016 11:36:44 +0100	[thread overview]
Message-ID: <20160721103643.GD20559@leverpostej> (raw)
In-Reply-To: <1469096127-1136-1-git-send-email-suzuki.poulose@arm.com>

On Thu, Jul 21, 2016 at 11:15:27AM +0100, Suzuki K Poulose wrote:
> Passing "nosmp" should boot the kernel with a single processor, without
> provision to enable secondary CPUs even if they are present. "nosmp" is
> implemented by setting maxcpus=0. At the moment we still mark the secondary
> CPUs present even with nosmp, which allows the userspace to bring them
> up. This patch corrects the smp_prepare_cpus() to honor the maxcpus == 0.
> 
> Commit 44dbcc93ab67145 ("arm64: Fix behavior of maxcpus=N") fixed the
> behavior for maxcpus >= 1, but broke maxcpus = 0.
> 
> Fixes: commit 44dbcc93ab67145 ("arm64: Fix behavior of maxcpus=N")
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: James Morse <james.morse@arm.com>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> ---
>  arch/arm64/kernel/smp.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
> index d242e81..ec08b7a 100644
> --- a/arch/arm64/kernel/smp.c
> +++ b/arch/arm64/kernel/smp.c
> @@ -694,6 +694,13 @@ void __init smp_prepare_cpus(unsigned int max_cpus)
>  	smp_store_cpu_info(smp_processor_id());
>  
>  	/*
> +	 * If UP is mandated by "nosmp"(implies maxcpus=0), don't bother about

Nit: missing space between the quote abnd opening bracket. It would also
be nicer to have s/implies/which implies/

Otherwise:

Acked-by: Mark Rutland <mark.rutland@arm.com>

Mark.

> +	 * secondary CPUs.
> +	 */
> +	if (max_cpus == 0)
> +		return;
> +
> +	/*
>  	 * Initialise the present map (which describes the set of CPUs
>  	 * actually populated at the present time) and release the
>  	 * secondaries from the bootloader.
> -- 
> 2.7.4
> 

  reply	other threads:[~2016-07-21 10:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-21 10:15 [PATCH] [4.7] arm64: Honor nosmp kernel command line option Suzuki K Poulose
2016-07-21 10:15 ` Suzuki K Poulose
2016-07-21 10:36 ` Mark Rutland [this message]
2016-07-21 10:36   ` Mark Rutland
2016-07-21 15:05 ` Catalin Marinas
2016-07-21 15:05   ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160721103643.GD20559@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.