From: Ralf Baechle <ralf@linux-mips.org>
To: Huacai Chen <chenhc@lemote.com>
Cc: John Crispin <john@phrozen.org>,
linux-mips@linux-mips.org, Fuxin Zhang <zhangfx@lemote.com>,
Zhangjin Wu <wuzhangjin@gmail.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 2/3] MIPS: Don't register r4k sched clock when CPUFREQ enabled
Date: Fri, 22 Jul 2016 04:27:45 +0200 [thread overview]
Message-ID: <20160722022007.GC25689@linux-mips.org> (raw)
In-Reply-To: <1469082471-4936-2-git-send-email-chenhc@lemote.com>
On Thu, Jul 21, 2016 at 02:27:50PM +0800, Huacai Chen wrote:
> Don't register r4k sched clock when CPUFREQ enabled because sched clock
> need a constant frequency.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> ---
> arch/mips/kernel/csrc-r4k.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/mips/kernel/csrc-r4k.c b/arch/mips/kernel/csrc-r4k.c
> index 1f91056..5131b98 100644
> --- a/arch/mips/kernel/csrc-r4k.c
> +++ b/arch/mips/kernel/csrc-r4k.c
> @@ -82,7 +82,9 @@ int __init init_r4k_clocksource(void)
>
> clocksource_register_hz(&clocksource_mips, mips_hpt_frequency);
>
> +#ifndef CONFIG_CPUFREQ
> sched_clock_register(r4k_read_sched_clock, 32, mips_hpt_frequency);
> +#endif
There is no config symbol CONFIG_CPUFREQ and I think if the clock may
change, we shouldn't register it as csrc or cevt.
Ralf
WARNING: multiple messages have this Message-ID (diff)
From: Ralf Baechle <ralf@linux-mips.org>
To: Huacai Chen <chenhc@lemote.com>
Cc: John Crispin <john@phrozen.org>,
"Steven J . Hill" <Steven.Hill@imgtec.com>,
linux-mips@linux-mips.org, Fuxin Zhang <zhangfx@lemote.com>,
Zhangjin Wu <wuzhangjin@gmail.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 2/3] MIPS: Don't register r4k sched clock when CPUFREQ enabled
Date: Fri, 22 Jul 2016 04:20:08 +0200 [thread overview]
Message-ID: <20160722022007.GC25689@linux-mips.org> (raw)
In-Reply-To: <1469082471-4936-2-git-send-email-chenhc@lemote.com>
On Thu, Jul 21, 2016 at 02:27:50PM +0800, Huacai Chen wrote:
> Don't register r4k sched clock when CPUFREQ enabled because sched clock
> need a constant frequency.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> ---
> arch/mips/kernel/csrc-r4k.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/mips/kernel/csrc-r4k.c b/arch/mips/kernel/csrc-r4k.c
> index 1f91056..5131b98 100644
> --- a/arch/mips/kernel/csrc-r4k.c
> +++ b/arch/mips/kernel/csrc-r4k.c
> @@ -82,7 +82,9 @@ int __init init_r4k_clocksource(void)
>
> clocksource_register_hz(&clocksource_mips, mips_hpt_frequency);
>
> +#ifndef CONFIG_CPUFREQ
> sched_clock_register(r4k_read_sched_clock, 32, mips_hpt_frequency);
> +#endif
There is no config symbol CONFIG_CPUFREQ and I think if the clock may
change, we shouldn't register it as csrc or cevt.
Ralf
next prev parent reply other threads:[~2016-07-22 2:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 6:27 [PATCH 1/3] MIPS: Fix r4k clockevents registration Huacai Chen
2016-07-21 6:27 ` [PATCH 2/3] MIPS: Don't register r4k sched clock when CPUFREQ enabled Huacai Chen
2016-07-22 2:20 ` Ralf Baechle [this message]
2016-07-22 2:27 ` Ralf Baechle
2016-07-22 3:42 ` Huacai Chen
2016-07-21 6:27 ` [PATCH 3/3] MIPS: hpet: Increase HPET_MIN_PROG_DELTA and decrease HPET_MIN_CYCLES Huacai Chen
2016-07-22 3:25 ` [PATCH 1/3] MIPS: Fix r4k clockevents registration Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160722022007.GC25689@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=chenhc@lemote.com \
--cc=john@phrozen.org \
--cc=linux-mips@linux-mips.org \
--cc=stable@vger.kernel.org \
--cc=wuzhangjin@gmail.com \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.