From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Michael Weiser <michael.weiser@gmx.de>
Cc: linux-arm-kernel@lists.infradead.org,
Ulf Hansson <ulf.hansson@linaro.org>,
Chen-Yu Tsai <wens@csie.org>,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH 1/3] mmc: sunxi-mmc: change idma descriptor to __le32
Date: Fri, 22 Jul 2016 10:59:29 +0200 [thread overview]
Message-ID: <20160722085929.GA7687@lukather> (raw)
In-Reply-To: <20160721182329.13478-2-michael.weiser@gmx.de>
[-- Attachment #1: Type: text/plain, Size: 819 bytes --]
On Thu, Jul 21, 2016 at 08:23:27PM +0200, Michael Weiser wrote:
> The sunxi-mmc driver does not take into account the processor may be big
> endian when writing the DMA descriptors. This causes cards not to be
> detected when running a big-endian kernel. Change the descriptors for
> IDMA to use __le32 and ensure they are suitably swapped before writing.
> Tested successfully on the Cubieboard2.
>
> Signed-off-by: Michael Weiser <michael.weiser@gmx.de>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: linux-mmc@vger.kernel.org
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] mmc: sunxi-mmc: change idma descriptor to __le32
Date: Fri, 22 Jul 2016 10:59:29 +0200 [thread overview]
Message-ID: <20160722085929.GA7687@lukather> (raw)
In-Reply-To: <20160721182329.13478-2-michael.weiser@gmx.de>
On Thu, Jul 21, 2016 at 08:23:27PM +0200, Michael Weiser wrote:
> The sunxi-mmc driver does not take into account the processor may be big
> endian when writing the DMA descriptors. This causes cards not to be
> detected when running a big-endian kernel. Change the descriptors for
> IDMA to use __le32 and ensure they are suitably swapped before writing.
> Tested successfully on the Cubieboard2.
>
> Signed-off-by: Michael Weiser <michael.weiser@gmx.de>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: linux-mmc at vger.kernel.org
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160722/f4b399ca/attachment.sig>
next prev parent reply other threads:[~2016-07-22 8:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 18:23 [PATCH 0/3 v2] Fixes for running a big-endian kernel on Cubieboard2 Michael Weiser
2016-07-21 18:23 ` [PATCH 1/3] mmc: sunxi-mmc: change idma descriptor to __le32 Michael Weiser
2016-07-21 18:23 ` Michael Weiser
2016-07-22 8:59 ` Maxime Ripard [this message]
2016-07-22 8:59 ` Maxime Ripard
2016-07-21 18:23 ` [PATCH 2/3] stmmac: change dma descriptors " Michael Weiser
2016-07-21 18:23 ` Michael Weiser
2016-07-26 12:13 ` Giuseppe CAVALLARO
2016-07-26 12:13 ` Giuseppe CAVALLARO
2016-07-29 7:53 ` Michael Weiser
2016-07-29 7:53 ` Michael Weiser
2016-07-29 8:26 ` Giuseppe CAVALLARO
2016-07-29 8:26 ` Giuseppe CAVALLARO
2016-07-21 18:23 ` [PATCH 3/3] ARM: sunxi: enable big-endian Michael Weiser
2016-07-22 9:01 ` Maxime Ripard
2016-07-22 13:56 ` Michael Weiser
2016-07-25 12:25 ` Maxime Ripard
2016-07-26 19:26 ` Michael Weiser
2016-07-27 1:55 ` Chen-Yu Tsai
2016-07-29 7:59 ` Michael Weiser
2016-07-29 16:39 ` Maxime Ripard
2016-07-29 18:55 ` Michael Weiser
-- strict thread matches above, loose matches on Subject: below --
2016-07-18 16:23 [PATCH 0/3] Fixes for running a big-endian kernel on Cubieboard2 Michael Weiser
2016-07-18 16:23 ` [PATCH 1/3] mmc: sunxi-mmc: change idma descriptor to __le32 Michael Weiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160722085929.GA7687@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=michael.weiser@gmx.de \
--cc=ulf.hansson@linaro.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.