All of lore.kernel.org
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v1 0/2] Add Hisilicon Djtag driver
Date: Fri, 22 Jul 2016 11:56:49 +0100	[thread overview]
Message-ID: <20160722105648.GD17584@leverpostej> (raw)
In-Reply-To: <1469177332-72156-1-git-send-email-tanxiaojun@huawei.com>

Hi,

I understand that some SoC/socket level PMU is accessed via these
registers. It doesn't make sense to review either in isolation. Please
put together a unified series, with both the djtag accessors and the
PMU code.

On it's own, it's *very* difficult to understand how this fits into the
SoC, and how it is to be used.

Thanks,
Mark.

On Fri, Jul 22, 2016 at 04:48:50PM +0800, Tan Xiaojun wrote:
> 
> Tan Xiaojun (2):
>   Documentation: arm64: Add Hisilicon HiP05/06/07 Sysctrl and Djtag dts
>     bindings
>   drivers: soc: Add support for Hisilicon Djtag driver
> 
>  .../bindings/arm/hisilicon/hisilicon.txt           |   98 +++++
>  drivers/soc/Kconfig                                |    1 +
>  drivers/soc/Makefile                               |    1 +
>  drivers/soc/hisilicon/Kconfig                      |   12 +
>  drivers/soc/hisilicon/Makefile                     |    1 +
>  drivers/soc/hisilicon/djtag.c                      |  373 ++++++++++++++++++++
>  include/linux/soc/hisilicon/djtag.h                |   18 +
>  7 files changed, 504 insertions(+)
>  create mode 100644 drivers/soc/hisilicon/Kconfig
>  create mode 100644 drivers/soc/hisilicon/Makefile
>  create mode 100644 drivers/soc/hisilicon/djtag.c
>  create mode 100644 include/linux/soc/hisilicon/djtag.h
> 
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Tan Xiaojun <tanxiaojun@huawei.com>
Cc: devicetree@vger.kernel.org, k.kozlowski@samsung.com,
	khilman@linaro.org, qiang.zhao@freescale.com, heiko@sntech.de,
	pawel.moll@arm.com, ijc+devicetree@hellion.org.uk,
	f.fainelli@gmail.com, alex.aring@gmail.com, xuwei5@hisilicon.com,
	linux-kernel@vger.kernel.org, gregory.clement@free-electrons.com,
	robh+dt@kernel.org, galak@codeaurora.org,
	rmk+kernel@arm.linux.org.uk, amitdanielk@gmail.com,
	geert+renesas@glider.be, treding@nvidia.com,
	linux-arm-kernel@lists.infradead.org, wxt@rock-chips.com
Subject: Re: [RFC PATCH v1 0/2] Add Hisilicon Djtag driver
Date: Fri, 22 Jul 2016 11:56:49 +0100	[thread overview]
Message-ID: <20160722105648.GD17584@leverpostej> (raw)
In-Reply-To: <1469177332-72156-1-git-send-email-tanxiaojun@huawei.com>

Hi,

I understand that some SoC/socket level PMU is accessed via these
registers. It doesn't make sense to review either in isolation. Please
put together a unified series, with both the djtag accessors and the
PMU code.

On it's own, it's *very* difficult to understand how this fits into the
SoC, and how it is to be used.

Thanks,
Mark.

On Fri, Jul 22, 2016 at 04:48:50PM +0800, Tan Xiaojun wrote:
> 
> Tan Xiaojun (2):
>   Documentation: arm64: Add Hisilicon HiP05/06/07 Sysctrl and Djtag dts
>     bindings
>   drivers: soc: Add support for Hisilicon Djtag driver
> 
>  .../bindings/arm/hisilicon/hisilicon.txt           |   98 +++++
>  drivers/soc/Kconfig                                |    1 +
>  drivers/soc/Makefile                               |    1 +
>  drivers/soc/hisilicon/Kconfig                      |   12 +
>  drivers/soc/hisilicon/Makefile                     |    1 +
>  drivers/soc/hisilicon/djtag.c                      |  373 ++++++++++++++++++++
>  include/linux/soc/hisilicon/djtag.h                |   18 +
>  7 files changed, 504 insertions(+)
>  create mode 100644 drivers/soc/hisilicon/Kconfig
>  create mode 100644 drivers/soc/hisilicon/Makefile
>  create mode 100644 drivers/soc/hisilicon/djtag.c
>  create mode 100644 include/linux/soc/hisilicon/djtag.h
> 
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Tan Xiaojun <tanxiaojun@huawei.com>
Cc: robh+dt@kernel.org, pawel.moll@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	xuwei5@hisilicon.com, devicetree@vger.kernel.org,
	khilman@linaro.org, k.kozlowski@samsung.com,
	amitdanielk@gmail.com, heiko@sntech.de, wxt@rock-chips.com,
	alex.aring@gmail.com, qiang.zhao@freescale.com,
	treding@nvidia.com, rmk+kernel@arm.linux.org.uk,
	gregory.clement@free-electrons.com, f.fainelli@gmail.com,
	geert+renesas@glider.be, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH v1 0/2] Add Hisilicon Djtag driver
Date: Fri, 22 Jul 2016 11:56:49 +0100	[thread overview]
Message-ID: <20160722105648.GD17584@leverpostej> (raw)
In-Reply-To: <1469177332-72156-1-git-send-email-tanxiaojun@huawei.com>

Hi,

I understand that some SoC/socket level PMU is accessed via these
registers. It doesn't make sense to review either in isolation. Please
put together a unified series, with both the djtag accessors and the
PMU code.

On it's own, it's *very* difficult to understand how this fits into the
SoC, and how it is to be used.

Thanks,
Mark.

On Fri, Jul 22, 2016 at 04:48:50PM +0800, Tan Xiaojun wrote:
> 
> Tan Xiaojun (2):
>   Documentation: arm64: Add Hisilicon HiP05/06/07 Sysctrl and Djtag dts
>     bindings
>   drivers: soc: Add support for Hisilicon Djtag driver
> 
>  .../bindings/arm/hisilicon/hisilicon.txt           |   98 +++++
>  drivers/soc/Kconfig                                |    1 +
>  drivers/soc/Makefile                               |    1 +
>  drivers/soc/hisilicon/Kconfig                      |   12 +
>  drivers/soc/hisilicon/Makefile                     |    1 +
>  drivers/soc/hisilicon/djtag.c                      |  373 ++++++++++++++++++++
>  include/linux/soc/hisilicon/djtag.h                |   18 +
>  7 files changed, 504 insertions(+)
>  create mode 100644 drivers/soc/hisilicon/Kconfig
>  create mode 100644 drivers/soc/hisilicon/Makefile
>  create mode 100644 drivers/soc/hisilicon/djtag.c
>  create mode 100644 include/linux/soc/hisilicon/djtag.h
> 
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

  parent reply	other threads:[~2016-07-22 10:56 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-22  8:48 [RFC PATCH v1 0/2] Add Hisilicon Djtag driver Tan Xiaojun
2016-07-22  8:48 ` Tan Xiaojun
2016-07-22  8:48 ` Tan Xiaojun
2016-07-22  8:48 ` [RFC PATCH v1 1/2] Documentation: arm64: Add Hisilicon HiP05/06/07 Sysctrl and Djtag dts bindings Tan Xiaojun
2016-07-22  8:48   ` Tan Xiaojun
2016-07-22  8:48   ` Tan Xiaojun
2016-07-22  8:48 ` [RFC PATCH v1 2/2] drivers: soc: Add support for Hisilicon Djtag driver Tan Xiaojun
2016-07-22  8:48   ` Tan Xiaojun
2016-07-22  8:48   ` Tan Xiaojun
2016-07-22 20:37   ` Paul Gortmaker
2016-07-22 20:37     ` Paul Gortmaker
2016-07-22 20:37     ` Paul Gortmaker
2016-07-25  1:54     ` Tan Xiaojun
2016-07-25  1:54       ` Tan Xiaojun
2016-07-25  1:54       ` Tan Xiaojun
2016-07-27 20:40       ` Paul Gortmaker
2016-07-27 20:40         ` Paul Gortmaker
2016-07-27 20:40         ` Paul Gortmaker
2016-07-22 10:56 ` Mark Rutland [this message]
2016-07-22 10:56   ` [RFC PATCH v1 0/2] Add " Mark Rutland
2016-07-22 10:56   ` Mark Rutland
2016-07-22 13:27   ` Arnd Bergmann
2016-07-22 13:27     ` Arnd Bergmann
2016-07-25  2:09     ` Tan Xiaojun
2016-07-25  2:09       ` Tan Xiaojun
2016-07-25  2:09       ` Tan Xiaojun
2016-07-25  2:00   ` Tan Xiaojun
2016-07-25  2:00     ` Tan Xiaojun
2016-07-25  2:00     ` Tan Xiaojun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160722105648.GD17584@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.