From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Chen-Yu Tsai <wens@csie.org>,
linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree <devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/4] mmc: sunxi: Make sample clocks optional
Date: Mon, 25 Jul 2016 10:18:30 +0200 [thread overview]
Message-ID: <20160725081830.GF7419@lukather> (raw)
In-Reply-To: <1468665964-27142-3-git-send-email-hdegoede@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 941 bytes --]
Hi,
On Sat, Jul 16, 2016 at 12:46:02PM +0200, Hans de Goede wrote:
> It turns out that sun4i (A10) and sun5i (A13 & co) do not have sample
> clocks, so make them optional.
>
> Since these do not have sample clocks, they cannot (reliably) do
> DDR rates, so only set MMC_CAP_1_8V_DDR when we do have sample clks.
>
> Note this patch only changes the devm_clk_get error checking and sets
> the clocks to NULL if they don't exists. All the clk_foo calls accept
> a NULL clk and will return success when called with a NULL clk, so this
> is all that is necessary.
The clocks aren't really optional. They're not needed for the A10 /
A13, and mandatory for the A20 and later.
Having a new compatible for the A20 that would require that clock and
not require it for the A10/A13 anymore seems more appropriate.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] mmc: sunxi: Make sample clocks optional
Date: Mon, 25 Jul 2016 10:18:30 +0200 [thread overview]
Message-ID: <20160725081830.GF7419@lukather> (raw)
In-Reply-To: <1468665964-27142-3-git-send-email-hdegoede@redhat.com>
Hi,
On Sat, Jul 16, 2016 at 12:46:02PM +0200, Hans de Goede wrote:
> It turns out that sun4i (A10) and sun5i (A13 & co) do not have sample
> clocks, so make them optional.
>
> Since these do not have sample clocks, they cannot (reliably) do
> DDR rates, so only set MMC_CAP_1_8V_DDR when we do have sample clks.
>
> Note this patch only changes the devm_clk_get error checking and sets
> the clocks to NULL if they don't exists. All the clk_foo calls accept
> a NULL clk and will return success when called with a NULL clk, so this
> is all that is necessary.
The clocks aren't really optional. They're not needed for the A10 /
A13, and mandatory for the A20 and later.
Having a new compatible for the A20 that would require that clock and
not require it for the A10/A13 anymore seems more appropriate.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160725/dfdb0ee7/attachment-0001.sig>
next prev parent reply other threads:[~2016-07-25 8:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-16 10:46 [PATCH 0/4] mmc: sunxi: Make sample clocks optional Hans de Goede
2016-07-16 10:46 ` Hans de Goede
2016-07-16 10:46 ` [PATCH 1/4] mmc: sunxi: Disable sample clks on remove Hans de Goede
2016-07-16 10:46 ` Hans de Goede
2016-07-16 10:46 ` [PATCH 2/4] mmc: sunxi: Make sample clocks optional Hans de Goede
2016-07-16 10:46 ` Hans de Goede
2016-07-18 11:12 ` Ulf Hansson
2016-07-18 11:12 ` Ulf Hansson
2016-07-25 8:18 ` Maxime Ripard [this message]
2016-07-25 8:18 ` Maxime Ripard
2016-07-30 14:25 ` Hans de Goede
2016-07-30 14:25 ` Hans de Goede
2016-07-16 10:46 ` [PATCH 3/4] ARM: dts: sun4i: Remove sample clocks from mmc host nodes Hans de Goede
2016-07-16 10:46 ` Hans de Goede
[not found] ` <1468665964-27142-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-07-16 10:46 ` [PATCH 4/4] ARM: dts: sun5i: " Hans de Goede
2016-07-16 10:46 ` Hans de Goede
2016-07-19 8:59 ` [PATCH 0/4] mmc: sunxi: Make sample clocks optional Icenowy Zheng
2016-07-19 8:59 ` Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160725081830.GF7419@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.