From: Viresh Kumar <viresh.kumar@linaro.org>
To: Jisheng Zhang <jszhang@marvell.com>
Cc: vireshk@kernel.org, nm@ti.com, sboyd@codeaurora.org,
rjw@rjwysocki.net, gregkh@linuxfoundation.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] PM / OPP: optimize dev_pm_opp_set_rate() performance a bit
Date: Mon, 25 Jul 2016 15:34:10 -0700 [thread overview]
Message-ID: <20160725223410.GF25667@ubuntu> (raw)
In-Reply-To: <1469427076-2078-1-git-send-email-jszhang@marvell.com>
On 25-07-16, 14:11, Jisheng Zhang wrote:
> In dev_pm_opp_set_rate(), _find_opp_table() is called 4 times: once by
> _get_opp_clk(), once by dev_pm_opp_set_rate() itself, and twice by
> dev_pm_opp_find_freq_ceil(). If there are several opp_tables in the
> system, three times of opp table finding is a big waste. This patch
> reduced the call of _find_opp_table() to twice.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
> Since v2:
> - fix gcc warnings
>
> Since v1:
> - avoid opp_table pointer usage after the rcu_read_unlock() as pointed
> out by Viresh, thus we can only reduced the call of _find_opp_table
> to twice.
>
> drivers/base/power/opp/core.c | 31 +++++++++++++++++++------------
> 1 file changed, 19 insertions(+), 12 deletions(-)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
WARNING: multiple messages have this Message-ID (diff)
From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] PM / OPP: optimize dev_pm_opp_set_rate() performance a bit
Date: Mon, 25 Jul 2016 15:34:10 -0700 [thread overview]
Message-ID: <20160725223410.GF25667@ubuntu> (raw)
In-Reply-To: <1469427076-2078-1-git-send-email-jszhang@marvell.com>
On 25-07-16, 14:11, Jisheng Zhang wrote:
> In dev_pm_opp_set_rate(), _find_opp_table() is called 4 times: once by
> _get_opp_clk(), once by dev_pm_opp_set_rate() itself, and twice by
> dev_pm_opp_find_freq_ceil(). If there are several opp_tables in the
> system, three times of opp table finding is a big waste. This patch
> reduced the call of _find_opp_table() to twice.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
> Since v2:
> - fix gcc warnings
>
> Since v1:
> - avoid opp_table pointer usage after the rcu_read_unlock() as pointed
> out by Viresh, thus we can only reduced the call of _find_opp_table
> to twice.
>
> drivers/base/power/opp/core.c | 31 +++++++++++++++++++------------
> 1 file changed, 19 insertions(+), 12 deletions(-)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
next prev parent reply other threads:[~2016-07-25 22:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 6:11 [PATCH v3] PM / OPP: optimize dev_pm_opp_set_rate() performance a bit Jisheng Zhang
2016-07-25 6:11 ` Jisheng Zhang
2016-07-25 6:11 ` Jisheng Zhang
2016-07-25 22:34 ` Viresh Kumar [this message]
2016-07-25 22:34 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160725223410.GF25667@ubuntu \
--to=viresh.kumar@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.