From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clocksource: sun4i: Clear interrupts after stopping timer in probe function
Date: Tue, 26 Jul 2016 07:49:37 +0200 [thread overview]
Message-ID: <20160726054937.GS7419@lukather> (raw)
In-Reply-To: <1469502119-2344-1-git-send-email-wens@csie.org>
On Tue, Jul 26, 2016 at 11:01:59AM +0800, Chen-Yu Tsai wrote:
> The bootloader (U-boot) sometimes uses this timer for various delays.
> It uses it as a ongoing counter, and does comparisons on the current
> counter value. The timer counter is never stopped.
>
> In some cases when the user interacts with the bootloader, or lets
> it idle for some time before loading Linux, the timer may expire,
> and an interrupt will be pending. This results in an unexpected
> interrupt when the timer interrupt is enabled by the kernel, at
> which point the event_handler isn't set yet. This results in a NULL
> pointer dereference exception, panic, and no way to reboot.
>
> Clear any pending interrupts after we stop the timer in the probe
> function to avoid this.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Awesome, thanks!
You should put stable in Cc though for this kind of patches.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160726/2725019d/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clocksource: sun4i: Clear interrupts after stopping timer in probe function
Date: Tue, 26 Jul 2016 07:49:37 +0200 [thread overview]
Message-ID: <20160726054937.GS7419@lukather> (raw)
In-Reply-To: <1469502119-2344-1-git-send-email-wens@csie.org>
[-- Attachment #1: Type: text/plain, Size: 1022 bytes --]
On Tue, Jul 26, 2016 at 11:01:59AM +0800, Chen-Yu Tsai wrote:
> The bootloader (U-boot) sometimes uses this timer for various delays.
> It uses it as a ongoing counter, and does comparisons on the current
> counter value. The timer counter is never stopped.
>
> In some cases when the user interacts with the bootloader, or lets
> it idle for some time before loading Linux, the timer may expire,
> and an interrupt will be pending. This results in an unexpected
> interrupt when the timer interrupt is enabled by the kernel, at
> which point the event_handler isn't set yet. This results in a NULL
> pointer dereference exception, panic, and no way to reboot.
>
> Clear any pending interrupts after we stop the timer in the probe
> function to avoid this.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Awesome, thanks!
You should put stable in Cc though for this kind of patches.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-07-26 5:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 3:01 [PATCH] clocksource: sun4i: Clear interrupts after stopping timer in probe function Chen-Yu Tsai
2016-07-26 3:01 ` Chen-Yu Tsai
2016-07-26 5:49 ` Maxime Ripard [this message]
2016-07-26 5:49 ` Maxime Ripard
2016-07-26 6:42 ` Chen-Yu Tsai
2016-07-26 6:42 ` Chen-Yu Tsai
2016-07-26 9:07 ` Thomas Gleixner
2016-07-26 9:07 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160726054937.GS7419@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.