From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Jean-Francois Moine <moinejf@free.fr>
Cc: Chen-Yu Tsai <wens@csie.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, dev@linux-sunxi.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/9] clk: sunxi-ng: mux: Add support for mux tables
Date: Thu, 28 Jul 2016 15:28:42 +0200 [thread overview]
Message-ID: <20160728132842.GA6682@lukather> (raw)
In-Reply-To: <20160727103649.9e6ef332847b5a5c8fac66af@free.fr>
[-- Attachment #1: Type: text/plain, Size: 963 bytes --]
On Wed, Jul 27, 2016 at 10:36:49AM +0200, Jean-Francois Moine wrote:
> On Wed, 27 Jul 2016 09:40:20 +0200
> Maxime Ripard <maxime.ripard@free-electrons.com> wrote:
>
> > > > Parenting functions would also not work as expected,
> > > > clk_hw_get_parent_by_index being the obvious example, in that case
> > > > returning the empty string for an invalid parent, while it should
> > > > really return NULL.
> > >
> > > I don't see why the clock should be orphan.
> > > Then, when a parent is "", clk_hw_get_parent_by_index() returns NULL.
> >
> > Why? It should return NULL when there's no parent, while you
> > explicitly registered a parent.
>
> "" is not an existing parent. It could be "none" / "dum" / "toto" / ...
> with the same result: 'this index cannot be used in mux'.
And the clock is marked as orphan, while it really isn't.
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/9] clk: sunxi-ng: mux: Add support for mux tables
Date: Thu, 28 Jul 2016 15:28:42 +0200 [thread overview]
Message-ID: <20160728132842.GA6682@lukather> (raw)
In-Reply-To: <20160727103649.9e6ef332847b5a5c8fac66af@free.fr>
On Wed, Jul 27, 2016 at 10:36:49AM +0200, Jean-Francois Moine wrote:
> On Wed, 27 Jul 2016 09:40:20 +0200
> Maxime Ripard <maxime.ripard@free-electrons.com> wrote:
>
> > > > Parenting functions would also not work as expected,
> > > > clk_hw_get_parent_by_index being the obvious example, in that case
> > > > returning the empty string for an invalid parent, while it should
> > > > really return NULL.
> > >
> > > I don't see why the clock should be orphan.
> > > Then, when a parent is "", clk_hw_get_parent_by_index() returns NULL.
> >
> > Why? It should return NULL when there's no parent, while you
> > explicitly registered a parent.
>
> "" is not an existing parent. It could be "none" / "dum" / "toto" / ...
> with the same result: 'this index cannot be used in mux'.
And the clock is marked as orphan, while it really isn't.
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160728/82b5fabd/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Jean-Francois Moine <moinejf-GANU6spQydw@public.gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Michael Turquette
<mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dev-3kdeTeqwOZ9EV1b7eY7vFQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 4/9] clk: sunxi-ng: mux: Add support for mux tables
Date: Thu, 28 Jul 2016 15:28:42 +0200 [thread overview]
Message-ID: <20160728132842.GA6682@lukather> (raw)
In-Reply-To: <20160727103649.9e6ef332847b5a5c8fac66af-GANU6spQydw@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 969 bytes --]
On Wed, Jul 27, 2016 at 10:36:49AM +0200, Jean-Francois Moine wrote:
> On Wed, 27 Jul 2016 09:40:20 +0200
> Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
>
> > > > Parenting functions would also not work as expected,
> > > > clk_hw_get_parent_by_index being the obvious example, in that case
> > > > returning the empty string for an invalid parent, while it should
> > > > really return NULL.
> > >
> > > I don't see why the clock should be orphan.
> > > Then, when a parent is "", clk_hw_get_parent_by_index() returns NULL.
> >
> > Why? It should return NULL when there's no parent, while you
> > explicitly registered a parent.
>
> "" is not an existing parent. It could be "none" / "dum" / "toto" / ...
> with the same result: 'this index cannot be used in mux'.
And the clock is marked as orphan, while it really isn't.
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-07-28 13:28 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 7:04 [PATCH 0/9] clk: sunxi-ng: Support A31/A31s CCU Chen-Yu Tsai
2016-07-26 7:04 ` Chen-Yu Tsai
2016-07-26 7:04 ` Chen-Yu Tsai
2016-07-26 7:04 ` [PATCH resend 1/9] clk: sunxi-ng: Fix inverted test condition in ccu_helper_wait_for_lock Chen-Yu Tsai
2016-07-26 7:04 ` Chen-Yu Tsai
2016-07-26 7:04 ` Chen-Yu Tsai
2016-07-26 8:56 ` Maxime Ripard
2016-07-26 8:56 ` Maxime Ripard
2016-07-26 8:56 ` Maxime Ripard
2016-07-26 7:04 ` [PATCH 2/9] clk: sunxi-ng: nk: Make ccu_nk_find_best static Chen-Yu Tsai
2016-07-26 7:04 ` Chen-Yu Tsai
2016-07-26 7:04 ` Chen-Yu Tsai
2016-07-26 8:57 ` Maxime Ripard
2016-07-26 8:57 ` Maxime Ripard
2016-07-26 8:57 ` Maxime Ripard
2016-07-26 7:04 ` [PATCH 3/9] clk: sunxi-ng: mux: Increase fixed pre-divider div size Chen-Yu Tsai
2016-07-26 7:04 ` Chen-Yu Tsai
2016-07-27 6:43 ` Maxime Ripard
2016-07-27 6:43 ` Maxime Ripard
2016-07-27 6:43 ` Maxime Ripard
2016-07-26 7:04 ` [PATCH 4/9] clk: sunxi-ng: mux: Add support for mux tables Chen-Yu Tsai
2016-07-26 7:04 ` Chen-Yu Tsai
2016-07-26 17:43 ` Jean-Francois Moine
2016-07-26 17:43 ` Jean-Francois Moine
2016-07-26 17:43 ` Jean-Francois Moine
2016-07-27 6:59 ` Maxime Ripard
2016-07-27 6:59 ` Maxime Ripard
2016-07-27 7:18 ` Jean-Francois Moine
2016-07-27 7:18 ` Jean-Francois Moine
2016-07-27 7:18 ` Jean-Francois Moine
2016-07-27 7:30 ` Chen-Yu Tsai
2016-07-27 7:30 ` Chen-Yu Tsai
2016-07-27 7:40 ` Maxime Ripard
2016-07-27 7:40 ` Maxime Ripard
2016-07-27 7:40 ` Maxime Ripard
2016-07-27 8:36 ` Jean-Francois Moine
2016-07-27 8:36 ` Jean-Francois Moine
2016-07-27 8:36 ` Jean-Francois Moine
2016-07-28 13:28 ` Maxime Ripard [this message]
2016-07-28 13:28 ` Maxime Ripard
2016-07-28 13:28 ` Maxime Ripard
2016-07-28 14:23 ` Jean-Francois Moine
2016-07-28 14:23 ` Jean-Francois Moine
2016-07-28 14:23 ` Jean-Francois Moine
2016-07-28 14:23 ` Jean-Francois Moine
2016-07-27 6:48 ` Maxime Ripard
2016-07-27 6:48 ` Maxime Ripard
2016-07-27 6:48 ` Maxime Ripard
2016-07-26 7:04 ` [PATCH 5/9] clk: sunxi-ng: mux: support fixed pre-dividers on multiple parents Chen-Yu Tsai
2016-07-26 7:04 ` Chen-Yu Tsai
2016-07-26 7:04 ` Chen-Yu Tsai
2016-07-27 7:26 ` Maxime Ripard
2016-07-27 7:26 ` Maxime Ripard
2016-07-27 7:26 ` Maxime Ripard
2016-07-27 8:38 ` Jean-Francois Moine
2016-07-27 8:38 ` Jean-Francois Moine
2016-07-27 8:38 ` Jean-Francois Moine
2016-07-26 7:04 ` [PATCH 6/9] clk: sunxi-ng: nkm: Add mux to support " Chen-Yu Tsai
2016-07-26 7:04 ` Chen-Yu Tsai
2016-07-26 7:04 ` Chen-Yu Tsai
2016-07-27 7:27 ` Maxime Ripard
2016-07-27 7:27 ` Maxime Ripard
2016-07-27 7:27 ` Maxime Ripard
2016-07-26 7:04 ` [PATCH 7/9] clk: sunxi-ng: mux: Add clk notifier functions Chen-Yu Tsai
2016-07-26 7:04 ` Chen-Yu Tsai
2016-07-26 7:04 ` Chen-Yu Tsai
2016-07-27 7:30 ` Maxime Ripard
2016-07-27 7:30 ` Maxime Ripard
2016-07-27 7:30 ` Maxime Ripard
2016-07-27 7:32 ` Chen-Yu Tsai
2016-07-27 7:32 ` Chen-Yu Tsai
2016-07-27 7:43 ` Maxime Ripard
2016-07-27 7:43 ` Maxime Ripard
2016-07-27 7:43 ` Maxime Ripard
2016-07-26 7:04 ` [PATCH 8/9] clk: sunxi-ng: Add A31/A31s clocks Chen-Yu Tsai
2016-07-26 7:04 ` Chen-Yu Tsai
2016-07-26 7:04 ` Chen-Yu Tsai
2016-07-26 8:30 ` Jean-Francois Moine
2016-07-26 8:30 ` Jean-Francois Moine
2016-07-26 8:30 ` Jean-Francois Moine
2016-07-27 14:59 ` Rob Herring
2016-07-27 14:59 ` Rob Herring
2016-07-28 13:31 ` Maxime Ripard
2016-07-28 13:31 ` Maxime Ripard
2016-07-28 13:31 ` Maxime Ripard
2016-07-26 7:04 ` [PATCH 9/9] ARM: dts: sun6i: switch A31/A31s to new CCU clock bindings Chen-Yu Tsai
2016-07-26 7:04 ` Chen-Yu Tsai
2016-07-26 7:04 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160728132842.GA6682@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=dev@linux-sunxi.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=moinejf@free.fr \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.