* [PATCH] kexec: fix mem_regions_sort()
@ 2016-07-27 17:49 Pratyush Anand
2016-07-27 17:52 ` Pratyush Anand
0 siblings, 1 reply; 6+ messages in thread
From: Pratyush Anand @ 2016-07-27 17:49 UTC (permalink / raw)
To: kexec
ranges->ranges is "struct memory_range *", however each element which need
to be sorted is of type "struct memory_range". So, correct "size" argument
of qsort() as sizeof(*ranges->ranges).
Signed-off-by: Pratyush Anand <panand@redhat.com>
Cc:Russell King <rmk@arm.linux.org.uk>
Cc:Simon Horman <horms@verge.net.au>
---
kexec/mem_regions.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kexec/mem_regions.c b/kexec/mem_regions.c
index e61c07472f1b..50c8abccb93a 100644
--- a/kexec/mem_regions.c
+++ b/kexec/mem_regions.c
@@ -24,7 +24,7 @@ static int mem_range_cmp(const void *a1, const void *a2)
*/
void mem_regions_sort(struct memory_ranges *ranges)
{
- qsort(ranges->ranges, ranges->size, sizeof(ranges->ranges),
+ qsort(ranges->ranges, ranges->size, sizeof(*ranges->ranges),
mem_range_cmp);
}
--
2.5.5
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] kexec: fix mem_regions_sort()
2016-07-27 17:49 [PATCH] kexec: fix mem_regions_sort() Pratyush Anand
@ 2016-07-27 17:52 ` Pratyush Anand
2016-07-28 14:38 ` Russell King
0 siblings, 1 reply; 6+ messages in thread
From: Pratyush Anand @ 2016-07-27 17:52 UTC (permalink / raw)
To: Kexec Mailing List; +Cc: Russell King
Missed CCing Russell because of --suppress-cc :(
CCing now.
On Wed, Jul 27, 2016 at 11:19 PM, Pratyush Anand <panand@redhat.com> wrote:
> ranges->ranges is "struct memory_range *", however each element which need
> to be sorted is of type "struct memory_range". So, correct "size" argument
> of qsort() as sizeof(*ranges->ranges).
>
> Signed-off-by: Pratyush Anand <panand@redhat.com>
> Cc:Russell King <rmk@arm.linux.org.uk>
> Cc:Simon Horman <horms@verge.net.au>
> ---
> kexec/mem_regions.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kexec/mem_regions.c b/kexec/mem_regions.c
> index e61c07472f1b..50c8abccb93a 100644
> --- a/kexec/mem_regions.c
> +++ b/kexec/mem_regions.c
> @@ -24,7 +24,7 @@ static int mem_range_cmp(const void *a1, const void *a2)
> */
> void mem_regions_sort(struct memory_ranges *ranges)
> {
> - qsort(ranges->ranges, ranges->size, sizeof(ranges->ranges),
> + qsort(ranges->ranges, ranges->size, sizeof(*ranges->ranges),
> mem_range_cmp);
> }
>
> --
> 2.5.5
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] kexec: fix mem_regions_sort()
2016-07-27 17:52 ` Pratyush Anand
@ 2016-07-28 14:38 ` Russell King
2016-07-29 3:52 ` Pratyush Anand
0 siblings, 1 reply; 6+ messages in thread
From: Russell King @ 2016-07-28 14:38 UTC (permalink / raw)
To: Pratyush Anand; +Cc: Kexec Mailing List
On Wed, Jul 27, 2016 at 11:22:24PM +0530, Pratyush Anand wrote:
> Missed CCing Russell because of --suppress-cc :(
>
> CCing now.
>
> On Wed, Jul 27, 2016 at 11:19 PM, Pratyush Anand <panand@redhat.com> wrote:
> > ranges->ranges is "struct memory_range *", however each element which need
> > to be sorted is of type "struct memory_range". So, correct "size" argument
> > of qsort() as sizeof(*ranges->ranges).
Oops. Yes, obviously correct.
Acked-by: Russell King <rmk@armlinux.org.uk>
> >
> > Signed-off-by: Pratyush Anand <panand@redhat.com>
> > Cc:Russell King <rmk@arm.linux.org.uk>
Please remove this Cc while adding my Acked-by. Thanks.
--
Russell King
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kexec: fix mem_regions_sort()
2016-07-28 14:38 ` Russell King
@ 2016-07-29 3:52 ` Pratyush Anand
2016-08-09 3:25 ` Pratyush Anand
2016-09-29 7:47 ` Simon Horman
0 siblings, 2 replies; 6+ messages in thread
From: Pratyush Anand @ 2016-07-29 3:52 UTC (permalink / raw)
To: Simon Horman; +Cc: Russell King, Kexec Mailing List
Hi Simon,
Please take this fix for 2.0.13.
~Pratyush
On 28/07/2016:03:38:46 PM, Russell King wrote:
> On Wed, Jul 27, 2016 at 11:22:24PM +0530, Pratyush Anand wrote:
> > Missed CCing Russell because of --suppress-cc :(
> >
> > CCing now.
> >
> > On Wed, Jul 27, 2016 at 11:19 PM, Pratyush Anand <panand@redhat.com> wrote:
> > > ranges->ranges is "struct memory_range *", however each element which need
> > > to be sorted is of type "struct memory_range". So, correct "size" argument
> > > of qsort() as sizeof(*ranges->ranges).
>
> Oops. Yes, obviously correct.
>
> Acked-by: Russell King <rmk@armlinux.org.uk>
>
> > >
> > > Signed-off-by: Pratyush Anand <panand@redhat.com>
> > > Cc:Russell King <rmk@arm.linux.org.uk>
>
> Please remove this Cc while adding my Acked-by. Thanks.
>
> --
> Russell King
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kexec: fix mem_regions_sort()
2016-07-29 3:52 ` Pratyush Anand
@ 2016-08-09 3:25 ` Pratyush Anand
2016-09-29 7:47 ` Simon Horman
1 sibling, 0 replies; 6+ messages in thread
From: Pratyush Anand @ 2016-08-09 3:25 UTC (permalink / raw)
To: Simon Horman; +Cc: Russell King, Kexec Mailing List
Hi Simon,
This was a fixup which got missed in 2.0.13.
Anyway, it can be taken now.
Thanks
~Pratyush
On 29/07/2016:09:22:19 AM, Pratyush Anand wrote:
> Hi Simon,
>
> Please take this fix for 2.0.13.
>
> ~Pratyush
> On 28/07/2016:03:38:46 PM, Russell King wrote:
> > On Wed, Jul 27, 2016 at 11:22:24PM +0530, Pratyush Anand wrote:
> > > Missed CCing Russell because of --suppress-cc :(
> > >
> > > CCing now.
> > >
> > > On Wed, Jul 27, 2016 at 11:19 PM, Pratyush Anand <panand@redhat.com> wrote:
> > > > ranges->ranges is "struct memory_range *", however each element which need
> > > > to be sorted is of type "struct memory_range". So, correct "size" argument
> > > > of qsort() as sizeof(*ranges->ranges).
> >
> > Oops. Yes, obviously correct.
> >
> > Acked-by: Russell King <rmk@armlinux.org.uk>
> >
> > > >
> > > > Signed-off-by: Pratyush Anand <panand@redhat.com>
> > > > Cc:Russell King <rmk@arm.linux.org.uk>
> >
> > Please remove this Cc while adding my Acked-by. Thanks.
> >
> > --
> > Russell King
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kexec: fix mem_regions_sort()
2016-07-29 3:52 ` Pratyush Anand
2016-08-09 3:25 ` Pratyush Anand
@ 2016-09-29 7:47 ` Simon Horman
1 sibling, 0 replies; 6+ messages in thread
From: Simon Horman @ 2016-09-29 7:47 UTC (permalink / raw)
To: Pratyush Anand; +Cc: Russell King, Kexec Mailing List
On Fri, Jul 29, 2016 at 09:22:19AM +0530, Pratyush Anand wrote:
> Hi Simon,
>
> Please take this fix for 2.0.13.
>
> ~Pratyush
> On 28/07/2016:03:38:46 PM, Russell King wrote:
> > On Wed, Jul 27, 2016 at 11:22:24PM +0530, Pratyush Anand wrote:
> > > Missed CCing Russell because of --suppress-cc :(
> > >
> > > CCing now.
> > >
> > > On Wed, Jul 27, 2016 at 11:19 PM, Pratyush Anand <panand@redhat.com> wrote:
> > > > ranges->ranges is "struct memory_range *", however each element which need
> > > > to be sorted is of type "struct memory_range". So, correct "size" argument
> > > > of qsort() as sizeof(*ranges->ranges).
> >
> > Oops. Yes, obviously correct.
> >
> > Acked-by: Russell King <rmk@armlinux.org.uk>
> >
> > > >
> > > > Signed-off-by: Pratyush Anand <panand@redhat.com>
> > > > Cc:Russell King <rmk@arm.linux.org.uk>
> >
> > Please remove this Cc while adding my Acked-by. Thanks.
Sorry, I completely missed this until now.
Applied.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-29 7:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-27 17:49 [PATCH] kexec: fix mem_regions_sort() Pratyush Anand
2016-07-27 17:52 ` Pratyush Anand
2016-07-28 14:38 ` Russell King
2016-07-29 3:52 ` Pratyush Anand
2016-08-09 3:25 ` Pratyush Anand
2016-09-29 7:47 ` Simon Horman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.