From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/2] nvme-rdma: Don't leak uninitialized memory in connect request private data
Date: Mon, 1 Aug 2016 13:07:44 +0200 [thread overview]
Message-ID: <20160801110744.GG16141@lst.de> (raw)
In-Reply-To: <1469950060-18098-1-git-send-email-roland@kernel.org>
On Sun, Jul 31, 2016@12:27:39AM -0700, Roland Dreier wrote:
> From: Roland Dreier <roland at purestorage.com>
>
> Zero out the full nvme_rdma_cm_req structure before sending it.
> Otherwise we end up leaking kernel memory in the reserved field, which
> might break forward compatibility in the future.
>
> Signed-off-by: Roland Dreier <roland at purestorage.com>
Looks fine,
Reviewed-by: Christoph Hellwig <hch at lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Jens Axboe <axboe-b10kYP2dOMg@public.gmane.org>,
Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] nvme-rdma: Don't leak uninitialized memory in connect request private data
Date: Mon, 1 Aug 2016 13:07:44 +0200 [thread overview]
Message-ID: <20160801110744.GG16141@lst.de> (raw)
In-Reply-To: <1469950060-18098-1-git-send-email-roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
On Sun, Jul 31, 2016 at 12:27:39AM -0700, Roland Dreier wrote:
> From: Roland Dreier <roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org>
>
> Zero out the full nvme_rdma_cm_req structure before sending it.
> Otherwise we end up leaking kernel memory in the reserved field, which
> might break forward compatibility in the future.
>
> Signed-off-by: Roland Dreier <roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org>
Looks fine,
Reviewed-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-08-01 11:07 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-31 7:27 [PATCH 1/2] nvme-rdma: Don't leak uninitialized memory in connect request private data Roland Dreier
2016-07-31 7:27 ` Roland Dreier
2016-07-31 7:27 ` [PATCH 2/2] nvme-rdma: Add handling for connecting to IPv6 targets Roland Dreier
2016-07-31 7:27 ` Roland Dreier
2016-07-31 8:45 ` Sagi Grimberg
2016-07-31 8:45 ` Sagi Grimberg
2016-07-31 10:58 ` Sagi Grimberg
2016-07-31 10:58 ` Sagi Grimberg
2016-07-31 15:33 ` Roland Dreier
2016-07-31 15:33 ` Roland Dreier
2016-08-01 5:58 ` Sagi Grimberg
2016-08-01 5:58 ` Sagi Grimberg
2016-08-01 6:15 ` Sagi Grimberg
2016-08-01 6:15 ` Sagi Grimberg
2016-08-01 11:09 ` Christoph Hellwig
2016-08-01 11:09 ` Christoph Hellwig
2016-08-01 11:24 ` Sagi Grimberg
2016-08-01 11:24 ` Sagi Grimberg
2016-08-01 15:50 ` Christoph Hellwig
2016-08-01 15:50 ` Christoph Hellwig
2016-08-01 16:06 ` Roland Dreier
2016-08-01 16:06 ` Roland Dreier
2016-08-02 6:43 ` Sagi Grimberg
2016-08-02 6:43 ` Sagi Grimberg
2016-08-02 12:51 ` Christoph Hellwig
2016-08-02 12:51 ` Christoph Hellwig
2016-08-18 7:44 ` Sagi Grimberg
2016-08-18 7:44 ` Sagi Grimberg
2016-08-22 4:44 ` Roland Dreier
2016-08-22 4:44 ` Roland Dreier
2016-08-22 6:47 ` Sagi Grimberg
2016-08-22 6:47 ` Sagi Grimberg
2016-08-02 6:41 ` Sagi Grimberg
2016-08-02 6:41 ` Sagi Grimberg
2016-08-01 11:09 ` Christoph Hellwig
2016-08-01 11:09 ` Christoph Hellwig
2016-07-31 8:44 ` [PATCH 1/2] nvme-rdma: Don't leak uninitialized memory in connect request private data Sagi Grimberg
2016-07-31 8:44 ` Sagi Grimberg
2016-08-01 11:07 ` Christoph Hellwig [this message]
2016-08-01 11:07 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160801110744.GG16141@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.